build: update required-minimum-review group to be global approvable (#37636)

Previously, the required-minimum-review group was still considered active when
a global approval was provided.  This would result in global approvers needing
to Reviewd-For both the global approval and minimum review groups.  Instead
when a global approver provides their approval, the minimum review group should
be considered satisified.

PR Close #37636
This commit is contained in:
Joey Perrott 2020-06-18 08:26:46 -07:00 committed by Misko Hevery
parent 1f0818002c
commit d0c69d207c
1 changed files with 39 additions and 36 deletions

View File

@ -96,6 +96,42 @@ pullapprove_conditions:
groups: groups:
# =========================================================
# Global Approvers
#
# All reviews performed for global approvals require using
# the `Reviewed-for:` specifier to set the approval
# specificity as documented at:
# https://docs.pullapprove.com/reviewed-for/
# =========================================================
global-approvers:
type: optional
reviewers:
teams:
- framework-global-approvers
reviews:
request: 0
required: 1
reviewed_for: required
# =========================================================
# Global Approvers For Docs
#
# All reviews performed for global docs approvals require
# using the `Reviewed-for:` specifier to set the approval
# specificity as documented at:
# https://docs.pullapprove.com/reviewed-for/
# =========================================================
global-docs-approvers:
type: optional
reviewers:
teams:
- framework-global-approvers-for-docs-only-changes
reviews:
request: 0
required: 1
reviewed_for: required
# ========================================================= # =========================================================
# Require review on all PRs # Require review on all PRs
# #
@ -104,6 +140,9 @@ groups:
# one review is provided before the group is satisfied. # one review is provided before the group is satisfied.
# ========================================================= # =========================================================
required-minimum-review: required-minimum-review:
conditions:
- *can-be-global-approved
- *can-be-global-docs-approved
reviews: reviews:
request: 0 # Do not request any reviews from the reviewer group request: 0 # Do not request any reviews from the reviewer group
required: 1 # Require that all PRs have approval from at least one of the users in the group required: 1 # Require that all PRs have approval from at least one of the users in the group
@ -145,42 +184,6 @@ groups:
- Splaktar # Michael Prentice - Splaktar # Michael Prentice
- StephenFluin # Stephen Fluin - StephenFluin # Stephen Fluin
# =========================================================
# Global Approvers
#
# All reviews performed for global approvals require using
# the `Reviewed-for:` specifier to set the approval
# specificity as documented at:
# https://docs.pullapprove.com/reviewed-for/
# =========================================================
global-approvers:
type: optional
reviewers:
teams:
- framework-global-approvers
reviews:
request: 0
required: 1
reviewed_for: required
# =========================================================
# Global Approvers For Docs
#
# All reviews performed for global docs approvals require
# using the `Reviewed-for:` specifier to set the approval
# specificity as documented at:
# https://docs.pullapprove.com/reviewed-for/
# =========================================================
global-docs-approvers:
type: optional
reviewers:
teams:
- framework-global-approvers-for-docs-only-changes
reviews:
request: 0
required: 1
reviewed_for: required
# ========================================================= # =========================================================
# Framework: Animations # Framework: Animations
# ========================================================= # =========================================================