From d0db9ded90c254bf7ea9021cca120beb2b7e5406 Mon Sep 17 00:00:00 2001 From: Ward Bell Date: Tue, 20 Feb 2018 17:10:46 -0800 Subject: [PATCH] docs: fix cli-quickstart doc and specs (#22338) * tests were broken * incorrect instructions. * didn't match current CLI template for new project PR Close #22338 --- .../cli-quickstart/src/app/app.component.html | 11 +++++------ .../cli-quickstart/src/app/app.component.spec.ts | 6 ++---- .../examples/cli-quickstart/src/app/app.component.ts | 2 +- aio/content/guide/quickstart.md | 2 +- 4 files changed, 9 insertions(+), 12 deletions(-) diff --git a/aio/content/examples/cli-quickstart/src/app/app.component.html b/aio/content/examples/cli-quickstart/src/app/app.component.html index 1a1d09dc78..24c56edee4 100644 --- a/aio/content/examples/cli-quickstart/src/app/app.component.html +++ b/aio/content/examples/cli-quickstart/src/app/app.component.html @@ -1,20 +1,19 @@

- Welcome to {{title}}!! + Welcome to {{ title }}!

- Angular logo + Angular Logo

Here are some links to help you start:

- diff --git a/aio/content/examples/cli-quickstart/src/app/app.component.spec.ts b/aio/content/examples/cli-quickstart/src/app/app.component.spec.ts index 7d2799ceb6..1f5da50d19 100644 --- a/aio/content/examples/cli-quickstart/src/app/app.component.spec.ts +++ b/aio/content/examples/cli-quickstart/src/app/app.component.spec.ts @@ -1,7 +1,5 @@ import { TestBed, async } from '@angular/core/testing'; - import { AppComponent } from './app.component'; - describe('AppComponent', () => { beforeEach(async(() => { TestBed.configureTestingModule({ @@ -20,13 +18,13 @@ describe('AppComponent', () => { it(`should have as title 'app'`, async(() => { const fixture = TestBed.createComponent(AppComponent); const app = fixture.debugElement.componentInstance; - expect(app.title).toEqual('app'); + expect(app.title).toMatch(/app/i); })); it('should render title in a h1 tag', async(() => { const fixture = TestBed.createComponent(AppComponent); fixture.detectChanges(); const compiled = fixture.debugElement.nativeElement; - expect(compiled.querySelector('h1').textContent).toContain('Welcome to app!!'); + expect(compiled.querySelector('h1').textContent).toMatch(/app/i); })); }); diff --git a/aio/content/examples/cli-quickstart/src/app/app.component.ts b/aio/content/examples/cli-quickstart/src/app/app.component.ts index 4c1b4a9bf7..d977bbe40a 100644 --- a/aio/content/examples/cli-quickstart/src/app/app.component.ts +++ b/aio/content/examples/cli-quickstart/src/app/app.component.ts @@ -11,6 +11,6 @@ import { Component } from '@angular/core'; // #enddocregion metadata // #docregion title, class export class AppComponent { - title = 'My First Angular App'; + title = 'My First Angular App!'; } // #enddocregion title, class diff --git a/aio/content/guide/quickstart.md b/aio/content/guide/quickstart.md index 6d94197581..6ea0489188 100644 --- a/aio/content/guide/quickstart.md +++ b/aio/content/guide/quickstart.md @@ -126,7 +126,7 @@ This is the _root component_ and it is named `app-root`. You can find it in `./src/app/app.component.ts`. -Open the component file and change the `title` property from _Welcome to app!!_ to _Welcome to My First Angular App!!_: +Open the component file and change the `title` property from `'app'` to `'My First Angular App!'`.