diff --git a/packages/service-worker/worker/test/happy_spec.ts b/packages/service-worker/worker/test/happy_spec.ts index 87a57c67e7..19cf19b2d8 100644 --- a/packages/service-worker/worker/test/happy_spec.ts +++ b/packages/service-worker/worker/test/happy_spec.ts @@ -483,7 +483,6 @@ const manifestUpdateHash = sha1(JSON.stringify(manifestUpdate)); async_it('shows notifications for push notifications', async() => { expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo'); await driver.initialized; - scope.clients.add('default'); await scope.handlePush({ notification: { title: 'This is a test', @@ -665,7 +664,7 @@ const manifestUpdateHash = sha1(JSON.stringify(manifestUpdate)); server.assertSawRequestFor('/baz'); }); - async_it('does not redirect to index on a request that does not expect HTML', async() => { + async_it('does not redirect to index on a request that does not accept HTML', async() => { expect(await navRequest('/baz', {headers: {}})).toBeNull(); server.assertSawRequestFor('/baz'); @@ -793,7 +792,6 @@ async function makeRequest( const [resPromise, done] = scope.handleFetch(new MockRequest(url, init), clientId); await done; const res = await resPromise; - scope.clients.add(clientId); if (res !== undefined && res.ok) { return res.text(); } diff --git a/packages/service-worker/worker/testing/scope.ts b/packages/service-worker/worker/testing/scope.ts index e280041d18..3eb800bbc4 100644 --- a/packages/service-worker/worker/testing/scope.ts +++ b/packages/service-worker/worker/testing/scope.ts @@ -62,10 +62,7 @@ export class MockClients implements Clients { remove(clientId: string): void { this.clients.delete(clientId); } - async get(id: string): Promise { - this.add(id); - return this.clients.get(id) !as any as Client; - } + async get(id: string): Promise { return this.clients.get(id) !as any as Client; } getMock(id: string): MockClient|undefined { return this.clients.get(id); } @@ -197,6 +194,10 @@ export class SwTestHarness implements ServiceWorkerGlobalScope, Adapter, Context const event = new MockFetchEvent(req, clientId || null); this.eventHandlers.get('fetch') !.call(this, event); + if (clientId) { + this.clients.add(clientId); + } + return [event.response, event.ready]; }