From d378a295654ea144b55b86e518c9cc59a7c55e77 Mon Sep 17 00:00:00 2001 From: Georgios Kalpakas Date: Tue, 13 Jun 2017 02:23:11 +0300 Subject: [PATCH] ci(aio): fail the build if the PWA score is too low Previously, there was an issue with testing the PWA score on staging and failing the build was temporarily disabled. It works now, so we need to enable failing the build is the score drops below some threshold. --- aio/scripts/deploy-to-firebase.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/aio/scripts/deploy-to-firebase.sh b/aio/scripts/deploy-to-firebase.sh index bbfa54ab01..931ea29453 100755 --- a/aio/scripts/deploy-to-firebase.sh +++ b/aio/scripts/deploy-to-firebase.sh @@ -36,6 +36,5 @@ esac firebase deploy --message "Commit: $TRAVIS_COMMIT" --non-interactive --token "$firebaseToken" # Run PWA-score tests - # TODO(gkalpak): Figure out why this fails and re-enable. - yarn test-pwa-score -- "$deployedUrl" "$MIN_PWA_SCORE" "$PWA_RESULTS_LOG" || true + yarn test-pwa-score -- "$deployedUrl" "$MIN_PWA_SCORE" "$PWA_RESULTS_LOG" )