From d4add5428b06205626c85479346a10454373f36a Mon Sep 17 00:00:00 2001 From: Kristiyan Kostadinov Date: Sun, 3 Feb 2019 13:37:20 +0100 Subject: [PATCH] test(ivy): root cause analysis for e2e tests in common (#28506) Adds root causes to the e2e test failures in `common`. This PR resolves FW-1011. PR Close #28506 --- .../ts/e2e_test/ngComponentOutlet_spec.ts | 21 +++++++++---------- .../common/ngIf/ts/e2e_test/ngIf_spec.ts | 4 ++-- 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/packages/examples/common/ngComponentOutlet/ts/e2e_test/ngComponentOutlet_spec.ts b/packages/examples/common/ngComponentOutlet/ts/e2e_test/ngComponentOutlet_spec.ts index 2c31d31d40..f04cd582b2 100644 --- a/packages/examples/common/ngComponentOutlet/ts/e2e_test/ngComponentOutlet_spec.ts +++ b/packages/examples/common/ngComponentOutlet/ts/e2e_test/ngComponentOutlet_spec.ts @@ -6,7 +6,7 @@ * found in the LICENSE file at https://angular.io/license */ -import {fixmeIvy} from '@angular/private/testing'; +import {fixmeIvy, modifiedInIvy} from '@angular/private/testing'; import {$, ExpectedConditions, browser, by, element} from 'protractor'; import {verifyNoBrowserErrors} from '../../../../test-utils'; @@ -17,9 +17,7 @@ function waitForElement(selector: string) { browser.wait(EC.presenceOf($(selector)), 20000); } -fixmeIvy( - 'unknown. Run "yarn bazel run packages/examples/common:devserver --define=compile=aot" ' + - 'to debug') +fixmeIvy('FW-1022: JitCompilerFactory creates incorrect compiler instance') .describe('ngComponentOutlet', () => { const URL = '/ngComponentOutlet'; afterEach(verifyNoBrowserErrors); @@ -31,13 +29,14 @@ fixmeIvy( expect(element.all(by.css('hello-world')).getText()).toEqual(['Hello World!']); }); - it('should render complete', () => { - browser.get(URL); - waitForElement('ng-component-outlet-complete-example'); - expect(element.all(by.css('complete-component')).getText()).toEqual([ - 'Complete: AhojSvet!' - ]); - }); + modifiedInIvy('Different behavior for projectableNodes in ViewContainerRef.createComponent') + .it('should render complete', () => { + browser.get(URL); + waitForElement('ng-component-outlet-complete-example'); + expect(element.all(by.css('complete-component')).getText()).toEqual([ + 'Complete: AhojSvet!' + ]); + }); it('should render other module', () => { browser.get(URL); diff --git a/packages/examples/common/ngIf/ts/e2e_test/ngIf_spec.ts b/packages/examples/common/ngIf/ts/e2e_test/ngIf_spec.ts index 69aa158111..833479edfa 100644 --- a/packages/examples/common/ngIf/ts/e2e_test/ngIf_spec.ts +++ b/packages/examples/common/ngIf/ts/e2e_test/ngIf_spec.ts @@ -6,7 +6,7 @@ * found in the LICENSE file at https://angular.io/license */ -import {fixmeIvy} from '@angular/private/testing'; +import {modifiedInIvy} from '@angular/private/testing'; import {$, ExpectedConditions, browser, by, element} from 'protractor'; import {verifyNoBrowserErrors} from '../../../../test-utils'; @@ -46,7 +46,7 @@ describe('ngIf', () => { describe('ng-if-then-else', () => { let comp = 'ng-if-then-else'; - fixmeIvy('unknown. Run "yarn bazel run packages/examples/common:devserver" to debug') + modifiedInIvy('FW-1019: Design new API to replace static queries') .it('should hide/show content', () => { browser.get(URL); waitForElement(comp);