honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(router): RouterLink mirrors input `target` as attribute 

Closes #13837
This commit is contained in:
Dzmitry Shylovich 2017-01-08 01:04:18 +03:00 committed by Matias Niemelä
parent fb6c4582a1
commit d9a22dae4f
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/@angular/router/src/directives/router_link.ts
View File

@ -139,7 +139,7 @@ export class RouterLink {
*/ */
@Directive({selector: 'a[routerLink]'}) @Directive({selector: 'a[routerLink]'})
export class RouterLinkWithHref implements OnChanges, OnDestroy { export class RouterLinkWithHref implements OnChanges, OnDestroy {
@Input() target: string; @HostBinding('attr.target') @Input() target: string;
@Input() queryParams: {[k: string]: any}; @Input() queryParams: {[k: string]: any};
@Input() fragment: string; @Input() fragment: string;
@Input() preserveQueryParams: boolean; @Input() preserveQueryParams: boolean;

4
modules/@angular/router/test/integration.spec.ts
View File

@ -998,6 +998,7 @@ describe('Integration', () => {
const native = fixture.nativeElement.querySelector('a'); const native = fixture.nativeElement.querySelector('a');
expect(native.getAttribute('href')).toEqual('/team/33/simple'); expect(native.getAttribute('href')).toEqual('/team/33/simple');
expect(native.getAttribute('target')).toEqual('_self');
native.click(); native.click();
advance(fixture); advance(fixture);
@ -2710,7 +2711,8 @@ function expectEvents(events: Event[], pairs: any[]) {
} }
} }
@Component({selector: 'link-cmp', template: `<a routerLink="/team/33/simple">link</a>`}) @Component(
{selector: 'link-cmp', template: `<a routerLink="/team/33/simple" [target]="'_self'">link</a>`})
class StringLinkCmp { class StringLinkCmp {
} }