honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: break out warnings vs hints in build/analyze.dart 

give a better report of errors
This commit is contained in:
Kevin Moore 2015-04-10 16:52:41 -07:00
parent 8c1adabe1c
commit dc9c614da2
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tools/build/dartanalyzer.js
View File

@ -49,6 +49,7 @@ module.exports = function(gulp, plugins, config) {
}); });
var hintCount = 0; var hintCount = 0;
var errorCount = 0; var errorCount = 0;
var warningCount = 0;
rl.on('line', function(line) { rl.on('line', function(line) {
//TODO remove once dartanalyzer handles transitive libraries //TODO remove once dartanalyzer handles transitive libraries
//skip errors in third-party packages //skip errors in third-party packages
@ -70,6 +71,8 @@ module.exports = function(gulp, plugins, config) {
} }
if (line.match(/\[hint\]/)) { if (line.match(/\[hint\]/)) {
hintCount++; hintCount++;
} else if (line.match(/\[warning\]/)) {
warningCount++;
} else { } else {
errorCount ++; errorCount ++;
} }
@ -77,11 +80,18 @@ module.exports = function(gulp, plugins, config) {
}); });
stream.on('close', function() { stream.on('close', function() {
var error; var error;
var report = [];
if (errorCount > 0) { if (errorCount > 0) {
error = new Error('Dartanalyzer showed errors'); report.push(errorCount + ' error(s)');
}
if (warningCount > 0) {
report.push(warningCount + ' warning(s)');
} }
if (hintCount > 0) { if (hintCount > 0) {
error = new Error('Dartanalyzer showed hints'); report.push(hintCount + ' hint(s)');
}
if (report.length > 0) {
error = 'Dartanalyzer showed ' + report.join(', ');
} }
done(error); done(error);
}); });