honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test(common): update common tests to use static flag (#30626) 

PR Close #30626
This commit is contained in:
Kara Erickson 2019-05-22 17:22:42 -07:00 committed by Jason Aden
parent 4299ecf9be
commit dcdecfa9a8
2 changed files with 14 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
packages/common/test/directives/ng_component_outlet_spec.ts
View File

@ -11,7 +11,6 @@ import {NgComponentOutlet} from '@angular/common/src/directives/ng_component_out
import {Compiler, Component, ComponentRef, Inject, InjectionToken, Injector, NO_ERRORS_SCHEMA, NgModule, NgModuleFactory, Optional, QueryList, TemplateRef, Type, ViewChild, ViewChildren, ViewContainerRef} from '@angular/core'; import {Compiler, Component, ComponentRef, Inject, InjectionToken, Injector, NO_ERRORS_SCHEMA, NgModule, NgModuleFactory, Optional, QueryList, TemplateRef, Type, ViewChild, ViewChildren, ViewContainerRef} from '@angular/core';
import {TestBed, async} from '@angular/core/testing'; import {TestBed, async} from '@angular/core/testing';
import {expect} from '@angular/platform-browser/testing/src/matchers'; import {expect} from '@angular/platform-browser/testing/src/matchers';
import {modifiedInIvy} from '@angular/private/testing';
describe('insert/remove', () => { describe('insert/remove', () => {
@ -108,19 +107,18 @@ describe('insert/remove', () => {
})); }));
modifiedInIvy('Static ViewChild and ContentChild queries are resolved in update mode') it('should resolve with an injector', async(() => {
.it('should resolve with an injector', async(() => { let fixture = TestBed.createComponent(TestComponent);
let fixture = TestBed.createComponent(TestComponent);
// We are accessing a ViewChild (ngComponentOutlet) before change detection has run // We are accessing a ViewChild (ngComponentOutlet) before change detection has run
fixture.componentInstance.cmpRef = null; fixture.componentInstance.cmpRef = null;
fixture.componentInstance.currentComponent = InjectedComponent; fixture.componentInstance.currentComponent = InjectedComponent;
fixture.detectChanges(); fixture.detectChanges();
let cmpRef: ComponentRef<InjectedComponent> = fixture.componentInstance.cmpRef !; let cmpRef: ComponentRef<InjectedComponent> = fixture.componentInstance.cmpRef !;
expect(cmpRef).toBeAnInstanceOf(ComponentRef); expect(cmpRef).toBeAnInstanceOf(ComponentRef);
expect(cmpRef.instance).toBeAnInstanceOf(InjectedComponent); expect(cmpRef.instance).toBeAnInstanceOf(InjectedComponent);
expect(cmpRef.instance.testToken).toBeNull(); expect(cmpRef.instance.testToken).toBeNull();
})); }));
it('should render projectable nodes, if supplied', async(() => { it('should render projectable nodes, if supplied', async(() => {
const template = `<ng-template>projected foo</ng-template>${TEST_CMP_TEMPLATE}`; const template = `<ng-template>projected foo</ng-template>${TEST_CMP_TEMPLATE}`;
@ -240,7 +238,7 @@ class TestComponent {
// TODO(issue/24571): remove '!'. // TODO(issue/24571): remove '!'.
@ViewChildren(TemplateRef) tplRefs !: QueryList<TemplateRef<any>>; @ViewChildren(TemplateRef) tplRefs !: QueryList<TemplateRef<any>>;
// TODO(issue/24571): remove '!'. // TODO(issue/24571): remove '!'.
@ViewChild(NgComponentOutlet) ngComponentOutlet !: NgComponentOutlet; @ViewChild(NgComponentOutlet, {static: true}) ngComponentOutlet !: NgComponentOutlet;
constructor(public vcRef: ViewContainerRef) {} constructor(public vcRef: ViewContainerRef) {}
} }

4
packages/common/test/directives/ng_switch_spec.ts
View File

@ -223,8 +223,8 @@ class TestComponent {
` `
}) })
class ComplexComponent { class ComplexComponent {
@ViewChild('foo') foo !: TemplateRef<any>; @ViewChild('foo', {static: true}) foo !: TemplateRef<any>;
@ViewChild('bar') bar !: TemplateRef<any>; @ViewChild('bar', {static: true}) bar !: TemplateRef<any>;
state: string = 'case1'; state: string = 'case1';
} }