honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build: unable to accept new symbol-extractor golden on windows (#30127)

Browse Source 
Currently when working on Windows, it's not possible to accept a new
golden for a `symbol-extractor` Bazel test. This is because the generated
executable output from the `nodejs_binary` rule (without a macro) misses
a Windows executable wrapper that sets up the proper environment
variables for the runfiles. Causing the following failure on Windows:

```
 >>>> FAIL: RUNFILES environment variable is not set. <<<<
```

PR Close #30127
This commit is contained in:
Paul Gschwendtner 2019-04-25 20:41:05 +02:00 committed by Andrew Kushnir
parent 124e49752f
commit dd59b1d371
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/symbol-extractor/cli.ts
View File

@ -43,7 +43,7 @@ function main(argv: [string, string, string] | [string, string]): boolean {
const defineFlag = (compile !== 'legacy') ? `--define=compile=${compile} ` : ''; const defineFlag = (compile !== 'legacy') ? `--define=compile=${compile} ` : '';
console.error(`TEST FAILED!`); console.error(`TEST FAILED!`);
console.error(` To update the golden file run: `); console.error(` To update the golden file run: `);
console.error(` yarn bazel run ${defineFlag}${process.env['BAZEL_TARGET']}.accept`); console.error(` yarn bazel run ${defineFlag}${process.env['TEST_TARGET']}.accept`);
} }
} }
return passed; return passed;

10
tools/symbol-extractor/index.bzl
View File

@ -3,12 +3,11 @@
# Use of this source code is governed by an MIT-style license that can be # Use of this source code is governed by an MIT-style license that can be
# found in the LICENSE file at https://angular.io/license # found in the LICENSE file at https://angular.io/license
"""This test verifies that a set of top level symbols from a javascript file match a gold file. load("@build_bazel_rules_nodejs//:defs.bzl", "nodejs_binary", "nodejs_test")
"""
# This does a deep import under //internal because of not wanting the wrapper macro """
# because it introduces an extra target_bin target. This test verifies that a set of top level symbols from a javascript file match a gold file.
load("@build_bazel_rules_nodejs//internal/node:node.bzl", "nodejs_binary", "nodejs_test") """
def js_expected_symbol_test(name, src, golden, data = [], **kwargs): def js_expected_symbol_test(name, src, golden, data = [], **kwargs):
"""This test verifies that a set of top level symbols from a javascript file match a gold file. """This test verifies that a set of top level symbols from a javascript file match a gold file.
@ -17,7 +16,6 @@ def js_expected_symbol_test(name, src, golden, data = [], **kwargs):
src, src,
golden, golden,
Label("//tools/symbol-extractor:lib"), Label("//tools/symbol-extractor:lib"),
Label("@bazel_tools//tools/bash/runfiles"),
Label("@npm//typescript"), Label("@npm//typescript"),
] ]
entry_point = "angular/tools/symbol-extractor/cli.js" entry_point = "angular/tools/symbol-extractor/cli.js"