honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(bazel): use getattr instead of hasattr in ng_module.bzl (#33765) 

getattr improves code readability and makes the code also shorter.

PR Close #33765
This commit is contained in:
Igor Minar 2019-11-19 22:57:53 -08:00 committed by Matias Niemelä
parent 955423c79b
commit de043a4bcb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/bazel/src/ng_module.bzl
View File

@ -129,7 +129,7 @@ def _flat_module_out_file(ctx):
Returns: Returns:
a basename used for the flat module out (no extension) a basename used for the flat module out (no extension)
""" """
if hasattr(ctx.attr, "flat_module_out_file") and ctx.attr.flat_module_out_file: if getattr(ctx.attr, "flat_module_out_file", False):
return ctx.attr.flat_module_out_file return ctx.attr.flat_module_out_file
return "%s_public_index" % ctx.label.name return "%s_public_index" % ctx.label.name
@ -149,7 +149,7 @@ def _should_produce_dts_bundle(ctx):
# At the moment we cannot use this with ngtsc compiler since it emits # At the moment we cannot use this with ngtsc compiler since it emits
# import * as ___ from local modules which is not supported # import * as ___ from local modules which is not supported
# see: https://github.com/Microsoft/web-build-tools/issues/1029 # see: https://github.com/Microsoft/web-build-tools/issues/1029
return _is_view_engine_enabled(ctx) and hasattr(ctx.attr, "bundle_dts") and ctx.attr.bundle_dts return _is_view_engine_enabled(ctx) and getattr(ctx.attr, "bundle_dts", False)
def _should_produce_r3_symbols_bundle(ctx): def _should_produce_r3_symbols_bundle(ctx):
"""Should we produce r3_symbols bundle. """Should we produce r3_symbols bundle.