From dffcb9cda3599d0ab113f2fd7cf1225086a1c1d1 Mon Sep 17 00:00:00 2001 From: Kara Erickson Date: Wed, 9 Jan 2019 20:53:56 -0800 Subject: [PATCH] ci: onlyInIvy tests should not be triggered for FIND_PASSING_TESTS mode (#28036) Previous to this change, there was a lot of noise when trying to find tests in FIND_PASSING_TESTS mode because tests marked "onlyInIvy" were also listed as "already passing". Since these tests are not "fixmes" that need to be enabled, it is not useful to have them listed. This commit removes "onlyInIvy" tests from consideration when running in this manual mode. The tests should still run on CI by default (since FIND_PASSING_TESTS mode will be false). PR Close #28036 --- packages/private/testing/src/ivy_test_selectors.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/private/testing/src/ivy_test_selectors.ts b/packages/private/testing/src/ivy_test_selectors.ts index 9111b61b45..38b0ceb47e 100644 --- a/packages/private/testing/src/ivy_test_selectors.ts +++ b/packages/private/testing/src/ivy_test_selectors.ts @@ -94,7 +94,7 @@ export function obsoleteInIvy(reason: string): JasmineMethods { * ``` */ export function onlyInIvy(reason: string): JasmineMethods { - return ivyEnabled ? PASSTHROUGH : IGNORE; + return ivyEnabled && !FIND_PASSING_TESTS ? PASSTHROUGH : IGNORE; } /**