honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci: enable compliance tests on Windows (#41556) 

Now that we have updated the Bazel node.js rules we can run all the
compliance tests in Windows on CI.

PR Close #41556
This commit is contained in:
Pete Bacon Darwin 2021-04-10 17:30:33 +01:00 committed by Zach Arend
parent 05cc3c8ee2
commit e16d234709
2 changed files with 16 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
.circleci/config.yml
View File

@ -463,7 +463,7 @@ jobs:
aio_preview: aio_preview:
executor: default-executor executor: default-executor
environment: environment:
AIO_SNAPSHOT_ARTIFACT_PATH: &aio_preview_artifact_path 'aio/tmp/snapshot.tgz' AIO_SNAPSHOT_ARTIFACT_PATH: &aio_preview_artifact_path "aio/tmp/snapshot.tgz"
steps: steps:
- custom_attach_workspace - custom_attach_workspace
- init_environment - init_environment
@ -487,7 +487,6 @@ jobs:
name: Wait for preview and run tests name: Wait for preview and run tests
command: node aio/scripts/test-preview.js $CI_PULL_REQUEST $CI_COMMIT $CI_AIO_MIN_PWA_SCORE command: node aio/scripts/test-preview.js $CI_PULL_REQUEST $CI_COMMIT $CI_AIO_MIN_PWA_SCORE
# The `build-npm-packages` tasks exist for backwards-compatibility with old scripts and # The `build-npm-packages` tasks exist for backwards-compatibility with old scripts and
# tests that rely on the pre-Bazel `dist/packages-dist` output structure (build.sh). # tests that rely on the pre-Bazel `dist/packages-dist` output structure (build.sh).
# Having multiple jobs that independently build in this manner duplicates some work; we build # Having multiple jobs that independently build in this manner duplicates some work; we build
@ -547,12 +546,12 @@ jobs:
publish_packages_as_artifacts: publish_packages_as_artifacts:
executor: default-executor executor: default-executor
environment: environment:
AIMWA_PACKAGES_DIR: &aimwa_packages_dir 'dist/angular-in-memory-web-api-dist' AIMWA_PACKAGES_DIR: &aimwa_packages_dir "dist/angular-in-memory-web-api-dist"
AIMWA_PACKAGES_ARCHIVES_DIR: &aimwa_packages_archives_dir 'dist/angular-in-memory-web-api-dist-archives' AIMWA_PACKAGES_ARCHIVES_DIR: &aimwa_packages_archives_dir "dist/angular-in-memory-web-api-dist-archives"
NG_PACKAGES_DIR: &ng_packages_dir 'dist/packages-dist' NG_PACKAGES_DIR: &ng_packages_dir "dist/packages-dist"
NG_PACKAGES_ARCHIVES_DIR: &ng_packages_archives_dir 'dist/packages-dist-archives' NG_PACKAGES_ARCHIVES_DIR: &ng_packages_archives_dir "dist/packages-dist-archives"
ZONEJS_PACKAGES_DIR: &zonejs_packages_dir 'dist/zone.js-dist' ZONEJS_PACKAGES_DIR: &zonejs_packages_dir "dist/zone.js-dist"
ZONEJS_PACKAGES_ARCHIVES_DIR: &zonejs_packages_archives_dir 'dist/zone.js-dist-archives' ZONEJS_PACKAGES_ARCHIVES_DIR: &zonejs_packages_archives_dir "dist/zone.js-dist-archives"
steps: steps:
- custom_attach_workspace - custom_attach_workspace
- init_environment - init_environment
@ -774,11 +773,11 @@ jobs:
- setup_win - setup_win
- run: - run:
name: Build all windows CI targets name: Build all windows CI targets
command: yarn bazel build --build_tag_filters=-ivy-only,-no-windows //packages/compiler-cli/... //tools/ts-api-guardian/... command: yarn bazel build --build_tag_filters=-ivy-only //packages/compiler-cli/... //tools/ts-api-guardian/...
no_output_timeout: 15m no_output_timeout: 15m
- run: - run:
name: Test all windows CI targets name: Test all windows CI targets
command: yarn bazel test --build_tag_filters=-no-windows --test_tag_filters="-ivy-only,-no-windows,-browser:chromium-local" //packages/compiler-cli/... //tools/ts-api-guardian/... command: yarn bazel test --test_tag_filters="-ivy-only,-browser:chromium-local" //packages/compiler-cli/... //tools/ts-api-guardian/...
no_output_timeout: 15m no_output_timeout: 15m
test_ivy_aot_win: test_ivy_aot_win:
@ -787,11 +786,11 @@ jobs:
- setup_win - setup_win
- run: - run:
name: Build all windows CI targets name: Build all windows CI targets
command: yarn bazel build --config=ivy --build_tag_filters=-no-ivy-aot,-no-windows,-fixme-ivy-aot //packages/compiler-cli/... //tools/ts-api-guardian/... command: yarn bazel build --config=ivy --build_tag_filters=-no-ivy-aot,-fixme-ivy-aot //packages/compiler-cli/... //tools/ts-api-guardian/...
no_output_timeout: 15m no_output_timeout: 15m
- run: - run:
name: Test all windows CI targets name: Test all windows CI targets
command: yarn bazel test --config=ivy --build_tag_filters=-no-windows --test_tag_filters="-no-ivy-aot,-no-windows,-fixme-ivy-aot,-browser:chromium-local" //packages/compiler-cli/... //tools/ts-api-guardian/... //packages/localize/... command: yarn bazel test --config=ivy --test_tag_filters="-no-ivy-aot,-fixme-ivy-aot,-browser:chromium-local" //packages/compiler-cli/... //tools/ts-api-guardian/... //packages/localize/...
no_output_timeout: 15m no_output_timeout: 15m
# Save dependencies to use on subsequent runs. # Save dependencies to use on subsequent runs.
- save_cache: - save_cache:
@ -799,7 +798,6 @@ jobs:
paths: paths:
- ~/.cache/yarn - ~/.cache/yarn
workflows: workflows:
version: 2 version: 2
default_workflow: default_workflow:

6
packages/compiler-cli/test/compliance/partial/partial_compliance_goldens.bzl
View File

@ -48,10 +48,6 @@ def partial_compliance_golden(filePath):
testonly = True, testonly = True,
stdout = "%s/this_file_should_not_be_committed" % path, stdout = "%s/this_file_should_not_be_committed" % path,
link_workspace_root = True, link_workspace_root = True,
tags = [
# TODO(josephperrott): Begin running these tests on windows after updating to rules_nodejs 3.0
"no-windows",
],
visibility = [":__pkg__"], visibility = [":__pkg__"],
data = data, data = data,
) )
@ -60,8 +56,6 @@ def partial_compliance_golden(filePath):
visibility = ["//visibility:public"], visibility = ["//visibility:public"],
tags = [ tags = [
"ivy-only", "ivy-only",
# TODO(josephperrott): Begin running these tests on windows after updating to rules_nodejs 3.0
"no-windows",
], ],
name = "%s.golden" % path, name = "%s.golden" % path,
src = "//packages/compiler-cli/test/compliance/test_cases:%s/GOLDEN_PARTIAL.js" % path, src = "//packages/compiler-cli/test/compliance/test_cases:%s/GOLDEN_PARTIAL.js" % path,