Revert "refactor: use new Http library in playground (#29355)"

This reverts commit acfcf90528de431575fba336df0e06c1ebc6c734.
This commit is contained in:
Alex Eagle 2019-04-26 16:49:50 -07:00
parent 3cf318b498
commit e5c3695dbd
7 changed files with 20 additions and 30 deletions

View File

@ -10,8 +10,8 @@ ng_module(
# TODO: FW-1004 Type checking is currently not complete. # TODO: FW-1004 Type checking is currently not complete.
type_check = False, type_check = False,
deps = [ deps = [
"//packages/common/http",
"//packages/core", "//packages/core",
"//packages/http",
"//packages/platform-browser", "//packages/platform-browser",
"//packages/platform-browser-dynamic", "//packages/platform-browser-dynamic",
"@npm//rxjs", "@npm//rxjs",

View File

@ -6,12 +6,9 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import {HttpClient} from '@angular/common/http';
import {Component} from '@angular/core'; import {Component} from '@angular/core';
import {Http, Response} from '@angular/http';
interface Person { import {map} from 'rxjs/operators';
name: string;
}
@Component({ @Component({
selector: 'http-app', selector: 'http-app',
@ -19,14 +16,16 @@ interface Person {
<h1>people</h1> <h1>people</h1>
<ul class="people"> <ul class="people">
<li *ngFor="let person of people"> <li *ngFor="let person of people">
hello, {{person.name}} hello, {{person['name']}}
</li> </li>
</ul> </ul>
` `
}) })
export class HttpCmp { export class HttpCmp {
people: Person[]; people: Object[];
constructor(http: HttpClient) { constructor(http: Http) {
http.get('./people.json').subscribe((people: Person[]) => this.people = people); http.get('./people.json')
.pipe(map((res: Response) => res.json()))
.subscribe((people: Array<Object>) => this.people = people);
} }
} }

View File

@ -6,15 +6,14 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import {HttpClientModule} from '@angular/common/http';
import {NgModule} from '@angular/core'; import {NgModule} from '@angular/core';
import {HttpModule} from '@angular/http';
import {BrowserModule} from '@angular/platform-browser'; import {BrowserModule} from '@angular/platform-browser';
import {platformBrowserDynamic} from '@angular/platform-browser-dynamic'; import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
import {HttpCmp} from './app/http_comp'; import {HttpCmp} from './app/http_comp';
@NgModule( @NgModule({declarations: [HttpCmp], bootstrap: [HttpCmp], imports: [BrowserModule, HttpModule]})
{declarations: [HttpCmp], bootstrap: [HttpCmp], imports: [BrowserModule, HttpClientModule]})
export class ExampleModule { export class ExampleModule {
} }

View File

@ -10,8 +10,8 @@ ng_module(
# TODO: FW-1004 Type checking is currently not complete. # TODO: FW-1004 Type checking is currently not complete.
type_check = False, type_check = False,
deps = [ deps = [
"//packages/common/http",
"//packages/core", "//packages/core",
"//packages/http",
"//packages/platform-browser", "//packages/platform-browser",
"//packages/platform-browser-dynamic", "//packages/platform-browser-dynamic",
], ],

View File

@ -6,12 +6,8 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import {HttpClient} from '@angular/common/http';
import {Component} from '@angular/core'; import {Component} from '@angular/core';
import {Jsonp} from '@angular/http';
interface Person {
name: string;
}
@Component({ @Component({
selector: 'jsonp-app', selector: 'jsonp-app',
@ -19,14 +15,14 @@ interface Person {
<h1>people</h1> <h1>people</h1>
<ul class="people"> <ul class="people">
<li *ngFor="let person of people"> <li *ngFor="let person of people">
hello, {{person.name}} hello, {{person['name']}}
</li> </li>
</ul> </ul>
` `
}) })
export class JsonpCmp { export class JsonpCmp {
people: Person[]; people: Object;
constructor(http: HttpClient) { constructor(jsonp: Jsonp) {
http.jsonp('./people.json', 'callback').subscribe(res => this.people = res); jsonp.get('./people.json?callback=JSONP_CALLBACK').subscribe(res => this.people = res.json());
} }
} }

View File

@ -6,18 +6,14 @@
* found in the LICENSE file at https://angular.io/license * found in the LICENSE file at https://angular.io/license
*/ */
import {HttpClientJsonpModule, HttpClientModule} from '@angular/common/http';
import {NgModule} from '@angular/core'; import {NgModule} from '@angular/core';
import {JsonpModule} from '@angular/http';
import {BrowserModule} from '@angular/platform-browser'; import {BrowserModule} from '@angular/platform-browser';
import {platformBrowserDynamic} from '@angular/platform-browser-dynamic'; import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
import {JsonpCmp} from './app/jsonp_comp'; import {JsonpCmp} from './app/jsonp_comp';
@NgModule({ @NgModule({bootstrap: [JsonpCmp], declarations: [JsonpCmp], imports: [BrowserModule, JsonpModule]})
bootstrap: [JsonpCmp],
declarations: [JsonpCmp],
imports: [BrowserModule, HttpClientModule, HttpClientJsonpModule]
})
export class ExampleModule { export class ExampleModule {
} }

View File

@ -1,2 +1,2 @@
// This can only be requested once due to constant method name :( // This can only be requested once due to constant method name :(
ng_jsonp_callback_0([{"name":"caitp"}]) __ng_jsonp__.__req0.finished([{"name":"caitp"}])