From 3b5d85c524fccfe4b1b71bf8b3a614ea8c9965c0 Mon Sep 17 00:00:00 2001 From: rexebin Date: Sun, 27 Nov 2016 11:00:11 +0000 Subject: [PATCH 1/2] fix pure english bugs. --- public/translate/cn/translate.js | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/public/translate/cn/translate.js b/public/translate/cn/translate.js index 5ef6978e0f..d5024641d1 100644 --- a/public/translate/cn/translate.js +++ b/public/translate/cn/translate.js @@ -92,17 +92,20 @@ var sourceVisible = localStorage.getItem('source-visible') === 'true'; if (sibling.children) { processContainer(sibling); } - $current.addClass('original-english'); - $sibling.addClass('translated'); - $sibling.addClass('translated-cn'); - $sibling.after($current); - $sibling.on('click', function (event) { - // for nested structure. - event.stopPropagation(); - $current.toggleClass('hidden'); - }); - // addSpacingBetweenCnAndEn(sibling); - return true; + if(!isPureEnglish(sibling.textContent)){ + $current.addClass('original-english'); + $sibling.addClass('translated'); + $sibling.addClass('translated-cn'); + $sibling.after($current); + $sibling.on('click', function (event) { + // for nested structure. + event.stopPropagation(); + $current.toggleClass('hidden'); + }); + // addSpacingBetweenCnAndEn(sibling); + return true; + } + } } } From 9e92f38e7eab4c14248ffc220ce27df4c5c06635 Mon Sep 17 00:00:00 2001 From: rexebin Date: Sun, 27 Nov 2016 11:39:31 +0000 Subject: [PATCH 2/2] fix: 1. not yet translated articles 2. pure english in th and td. --- public/translate/cn/translate.js | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/public/translate/cn/translate.js b/public/translate/cn/translate.js index d5024641d1..882ddf12df 100644 --- a/public/translate/cn/translate.js +++ b/public/translate/cn/translate.js @@ -4,7 +4,7 @@ var sourceVisible = localStorage.getItem('source-visible') === 'true'; var content = document.querySelector('article'); var footer = document.querySelector('.main-footer'); - processContainer(content); + processContainer(content, true); processContainer(footer); if (!sourceVisible) { @@ -24,8 +24,8 @@ var sourceVisible = localStorage.getItem('source-visible') === 'true'; * Process container recursively. * @param container */ - function processContainer(container) { - if (!container) { + function processContainer(container, isContent) { + if (!container || (isContent && isPureEnglish(container.textContent))) { return; } var count = 0; @@ -58,7 +58,7 @@ var sourceVisible = localStorage.getItem('source-visible') === 'true'; case 'UL': case 'OL': case 'DIV': - processContainer(node); + processContainer(node, ['TD','TH'].indexOf(node.tagName)!== -1); break; default: if (processContainer(node) <= 1) { @@ -91,8 +91,7 @@ var sourceVisible = localStorage.getItem('source-visible') === 'true'; if (isPureEnglish(current.textContent)) { if (sibling.children) { processContainer(sibling); - } - if(!isPureEnglish(sibling.textContent)){ + } $current.addClass('original-english'); $sibling.addClass('translated'); $sibling.addClass('translated-cn'); @@ -104,7 +103,7 @@ var sourceVisible = localStorage.getItem('source-visible') === 'true'; }); // addSpacingBetweenCnAndEn(sibling); return true; - } + } }