ci: remove IgorMinar from reviewers list for pullapprove fallback group (#36456)
Historically we have had a pullapprove group `fallback` which acted as a catch all for files which did not match any other groups. This group assigned reviews to IgorMinar, however it was not apparent that this group was assigned. This change removes this assignment. This group as active should always coincide with failures of the pullapprove verification script. We continue to have this group as a secondary test ensuring all files in the repo are captured by the pullapprove config. PR Close #36456
This commit is contained in:
parent
3a116179b1
commit
ed3c549063
|
@ -1126,12 +1126,32 @@ groups:
|
||||||
# Catch all for if no groups match the code change
|
# Catch all for if no groups match the code change
|
||||||
# ====================================================
|
# ====================================================
|
||||||
fallback:
|
fallback:
|
||||||
|
# A group is considered to be `active` for a PR if at least one of group's
|
||||||
|
# conditions matches the PR.
|
||||||
|
#
|
||||||
|
# The PullApprove CI check should fail if a PR has no `active` groups, as
|
||||||
|
# this indicates the PR is modifying a file that has no owner.
|
||||||
|
#
|
||||||
|
# This is enforced through the pullapprove verification check done
|
||||||
|
# as part of the CircleCI lint job. Failures in this lint job should be
|
||||||
|
# fixed as part of the PR. This can be done by updating the
|
||||||
|
# `.pullapprove.yml` file cover the unmatched path.
|
||||||
|
# The pullapprove verification script is part of the ng-dev tool and can be
|
||||||
|
# run locally with the command: `yarn -s ng-dev pullapprove verify`
|
||||||
|
#
|
||||||
|
# For cases in which the verification check fails to ensure coverage, this
|
||||||
|
# group will be active. The expectation is that this should be remedied
|
||||||
|
# before merging the PR as described above. In an emergency situation
|
||||||
|
# `global-approvers` can still approve PRs that match this `fallback` rule,
|
||||||
|
# but that should be an exception and not an expectation.
|
||||||
conditions:
|
conditions:
|
||||||
- *can-be-global-approved
|
- *can-be-global-approved
|
||||||
# Groups which are found to have matching conditions are `active`
|
# The following groups have no conditions and will be `active` on all PRs
|
||||||
# according to PullApprove. If no groups are matched and considered
|
# - `global-approvers`
|
||||||
# active, we still want to have a review occur.
|
# - `global-docs-approvers`
|
||||||
- len(groups.active) == 0
|
#
|
||||||
reviewers:
|
# Since this means the minimum number of active groups a PR can have is 2, this
|
||||||
users:
|
# `fallback` group should be matched anytime the number of active groups is at or
|
||||||
- IgorMinar
|
# below this minimum. This work as a protection to ensure that pullapprove does
|
||||||
|
# not incidently mark a PR as passing without meeting the review criteria.
|
||||||
|
- len(groups.active) <= 2
|
||||||
|
|
|
@ -9,7 +9,7 @@ import {parse as parseYaml} from 'yaml';
|
||||||
|
|
||||||
export interface PullApproveGroupConfig {
|
export interface PullApproveGroupConfig {
|
||||||
conditions?: string[];
|
conditions?: string[];
|
||||||
reviewers: {
|
reviewers?: {
|
||||||
users: string[],
|
users: string[],
|
||||||
teams?: string[],
|
teams?: string[],
|
||||||
}|{
|
}|{
|
||||||
|
|
Loading…
Reference in New Issue