diff --git a/.circleci/config.yml b/.circleci/config.yml index 1b6e51fb0b..f6dcc84bec 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -474,7 +474,7 @@ jobs: aio_preview: executor: default-executor environment: - AIO_SNAPSHOT_ARTIFACT_PATH: &aio_preview_artifact_path "aio/tmp/snapshot.tgz" + AIO_SNAPSHOT_ARTIFACT_PATH: &aio_preview_artifact_path 'aio/tmp/snapshot.tgz' steps: - custom_attach_workspace - init_environment @@ -557,12 +557,12 @@ jobs: publish_packages_as_artifacts: executor: default-executor environment: - AIMWA_PACKAGES_DIR: &aimwa_packages_dir "dist/angular-in-memory-web-api-dist" - AIMWA_PACKAGES_ARCHIVES_DIR: &aimwa_packages_archives_dir "dist/angular-in-memory-web-api-dist-archives" - NG_PACKAGES_DIR: &ng_packages_dir "dist/packages-dist" - NG_PACKAGES_ARCHIVES_DIR: &ng_packages_archives_dir "dist/packages-dist-archives" - ZONEJS_PACKAGES_DIR: &zonejs_packages_dir "dist/zone.js-dist" - ZONEJS_PACKAGES_ARCHIVES_DIR: &zonejs_packages_archives_dir "dist/zone.js-dist-archives" + AIMWA_PACKAGES_DIR: &aimwa_packages_dir 'dist/angular-in-memory-web-api-dist' + AIMWA_PACKAGES_ARCHIVES_DIR: &aimwa_packages_archives_dir 'dist/angular-in-memory-web-api-dist-archives' + NG_PACKAGES_DIR: &ng_packages_dir 'dist/packages-dist' + NG_PACKAGES_ARCHIVES_DIR: &ng_packages_archives_dir 'dist/packages-dist-archives' + ZONEJS_PACKAGES_DIR: &zonejs_packages_dir 'dist/zone.js-dist' + ZONEJS_PACKAGES_ARCHIVES_DIR: &zonejs_packages_archives_dir 'dist/zone.js-dist-archives' steps: - custom_attach_workspace - init_environment @@ -713,7 +713,7 @@ jobs: # repository to be able to support arbitrary SHAs. - *components_repo_unit_tests_cache_key_fallback - run: - name: "Fetching angular/components repository" + name: 'Fetching angular/components repository' command: ./scripts/ci/clone_angular_components_repo.sh - run: # Run yarn install to fetch the Bazel binaries as used in the components repo. @@ -725,7 +725,7 @@ jobs: # Temporary directory must be kept in sync with the `$COMPONENTS_REPO_TMP_DIR` env # variable. It needs to be hardcoded here, because env variables interpolation is # not supported. - - "/tmp/angular-components-repo" + - '/tmp/angular-components-repo' - run: # Updates the `angular/components` `package.json` file to refer to the release output # inside the `packages-dist` directory. @@ -737,7 +737,7 @@ jobs: name: Installing local Angular packages. command: yarn --cwd ${COMPONENTS_REPO_TMP_DIR} install --non-interactive --cache-folder ~/.cache/yarn - run: - name: "Running `angular/components` unit tests" + name: 'Running `angular/components` unit tests' command: ./scripts/ci/run_angular_components_unit_tests.sh test_zonejs: @@ -907,4 +907,4 @@ workflows: - schedule: <<: *only_on_master # Runs monitoring jobs at 10:00AM every day. - cron: "0 10 * * *" + cron: '0 10 * * *' diff --git a/.github/angular-robot.yml b/.github/angular-robot.yml index 54c8499e0f..04c72688c1 100644 --- a/.github/angular-robot.yml +++ b/.github/angular-robot.yml @@ -4,7 +4,7 @@ size: disabled: false maxSizeIncrease: 2000 - circleCiStatusName: "ci/circleci: test_ivy_aot" + circleCiStatusName: 'ci/circleci: test_ivy_aot' # options for the merge plugin merge: @@ -13,85 +13,84 @@ merge: # set to true to disable disabled: false # the name of the status - context: "ci/angular: merge status" + context: 'ci/angular: merge status' # text to show when all checks pass - successText: "All checks passed!" + successText: 'All checks passed!' # text to show when some checks are failing - failureText: "The following checks are failing:" + failureText: 'The following checks are failing:' # the g3 status will be added to your pull requests if they include files that match the patterns g3Status: # set to true to disable disabled: false # the name of the status - context: "google3" + context: 'google3' # text to show when the status is pending, {{PRNumber}} will be replaced by the PR number - pendingDesc: "Googler: run g3sync presubmit {{PRNumber}}" + pendingDesc: 'Googler: run g3sync presubmit {{PRNumber}}' # text to show when the status is success - successDesc: "Does not affect google3" + successDesc: 'Does not affect google3' # link to use for the details - url: "http://go/angular/g3sync" + url: 'http://go/angular/g3sync' # list of patterns to check for the files changed by the PR # this list must be manually kept in sync with google3/third_party/javascript/angular2/copy.bara.sky include: - - "LICENSE" - - "modules/benchmarks/**" - - "modules/system.d.ts" - - "packages/**" - - "dev-infra/benchmark/driver-utilities/**" + - 'LICENSE' + - 'modules/benchmarks/**' + - 'modules/system.d.ts' + - 'packages/**' + - 'dev-infra/benchmark/driver-utilities/**' # list of patterns to ignore for the files changed by the PR exclude: - - "packages/*" - - "packages/bazel/*" - - "packages/bazel/src/api-extractor/**" - - "packages/bazel/src/builders/**" - - "packages/bazel/src/ng_package/**" - - "packages/bazel/src/protractor/**" - - "packages/bazel/src/schematics/**" - - "packages/compiler-cli/src/ngcc/**" - - "packages/compiler-cli/linker/**" - - "packages/compiler-cli/ngcc/**" - - "packages/compiler-cli/src/ngtsc/sourcemaps/**" - - "packages/docs/**" - - "packages/elements/schematics/**" - - "packages/examples/**" - - "packages/language-service/**" - - "packages/localize/**" - - "packages/private/**" - - "packages/service-worker/**" - - "packages/common/locales/**" - - "packages/http/**" - - "**/.gitignore" - - "**/.gitkeep" - - "**/yarn.lock" - - "**/package.json" - - "**/third_party/**" - - "**/tsconfig-build.json" - - "**/tsconfig.json" - - "**/rollup.config.js" - - "**/BUILD.bazel" - - "**/*.md" - - "packages/**/integrationtest/**" - - "packages/**/test/**" - - "packages/zone.js/*" - - "packages/zone.js/dist/**" - - "packages/zone.js/doc/**" - - "packages/zone.js/example/**" - - "packages/zone.js/scripts/**" + - 'packages/*' + - 'packages/bazel/*' + - 'packages/bazel/src/api-extractor/**' + - 'packages/bazel/src/builders/**' + - 'packages/bazel/src/ng_package/**' + - 'packages/bazel/src/protractor/**' + - 'packages/bazel/src/schematics/**' + - 'packages/compiler-cli/src/ngcc/**' + - 'packages/compiler-cli/linker/**' + - 'packages/compiler-cli/ngcc/**' + - 'packages/compiler-cli/src/ngtsc/sourcemaps/**' + - 'packages/docs/**' + - 'packages/elements/schematics/**' + - 'packages/examples/**' + - 'packages/language-service/**' + - 'packages/localize/**' + - 'packages/private/**' + - 'packages/service-worker/**' + - 'packages/common/locales/**' + - 'packages/http/**' + - '**/.gitignore' + - '**/.gitkeep' + - '**/yarn.lock' + - '**/package.json' + - '**/third_party/**' + - '**/tsconfig-build.json' + - '**/tsconfig.json' + - '**/rollup.config.js' + - '**/BUILD.bazel' + - '**/*.md' + - 'packages/**/integrationtest/**' + - 'packages/**/test/**' + - 'packages/zone.js/*' + - 'packages/zone.js/dist/**' + - 'packages/zone.js/doc/**' + - 'packages/zone.js/example/**' + - 'packages/zone.js/scripts/**' # comment that will be added to a PR when there is a conflict, leave empty or set to false to disable mergeConflictComment: "Hi @{{PRAuthor}}! This PR has merge conflicts due to recent upstream merges.\nPlease help to unblock it by resolving these conflicts. Thanks!" # label to monitor - mergeLabel: "action: merge" + mergeLabel: 'action: merge' # adding any of these labels will also add the merge label mergeLinkedLabels: - - "action: merge-assistance" + - 'action: merge-assistance' # list of checks that will determine if the merge label can be added checks: - # require that the PR has reviews from all requested reviewers # # This enables us to request reviews from both eng and tech writers, or multiple eng folks, and prevents accidental merges. @@ -102,26 +101,25 @@ merge: noConflict: true # list of labels that a PR needs to have, checked with a regexp (e.g. "target:" will work for the label "target: master") requiredLabels: - - "target: *" - - "cla: yes" + - 'target: *' + - 'cla: yes' # list of labels that a PR shouldn't have, checked after the required labels with a regexp forbiddenLabels: - - "target: TBD" - - "action: cleanup" - - "action: review" - - "state: blocked" - - "cla: no" + - 'target: TBD' + - 'action: cleanup' + - 'action: review' + - 'state: blocked' + - 'cla: no' # list of PR statuses that need to be successful requiredStatuses: - - "ci/circleci: build" - - "ci/circleci: lint" - - "ci/angular: size" - - "cla/google" - - "google3" - - "pullapprove" - + - 'ci/circleci: build' + - 'ci/circleci: lint' + - 'ci/angular: size' + - 'cla/google' + - 'google3' + - 'pullapprove' # the comment that will be added when the merge label is added despite failing checks, leave empty or set to false to disable # {{MERGE_LABEL}} will be replaced by the value of the mergeLabel option @@ -136,40 +134,29 @@ triage: defaultMilestone: 82, # arrays of labels that determine if an issue has been triaged by the caretaker l1TriageLabels: - - - - "comp: *" + - - 'comp: *' # arrays of labels that determine if an issue has been fully triaged l2TriageLabels: - - - - "P0" - - "comp: *" - - - - "P1" - - "comp: *" - - - - "P2" - - "comp: *" - - - - "P3" - - "comp: *" - - - - "P4" - - "comp: *" - - - - "P5" - - "comp: *" - - - - "feature" - - "comp: *" - - - - "discussion" - - "comp: *" - - - - "needs clarification" - - "comp: *" - - - - "needs reproduction" - - "comp: *" + - - 'P0' + - 'comp: *' + - - 'P1' + - 'comp: *' + - - 'P2' + - 'comp: *' + - - 'P3' + - 'comp: *' + - - 'P4' + - 'comp: *' + - - 'P5' + - 'comp: *' + - - 'feature' + - 'comp: *' + - - 'discussion' + - 'comp: *' + - - 'needs clarification' + - 'comp: *' + - - 'needs reproduction' + - 'comp: *' # options for the triage PR plugin triagePR: @@ -181,16 +168,14 @@ triagePR: defaultMilestone: 82, # arrays of labels that determine if a PR has been triaged by the caretaker l1TriageLabels: - - - - "comp: *" + - - 'comp: *' # arrays of labels that determine if a PR has been fully triaged l2TriageLabels: - - - - "comp: *" + - - 'comp: *' # options for rerunning CI rerunCircleCI: # set to true to disable disabled: false # the label which when added triggers a rerun of the default CircleCI workflow - triggerRerunLabel: "action: rerun CI at HEAD" + triggerRerunLabel: 'action: rerun CI at HEAD' diff --git a/.pullapprove.yml b/.pullapprove.yml index f86f3f6279..b5407c0195 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -37,7 +37,6 @@ # See reviewer list under `required-minimum-review` group. Team member names and # usernames are managed there. - #################################################################################### # Approval Groups #################################################################################### @@ -60,7 +59,6 @@ # gkalpak # petebacondarwin - version: 3 # Meta field that goes unused by PullApprove to allow for defining aliases to be @@ -78,15 +76,12 @@ meta: # # Also note that the ordering of groups matters in this file. The only groups visible to the current # one are those that appear above it. - no-groups-above-this-pending: &no-groups-above-this-pending - len(groups.active.pending.exclude("required-minimum-review").exclude("global-approvers").exclude("global-docs-approvers")) == 0 - no-groups-above-this-rejected: &no-groups-above-this-rejected - len(groups.active.rejected.exclude("required-minimum-review").exclude("global-approvers").exclude("global-docs-approvers")) == 0 - no-groups-above-this-active: &no-groups-above-this-active - len(groups.active.exclude("required-minimum-review").exclude("global-approvers").exclude("global-docs-approvers")) == 0 + no-groups-above-this-pending: &no-groups-above-this-pending len(groups.active.pending.exclude("required-minimum-review").exclude("global-approvers").exclude("global-docs-approvers")) == 0 + no-groups-above-this-rejected: &no-groups-above-this-rejected len(groups.active.rejected.exclude("required-minimum-review").exclude("global-approvers").exclude("global-docs-approvers")) == 0 + no-groups-above-this-active: &no-groups-above-this-active len(groups.active.exclude("required-minimum-review").exclude("global-approvers").exclude("global-docs-approvers")) == 0 - can-be-global-approved: &can-be-global-approved "\"global-approvers\" not in groups.approved" - can-be-global-docs-approved: &can-be-global-docs-approved "\"global-docs-approvers\" not in groups.approved" + can-be-global-approved: &can-be-global-approved '"global-approvers" not in groups.approved' + can-be-global-docs-approved: &can-be-global-docs-approved '"global-docs-approvers" not in groups.approved' defaults: &defaults reviews: # Authors provide their approval implicitly, this approval allows for a reviewer @@ -99,26 +94,25 @@ meta: # turn on 'draft' support # https://docs.pullapprove.com/config/github-api-version/ # https://developer.github.com/v3/previews/#draft-pull-requests -github_api_version: "shadow-cat-preview" +github_api_version: 'shadow-cat-preview' pullapprove_conditions: # For PRs which are still being worked on, either still in draft mode or indicated through WIP in # title or label, PullApprove stays in a pending state until its ready for review. - condition: "'WIP' not in title" unmet_status: pending - explanation: "Waiting to send reviews as PR is WIP" + explanation: 'Waiting to send reviews as PR is WIP' - condition: "'PR state: WIP' not in labels" unmet_status: pending - explanation: "Waiting to send reviews as PR is WIP" - - condition: "not draft" + explanation: 'Waiting to send reviews as PR is WIP' + - condition: 'not draft' unmet_status: pending - explanation: "Waiting to send reviews as PR is in draft" + explanation: 'Waiting to send reviews as PR is in draft' # Disable PullApprove on specific PRs by adding the `PullApprove: disable` label - condition: "'PullApprove: disable' not in labels" unmet_status: success explanation: "PullApprove skipped because of 'PullApprove: disable' label" - groups: # ========================================================= # Global Approvers @@ -174,37 +168,37 @@ groups: reviewed_for: ignored # All reviews apply to this group whether noted via Reviewed-for or not reviewers: users: - - aikidave # Dave Shevitz - - alan-agius4 # Alan Agius - - alxhub # Alex Rickabaugh - - AndrewKushnir # Andrew Kushnir - - andrewseguin # Andrew Seguin - - atscott # Andrew Scott - - ayazhafiz # Ayaz Hafiz - - clydin # Charles Lyding - - crisbeto # Kristiyan Kostadinov - - devversion # Paul Gschwendtner - - dgp1130 # Doug Parker - - filipesilva # Filipe Silva - - gkalpak # Georgios Kalpakas - - gregmagolan # Greg Magolan - - IgorMinar # Igor Minar - - jbogarthyde # Judy Bogart - - jelbourn # Jeremy Elbourn - - jessicajaniuk # Jessica Janiuk - - JiaLiPassion # Jia Li - - JoostK # Joost Koehoorn - - josephperrott # Joey Perrott - - kyliau # Keen Yee Liau - - manughub # Manu Murthy - - mgechev # Minko Gechev - - mhevery # Miško Hevery - - mmalerba # Miles Malerba - - petebacondarwin # Pete Bacon Darwin - - pkozlowski-opensource # Pawel Kozlowski - - Splaktar # Michael Prentice - - twerske # Emma Twersky - - zarend # Zach Arend + - aikidave # Dave Shevitz + - alan-agius4 # Alan Agius + - alxhub # Alex Rickabaugh + - AndrewKushnir # Andrew Kushnir + - andrewseguin # Andrew Seguin + - atscott # Andrew Scott + - ayazhafiz # Ayaz Hafiz + - clydin # Charles Lyding + - crisbeto # Kristiyan Kostadinov + - devversion # Paul Gschwendtner + - dgp1130 # Doug Parker + - filipesilva # Filipe Silva + - gkalpak # Georgios Kalpakas + - gregmagolan # Greg Magolan + - IgorMinar # Igor Minar + - jbogarthyde # Judy Bogart + - jelbourn # Jeremy Elbourn + - jessicajaniuk # Jessica Janiuk + - JiaLiPassion # Jia Li + - JoostK # Joost Koehoorn + - josephperrott # Joey Perrott + - kyliau # Keen Yee Liau + - manughub # Manu Murthy + - mgechev # Minko Gechev + - mhevery # Miško Hevery + - mmalerba # Miles Malerba + - petebacondarwin # Pete Bacon Darwin + - pkozlowski-opensource # Pawel Kozlowski + - Splaktar # Michael Prentice + - twerske # Emma Twersky + - zarend # Zach Arend # ========================================================= # Framework: Animations @@ -232,7 +226,6 @@ groups: - IgorMinar - jelbourn - # ========================================================= # Framework: Compiler # ========================================================= @@ -257,7 +250,6 @@ groups: - AndrewKushnir - JoostK - # ========================================================= # Framework: Compiler / ngcc # ========================================================= @@ -274,7 +266,6 @@ groups: - JoostK - petebacondarwin - # ========================================================= # Framework: Migrations # ========================================================= @@ -290,7 +281,6 @@ groups: - crisbeto - devversion - # ========================================================= # Framework: Core # ========================================================= @@ -430,7 +420,6 @@ groups: - jessicajaniuk # OOO as of 2020-09-28 - pkozlowski-opensource - # ========================================================= # Framework: Common # ========================================================= @@ -453,7 +442,6 @@ groups: - jessicajaniuk # OOO as of 2020-09-28 - pkozlowski-opensource - # ========================================================= # Framework: Http # ========================================================= @@ -476,7 +464,6 @@ groups: - IgorMinar - petebacondarwin - # ========================================================= # Framework: Elements # ========================================================= @@ -497,7 +484,6 @@ groups: - andrewseguin - gkalpak - # ========================================================= # Framework: Forms # ========================================================= @@ -530,7 +516,6 @@ groups: users: - AndrewKushnir - # ========================================================= # Framework: i18n # ========================================================= @@ -564,7 +549,6 @@ groups: - mhevery - petebacondarwin - # ========================================================= # Framework: Platform Server # ========================================================= @@ -584,7 +568,6 @@ groups: - alxhub - kyliau - # ========================================================= # Framework: Router # ========================================================= @@ -610,7 +593,6 @@ groups: users: - atscott - # ========================================================= # Framework: Service Worker # ========================================================= @@ -638,7 +620,6 @@ groups: - gkalpak - IgorMinar - # ========================================================= # Framework: Upgrade # ========================================================= @@ -669,7 +650,6 @@ groups: - gkalpak - petebacondarwin - # ========================================================= # Framework: Testing # ========================================================= @@ -699,7 +679,6 @@ groups: - IgorMinar # OOO as of 2020-09-28 - pkozlowski-opensource - # ========================================================= # Framework: Benchmarks # ========================================================= @@ -716,7 +695,6 @@ groups: - IgorMinar # OOO as of 2020-09-28 - pkozlowski-opensource - # ========================================================= # Framework: Playground # ========================================================= @@ -734,7 +712,6 @@ groups: - jelbourn # OOO as of 2020-09-28 - pkozlowski-opensource - # ========================================================= # Framework: Security # ========================================================= @@ -760,8 +737,8 @@ groups: - jelbourn # OOO as of 2020-09-28 - pkozlowski-opensource reviews: - request: -1 # request reviews from everyone - required: 2 # require at least 2 approvals + request: -1 # request reviews from everyone + required: 2 # require at least 2 approvals reviewed_for: required # ========================================================= @@ -782,7 +759,6 @@ groups: - josephperrott - kyliau - # ========================================================= # Language Service # ========================================================= @@ -803,7 +779,6 @@ groups: - atscott - zarend - # ========================================================= # zone.js # ========================================================= @@ -855,7 +830,6 @@ groups: - alxhub - josephperrott - # ========================================================= # Integration Tests # ========================================================= @@ -873,7 +847,6 @@ groups: - josephperrott - mhevery - # ========================================================= # Docs: Contributors # ========================================================= @@ -892,7 +865,6 @@ groups: - mgechev - twerske - # ========================================================= # Docs: Gettings Started & Tutorial # ========================================================= @@ -927,7 +899,6 @@ groups: - IgorMinar - jelbourn - # ========================================================= # Docs: Marketing # ========================================================= @@ -976,7 +947,6 @@ groups: users: - alxhub - # ========================================================= # Docs: Packaging, Tooling, Releasing # ========================================================= @@ -1050,11 +1020,10 @@ groups: - kyliau - IgorMinar reviews: - request: -1 # request reviews from everyone - required: 2 # require at least 2 approvals + request: -1 # request reviews from everyone + required: 2 # require at least 2 approvals reviewed_for: required - # ========================================================= # Docs: CLI # ========================================================= @@ -1090,7 +1059,6 @@ groups: - IgorMinar - mgechev - # ========================================================= # Docs: CLI Libraries # ========================================================= @@ -1111,7 +1079,6 @@ groups: - IgorMinar - mgechev - # ========================================================= # Docs: Schematics # ========================================================= @@ -1134,7 +1101,6 @@ groups: - IgorMinar - mgechev - # ========================================================= # Docs-infra # ========================================================= @@ -1169,7 +1135,6 @@ groups: - IgorMinar - petebacondarwin - # ========================================================= # Dev-infra # ========================================================= @@ -1225,7 +1190,6 @@ groups: - IgorMinar - josephperrott - # ========================================================= # Public API # ========================================================= @@ -1262,7 +1226,6 @@ groups: required: 3 # Require that three people approve reviewed_for: required - # ================================================ # Size tracking # ================================================ @@ -1292,7 +1255,6 @@ groups: required: 2 # Require that two people approve reviewed_for: required - # ================================================ # Circular dependencies # ================================================ @@ -1318,10 +1280,9 @@ groups: - zarend # OOO as of 2020-09-28 - pkozlowski-opensource - -#################################################################################### -# Special Cases -#################################################################################### + #################################################################################### + # Special Cases + #################################################################################### # ========================================================= # Code Ownership @@ -1344,7 +1305,6 @@ groups: - josephperrott - mhevery - # ==================================================== # Catch all for if no groups match the code change # ====================================================