honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci: fix pullapprove incorrectly skipping fw-compiler as owner (#36661) 

Currently, if changes are made to `compiler-cli/ngcc` and to other
compiler-related files, then only the `fw-ngcc` group is requested
for review. This is because the `not contains_any_globs` condition
will be false for `fw-compiler` and the group will never become active.

We fix this by removing the incorrect condition and filtering out ngcc
files before checking `contains_any_globs` in the primary fw-compiler
condition.

PR Close #36661
This commit is contained in:
Paul Gschwendtner 2020-04-16 23:18:16 +02:00 committed by Andrew Kushnir
parent b80b43ddae
commit f0ec4ae941
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
.pullapprove.yml
View File

@ -189,7 +189,7 @@ groups:
- *can-be-global-approved - *can-be-global-approved
- *can-be-global-docs-approved - *can-be-global-docs-approved
- > - >
contains_any_globs(files, [ contains_any_globs(files.exclude('packages/compiler-cli/ngcc/**'), [
'packages/compiler/**', 'packages/compiler/**',
'packages/examples/compiler/**', 'packages/examples/compiler/**',
'packages/compiler-cli/**', 'packages/compiler-cli/**',
@ -198,10 +198,6 @@ groups:
'aio/content/guide/aot-metadata-errors.md', 'aio/content/guide/aot-metadata-errors.md',
'aio/content/guide/template-typecheck.md ' 'aio/content/guide/template-typecheck.md '
]) ])
- >
not contains_any_globs(files, [
'packages/compiler-cli/ngcc/**'
])
reviewers: reviewers:
users: users:
- alxhub - alxhub
@ -217,10 +213,7 @@ groups:
conditions: conditions:
- *can-be-global-approved - *can-be-global-approved
- *can-be-global-docs-approved - *can-be-global-docs-approved
- > - files.include('packages/compiler-cli/ngcc/**')
contains_any_globs(files, [
'packages/compiler-cli/ngcc/**'
])
reviewers: reviewers:
users: users:
- alxhub - alxhub