honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(aio): build `scripts-js` before creating a new docker image for the preview server 

When creating a new docker image for the preview server, the TypeScript source
code in `scripts-js/` is not copied over. Instead only the generated JavaScript
core in `scripts-js/dist/` are. Because of that, it is necessary to have run
`yarn build` before running `docker build`, so that the new docker image
contains the latest changes in `scripts-js/`.

This was previously part of the `create-image.sh` script, but was accidentally
removed in 21d213dfc.
This commit is contained in:
Georgios Kalpakas 2017-06-24 23:26:25 +03:00 committed by Matias Niemelä
parent 68fc65dbcb
commit f1626574dd
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
aio/aio-builds-setup/scripts/create-image.sh
View File

@ -5,6 +5,14 @@ set -eux -o pipefail
source "`dirname $0`/_env.sh" source "`dirname $0`/_env.sh"
readonly defaultImageNameAndTag="aio-builds:latest" readonly defaultImageNameAndTag="aio-builds:latest"
# Build `scripts-js/`
# (Necessary, because only `scripts-js/dist/` is copied to the docker image.)
(
cd "$SCRIPTS_JS_DIR"
yarn install
yarn build
)
# Create docker image # Create docker image
readonly nameAndOptionalTag=${1:-$defaultImageNameAndTag} readonly nameAndOptionalTag=${1:-$defaultImageNameAndTag}
sudo docker build --tag $nameAndOptionalTag ${@:2} $DOCKERBUILD_DIR sudo docker build --tag $nameAndOptionalTag ${@:2} $DOCKERBUILD_DIR