honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(bazel): devserver entry_module should have underscore name (#27719) 

This commit fixes a bug whereby the path of the entry_module is not
consistent with the workspace name, which does not permit dashes
in the name.

PR Close #27719
This commit is contained in:
Keen Yee Liau 2018-12-17 17:56:35 -08:00 committed by Miško Hevery
parent e98c57a404
commit f57916c0d9
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/bazel/src/schematics/bazel-workspace/files/src/BUILD.bazel.template
View File

@ -58,7 +58,7 @@ ts_devserver(
"npm/node_modules/zone.js/dist",
"npm/node_modules/tslib",
],
entry_module = "<%= name %>/src/main.dev",
entry_module = "<%= utils.underscore(name) %>/src/main.dev",
serving_path = "/bundle.min.js",
static_files = [
"@npm//node_modules/zone.js:dist/zone.min.js",

9
packages/bazel/src/schematics/bazel-workspace/index_spec.ts
View File

@ -42,6 +42,15 @@ describe('Bazel-workspace Schematic', () => {
expect(workspace).toMatch('ANGULAR_VERSION = "6.6.6"');
});
it('should have the correct entry_module for devserver', () => {
const options = {...defaultOptions, name: 'demo-app'};
const host = schematicRunner.runSchematic('bazel-workspace', options);
const {files} = host;
expect(files).toContain('/demo-app/src/BUILD.bazel');
const content = host.readContent('/demo-app/src/BUILD.bazel');
expect(content).toContain('entry_module = "demo_app/src/main.dev"');
});
describe('WORKSPACE', () => {
it('should contain project name', () => {
const options = {...defaultOptions};