From f57c17de2c75e57f2e7a97d3d752941f69f1dead Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Tue, 27 Aug 2019 15:01:10 +0300 Subject: [PATCH] build: remove the deprecated `aio` commit message scope (#32341) The `aio` commit message scope was renamed to `docs-infra` (which is more descriptive) in #24295. Although it has been removed from the documentation, the legacy `aio` scope was kept in the [list of valid scopes][1] to cater for in-flight PRs that already used it. As a result, it still shows up as a recommended, valid scope in the error message shown when commit message validation fails during `git commit`. This is misleading, especially for new contributors. Since we have been "manually" discouraging people from using `aio`, there should be no open PRs by now (and if there are, they should be changed to `docs-infra`), so it is safe to remove it from the list of allowed scopes. Related discussion: https://github.com/angular/angular/pull/32273#pullrequestreview-279767931 [1]: https://github.com/angular/angular/blob/3df54be9e/tools/validate-commit-message/commit-message.json#L16 PR Close #32341 --- tools/validate-commit-message/commit-message.json | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/validate-commit-message/commit-message.json b/tools/validate-commit-message/commit-message.json index b55cc948e2..0f5c372d3f 100644 --- a/tools/validate-commit-message/commit-message.json +++ b/tools/validate-commit-message/commit-message.json @@ -13,7 +13,6 @@ "test" ], "scopes": [ - "aio", "animations", "bazel", "benchpress",