From f72de51a6f603d4d4073d1b753cdd0f9d837d841 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Fri, 6 Dec 2019 09:56:36 -0800 Subject: [PATCH] build: remove compile build variable (#34280) Remove the remaining check for compile build variable in the ng_module rule. Now that components is no longer relying on this build variable we can safely remove it from our repository. We will leave the remaining check for if the compile build variable is used within our own repo, with plans to remove it in a couple months. It is being kept in place to ensure that uncommitted local scripts for our own development that we have locally, kill error as expected if they still reference the compile build variable. PR Close #34280 --- packages/bazel/src/ng_module.bzl | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/packages/bazel/src/ng_module.bzl b/packages/bazel/src/ng_module.bzl index 3e1329f025..c66bbde31e 100644 --- a/packages/bazel/src/ng_module.bzl +++ b/packages/bazel/src/ng_module.bzl @@ -35,6 +35,8 @@ def is_ivy_enabled(ctx): Returns: Boolean, Whether the ivy compiler should be used. """ + + # TODO(josephperott): Remove after ~Feb 2020, to allow local script migrations if "compile" in ctx.var and ctx.workspace_name == "angular": fail( msg = "Setting ViewEngine/Ivy using --define=compile is deprecated, please use " + @@ -47,13 +49,6 @@ def is_ivy_enabled(ctx): if hasattr(ctx.attr, "ivy") and ctx.attr.ivy == True: return True - # TODO(josephperrott): Remove configuration via compile=aot define flag. - if ctx.var.get("compile", None) == "aot": - # buildifier: disable=print - print("Setting ViewEngine/Ivy using the compile build variable (--define=compile=*) " + - "is deprecated, please use the --define=angular_ivy_enabled=True instead.") - return True - if ctx.var.get("angular_ivy_enabled", None) == "True": return True