honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(common): use correct pipe name in error messages (#19403) 

Fixes #19373
This commit is contained in:
Olivier Combe 2017-09-26 19:18:26 +02:00 committed by Victor Berchet
parent f57b7df4d7
commit f9b0863c8a
2 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/common/src/pipes/number_pipe.ts
View File

@ -49,7 +49,7 @@ export class DecimalPipe implements PipeTransform {
const {str, error} = formatNumber(value, locale, NumberFormatStyle.Decimal, digits); const {str, error} = formatNumber(value, locale, NumberFormatStyle.Decimal, digits);
if (error) { if (error) {
throw invalidPipeArgumentError(CurrencyPipe, error); throw invalidPipeArgumentError(DecimalPipe, error);
} }
return str; return str;
@ -87,7 +87,7 @@ export class PercentPipe implements PipeTransform {
const {str, error} = formatNumber(value, locale, NumberFormatStyle.Percent, digits); const {str, error} = formatNumber(value, locale, NumberFormatStyle.Percent, digits);
if (error) { if (error) {
throw invalidPipeArgumentError(CurrencyPipe, error); throw invalidPipeArgumentError(PercentPipe, error);
} }
return str; return str;

21
packages/common/test/pipes/number_pipe_spec.ts
View File

@ -48,8 +48,11 @@ export function main() {
}); });
it('should not support other objects', () => { it('should not support other objects', () => {
expect(() => pipe.transform({})).toThrowError(); expect(() => pipe.transform({}))
expect(() => pipe.transform('123abc')).toThrowError(); .toThrowError(
`InvalidPipeArgument: '[object Object] is not a number' for pipe 'DecimalPipe'`);
expect(() => pipe.transform('123abc'))
.toThrowError(`InvalidPipeArgument: '123abc is not a number' for pipe 'DecimalPipe'`);
}); });
it('should throw if minFractionDigits is explicitly higher than maxFractionDigits', () => { it('should throw if minFractionDigits is explicitly higher than maxFractionDigits', () => {
@ -78,8 +81,11 @@ export function main() {
expect(pipe.transform(1.2, '4.2', 'fr')).toEqual('0 120,00 %'); expect(pipe.transform(1.2, '4.2', 'fr')).toEqual('0 120,00 %');
}); });
it('should not support other objects', it('should not support other objects', () => {
() => { expect(() => pipe.transform({})).toThrowError(); }); expect(() => pipe.transform({}))
.toThrowError(
`InvalidPipeArgument: '[object Object] is not a number' for pipe 'PercentPipe'`);
});
}); });
}); });
@ -102,8 +108,11 @@ export function main() {
.toEqual('00 005,12 $'); .toEqual('00 005,12 $');
}); });
it('should not support other objects', it('should not support other objects', () => {
() => { expect(() => pipe.transform({})).toThrowError(); }); expect(() => pipe.transform({}))
.toThrowError(
`InvalidPipeArgument: '[object Object] is not a number' for pipe 'CurrencyPipe'`);
});
it('should warn if you are using the v4 signature', () => { it('should warn if you are using the v4 signature', () => {
const warnSpy = spyOn(console, 'warn'); const warnSpy = spyOn(console, 'warn');