honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(dev-infra): always use en-US locale for printing date in merge tool (#42470) 

In the dev-infra merge tool, a test fails locally if it runs on
a system with a different system locale. We can either make the
test more flexible, or update the merge tool to always print the date
in `en-US` format. The latter is more reasonable given our console
messages being in english anyway.

PR Close #42470
This commit is contained in:
Paul Gschwendtner 2021-06-03 20:36:38 +02:00 committed by Jessica Janiuk
parent c8e4783d14
commit fa84d19e97
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev-infra/pr/merge/defaults/lts-branch.ts
View File

@ -53,7 +53,7 @@ export async function assertActiveLtsBranch(
// allow the merge as per our LTS guarantees. Can be forcibly overridden if desired.
// See: https://angular.io/guide/releases#support-policy-and-schedule.
if (today > ltsEndDate) {
const ltsEndDateText = ltsEndDate.toLocaleDateString();
const ltsEndDateText = ltsEndDate.toLocaleDateString('en-US');
warn(red(`Long-term support ended for v${version.major} on ${ltsEndDateText}.`));
warn(yellow(
`Merging of pull requests for this major is generally not ` +