honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build: run pre-check before publishing (#36527) 

Previously, our process included running the pre-check script before
releasing.  With our new publishing process this was dropped.  This
change adds in automatically executing this check before publish for
both next and latest

PR Close #36527
This commit is contained in:
Joey Perrott 2020-04-08 12:19:05 -07:00 committed by Matias Niemelä
parent 47f98673c7
commit fc1b557d98
3 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
scripts/release/pre-check
View File

@ -3,13 +3,9 @@
# Runs the Bazel workspace status command in order to ensure that the version placeholder # Runs the Bazel workspace status command in order to ensure that the version placeholder
# will be replaced with the proper version name when building the release output. # will be replaced with the proper version name when building the release output.
# Ensure that the stamping script is executed within the project directory.
cd $(dirname ${0})/../..
# The "0.0.0-PLACEHOLDER" is based on the value of the "BUILD_SCM_VERSION" status variable.
versionName=$(node tools/bazel_stamp_vars.js | grep -e "BUILD_SCM_VERSION" | cut -d " " -f2) versionName=$(node tools/bazel_stamp_vars.js | grep -e "BUILD_SCM_VERSION" | cut -d " " -f2)
if [[ ! ${versionName} =~ ^[0-9]+\.[0-9]+\.[0-9]+(-(alpha|beta|rc).[0-9]+)?$ ]]; then if [[ ! ${versionName} =~ ^[0-9]+\.[0-9]+\.[0-9]+(-(rc|next).[0-9]+)?$ ]]; then
echo "ERROR: The release will currently have the following version: ${versionName}" echo "ERROR: The release will currently have the following version: ${versionName}"
echo "This does not match the version format for releases to NPM." echo "This does not match the version format for releases to NPM."
echo "" echo ""
@ -17,13 +13,3 @@ if [[ ! ${versionName} =~ ^[0-9]+\.[0-9]+\.[0-9]+(-(alpha|beta|rc).[0-9]+)?$ ]];
echo "with the proper version tag." echo "with the proper version tag."
exit 1 exit 1
fi fi
# Verify peer deps constraints and package.json before publishing to npm
# There should be no npm errors
mkdir tmp
cd tmp
npm init -y
npm install --save ../dist/packages-dist/* typescript@~2.7 rxjs@^6.0.0-beta.4 zone.js@~0.8.20
cd ..
rm -rf ./tmp

5
scripts/release/publish-latest
View File

@ -2,6 +2,10 @@
set -u -e -o pipefail set -u -e -o pipefail
# Runs the pre-check before performing the publish to ensure
# the version is valid for release.
exec "$(dirname "$0")/pre-check";
# Use for production releases # Use for production releases
# Query Bazel for npm_package and ng_package rules with tags=["release-with-framework"] # Query Bazel for npm_package and ng_package rules with tags=["release-with-framework"]
# Publish them to npm (tagged next) # Publish them to npm (tagged next)
@ -22,4 +26,3 @@ for packageLabel in $NPM_PACKAGE_LABELS; do
echo "publishing $packageLabel" echo "publishing $packageLabel"
$BAZEL run --config=release -- ${packageLabel}.publish --access public --tag latest $BAZEL run --config=release -- ${packageLabel}.publish --access public --tag latest
done done

4
scripts/release/publish-next
View File

@ -2,6 +2,10 @@
set -u -e -o pipefail set -u -e -o pipefail
# Runs the pre-check before performing the publish to ensure
# the version is valid for release.
exec "$(dirname "$0")/pre-check";
# Use for BETA and RC releases # Use for BETA and RC releases
# Query Bazel for npm_package and ng_package rules with tags=["release-with-framework"] # Query Bazel for npm_package and ng_package rules with tags=["release-with-framework"]
# Publish them to npm (tagged next) # Publish them to npm (tagged next)