honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ivy): remove unused parameter in postProcessBaseDirective (#28631)

Browse Source 
https://github.com/angular/angular/pull/28089/files#diff-ce885db4223480bd4f7b78bd22b6f058L1650 removed the use of `def` in `postProcessBaseDirective`, making the parameter now useless.

PR Close #28631
This commit is contained in:
cexbrayat 2019-02-09 16:21:51 +01:00 committed by Miško Hevery
parent 2afc40608d
commit fc8f4f8029
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/core/src/render3/instructions.ts
View File

@ -1742,7 +1742,7 @@ export function instantiateRootComponent<T>(
} }
const directive = const directive =
getNodeInjectable(tView.data, viewData, viewData.length - 1, rootTNode as TElementNode); getNodeInjectable(tView.data, viewData, viewData.length - 1, rootTNode as TElementNode);
postProcessBaseDirective(viewData, rootTNode, directive, def as DirectiveDef<T>); postProcessBaseDirective(viewData, rootTNode, directive);
return directive; return directive;
} }
@ -1870,7 +1870,7 @@ function prefillHostVars(tView: TView, lView: LView, totalHostVars: number): voi
function postProcessDirective<T>( function postProcessDirective<T>(
viewData: LView, directive: T, def: DirectiveDef<T>, directiveDefIdx: number): void { viewData: LView, directive: T, def: DirectiveDef<T>, directiveDefIdx: number): void {
const previousOrParentTNode = getPreviousOrParentTNode(); const previousOrParentTNode = getPreviousOrParentTNode();
postProcessBaseDirective(viewData, previousOrParentTNode, directive, def); postProcessBaseDirective(viewData, previousOrParentTNode, directive);
ngDevMode && assertDefined(previousOrParentTNode, 'previousOrParentTNode'); ngDevMode && assertDefined(previousOrParentTNode, 'previousOrParentTNode');
if (previousOrParentTNode && previousOrParentTNode.attrs) { if (previousOrParentTNode && previousOrParentTNode.attrs) {
setInputsFromAttrs(directiveDefIdx, directive, def, previousOrParentTNode); setInputsFromAttrs(directiveDefIdx, directive, def, previousOrParentTNode);
@ -1890,7 +1890,7 @@ function postProcessDirective<T>(
* A lighter version of postProcessDirective() that is used for the root component. * A lighter version of postProcessDirective() that is used for the root component.
*/ */
function postProcessBaseDirective<T>( function postProcessBaseDirective<T>(
lView: LView, previousOrParentTNode: TNode, directive: T, def: DirectiveDef<T>): void { lView: LView, previousOrParentTNode: TNode, directive: T): void {
const native = getNativeByTNode(previousOrParentTNode, lView); const native = getNativeByTNode(previousOrParentTNode, lView);
ngDevMode && assertEqual( ngDevMode && assertEqual(