honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build: make ng_module.bzl is_ivy_enabled function public (#33992) 

We need to make is_ivy_enabled public to allow the internal i18n
build rule to rely on it rather than relying on compile_strategy.
After we move the internal i18n rule to rely on is_ivy_enabled,
compile_strategy can then be removed.

PR Close #33992
This commit is contained in:
Joey Perrott 2019-11-22 10:53:00 -08:00 committed by Matias Niemelä
parent e24453b9f8
commit fe91700dc6
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/bazel/src/ng_module.bzl
View File

@ -54,7 +54,7 @@ def compile_strategy(ctx):
return strategy return strategy
def _is_ivy_enabled(ctx): def is_ivy_enabled(ctx):
"""Determine if the ivy compiler should be used to by the ng_module. """Determine if the ivy compiler should be used to by the ng_module.
Args: Args:
@ -89,7 +89,7 @@ def _compiler_name(ctx):
The name of the current compiler to be displayed in build output The name of the current compiler to be displayed in build output
""" """
return "Ivy" if _is_ivy_enabled(ctx) else "ViewEngine" return "Ivy" if is_ivy_enabled(ctx) else "ViewEngine"
def _is_view_engine_enabled(ctx): def _is_view_engine_enabled(ctx):
"""Determines whether Angular outputs will be produced by the current compilation strategy. """Determines whether Angular outputs will be produced by the current compilation strategy.
@ -102,7 +102,7 @@ def _is_view_engine_enabled(ctx):
factory files), false otherwise factory files), false otherwise
""" """
return not _is_ivy_enabled(ctx) return not is_ivy_enabled(ctx)
def _basename_of(ctx, file): def _basename_of(ctx, file):
ext_len = len(".ts") ext_len = len(".ts")
@ -323,7 +323,7 @@ def _ngc_tsconfig(ctx, files, srcs, **kwargs):
"generateNgSummaryShims": True if generate_ve_shims else False, "generateNgSummaryShims": True if generate_ve_shims else False,
# Summaries are only enabled if Angular outputs are to be produced. # Summaries are only enabled if Angular outputs are to be produced.
"enableSummariesForJit": is_legacy_ngc, "enableSummariesForJit": is_legacy_ngc,
"enableIvy": _is_ivy_enabled(ctx), "enableIvy": is_ivy_enabled(ctx),
"fullTemplateTypeCheck": ctx.attr.type_check, "fullTemplateTypeCheck": ctx.attr.type_check,
# TODO(alxhub/arick): template type-checking for Ivy needs to be tested in g3 before it can # TODO(alxhub/arick): template type-checking for Ivy needs to be tested in g3 before it can
# be enabled here. # be enabled here.