honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(core): allow null value for renderer setElement(…) (#17065) 

Using Renderer’s setElementAttribute or setElementStyle with a null or undefined value removes the
corresponding attribute or style. The argument type should allow this when using strictNullChecks.

Closes #13686

PR Close #17065
This commit is contained in:
Manduro 2017-05-27 13:48:59 +02:00 committed by Miško Hevery
parent ea20ae63d0
commit ff15043e48
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/core/src/render/api.ts
View File

@ -73,7 +73,7 @@ export abstract class Renderer {
abstract setElementProperty(renderElement: any, propertyName: string, propertyValue: any): void; abstract setElementProperty(renderElement: any, propertyName: string, propertyValue: any): void;
abstract setElementAttribute(renderElement: any, attributeName: string, attributeValue: string): abstract setElementAttribute(renderElement: any, attributeName: string, attributeValue?: string):
void; void;
/** /**
@ -84,7 +84,7 @@ export abstract class Renderer {
abstract setElementClass(renderElement: any, className: string, isAdd: boolean): void; abstract setElementClass(renderElement: any, className: string, isAdd: boolean): void;
abstract setElementStyle(renderElement: any, styleName: string, styleValue: string): void; abstract setElementStyle(renderElement: any, styleName: string, styleValue?: string): void;
abstract invokeElementMethod(renderElement: any, methodName: string, args?: any[]): void; abstract invokeElementMethod(renderElement: any, methodName: string, args?: any[]): void;

4
packages/core/src/view/refs.ts
View File

@ -433,7 +433,7 @@ class RendererAdapter implements RendererV1 {
this.delegate.setProperty(renderElement, propertyName, propertyValue); this.delegate.setProperty(renderElement, propertyName, propertyValue);
} }
setElementAttribute(renderElement: Element, namespaceAndName: string, attributeValue: string): setElementAttribute(renderElement: Element, namespaceAndName: string, attributeValue?: string):
void { void {
const [ns, name] = splitNamespace(namespaceAndName); const [ns, name] = splitNamespace(namespaceAndName);
if (attributeValue != null) { if (attributeValue != null) {
@ -453,7 +453,7 @@ class RendererAdapter implements RendererV1 {
} }
} }
setElementStyle(renderElement: HTMLElement, styleName: string, styleValue: string): void { setElementStyle(renderElement: HTMLElement, styleName: string, styleValue?: string): void {
if (styleValue != null) { if (styleValue != null) {
this.delegate.setStyle(renderElement, styleName, styleValue); this.delegate.setStyle(renderElement, styleName, styleValue);
} else { } else {

4
tools/public_api_guard/core/core.d.ts vendored
View File

@ -692,10 +692,10 @@ export declare abstract class Renderer {
abstract projectNodes(parentElement: any, nodes: any[]): void; abstract projectNodes(parentElement: any, nodes: any[]): void;
abstract selectRootElement(selectorOrNode: string | any, debugInfo?: RenderDebugInfo): any; abstract selectRootElement(selectorOrNode: string | any, debugInfo?: RenderDebugInfo): any;
abstract setBindingDebugInfo(renderElement: any, propertyName: string, propertyValue: string): void; abstract setBindingDebugInfo(renderElement: any, propertyName: string, propertyValue: string): void;
abstract setElementAttribute(renderElement: any, attributeName: string, attributeValue: string): void; abstract setElementAttribute(renderElement: any, attributeName: string, attributeValue?: string): void;
abstract setElementClass(renderElement: any, className: string, isAdd: boolean): void; abstract setElementClass(renderElement: any, className: string, isAdd: boolean): void;
abstract setElementProperty(renderElement: any, propertyName: string, propertyValue: any): void; abstract setElementProperty(renderElement: any, propertyName: string, propertyValue: any): void;
abstract setElementStyle(renderElement: any, styleName: string, styleValue: string): void; abstract setElementStyle(renderElement: any, styleName: string, styleValue?: string): void;
abstract setText(renderNode: any, text: string): void; abstract setText(renderNode: any, text: string): void;
} }