06d3267824
docs: improve accessibility for toh-pt1 example ( #40560 )
...
PR Close #40560
2021-02-23 10:41:56 -08:00
1f91672d50
docs: improve accessibility of toh2 example ( #40575 )
...
Increases contrast of example copy.
Explicitly references inputs from labels.
Updates screenshot of styles that aren't accessible.
Removes the term master.
Provides more detailed alternate text for the image.
Adds padding to input so it is an easier target for touch or pointer.
PR Close #40575
2021-02-23 10:41:05 -08:00
1f7921be33
docs: improve accessibility of tohpt3 ( #40617 )
...
PR Close #40617
2021-02-23 10:40:09 -08:00
bd6f377db2
docs: improve accessibility of tohpt4 ( #40622 )
...
PR Close #40622
2021-02-23 10:39:44 -08:00
4d1299bd82
docs: improve accessibility of toh-pt5 example ( #40632 )
...
PR Close #40632
2021-02-23 10:39:13 -08:00
edd26a2b79
docs: improve accessibility of toh-pt6 ( #40805 )
...
PR Close #40805
2021-02-23 10:38:50 -08:00
49e02ca7d6
docs: move JsonParser class above CustomJsonInterceptor ( #40964 )
...
This move fixes the error in StackBlitz of
Cannot access 'JsonParser' before initialization
PR Close #40964
2021-02-23 10:37:26 -08:00
b84f719747
docs: update year ( #40925 )
...
PR Close #40925
2021-02-22 12:37:40 -08:00
09e1e1935a
refactor(docs-infra): convert Sass mixin from camelCase to kebab-case to follow Sass conventions ( #40881 )
...
This commit converts the last remaining camelCased Sass mixin
(`deployTheme`) to kebab-case (`deploy-theme`) to follow the Sass
conventions.
Discussed in
https://github.com/angular/angular/pull/40881#discussion_r577961617 .
PR Close #40881
2021-02-19 09:14:59 -08:00
4b3e6b5a00
refactor(docs-infra): create mixin for styling marketing pages ( #40881 )
...
Previously, in order to apply some styles to marketing (i.e. non-docs)
pages, we listed the various `.page-*` classes that corresponded to docs
pages. This meant that adding/removing a marketing page required updates
in several places, which is error-prone.
This commit avoids this by using a Sass mixin for applying styles to
marketing pages.
PR Close #40881
2021-02-19 09:14:59 -08:00
c5231ce1da
refactor(docs-infra): remove duplicate or unused CSS styles ( #40881 )
...
This commit removes some CSS styles that have no effect (i.e. are
duplicates or overridden by other rules).
PR Close #40881
2021-02-19 09:14:59 -08:00
717590a732
fix(docs-infra): fix top margin of "Press kit" page on small screens ( #40881 )
...
Previously, the "Press kit" page had a larger top margin on smaller
screens, that seemed unnecessary.
This commit removes the extra top margin.
Before: ![presskit top section margin before][1]
After: ![presskit top section margin after][2]
[1]: https://user-images.githubusercontent.com/8604205/107988545-efb27080-6fd8-11eb-91d6-79651f2dffaf.png
[2]: https://user-images.githubusercontent.com/8604205/107988547-f04b0700-6fd8-11eb-9c4b-d444b39a34fe.png
PR Close #40881
2021-02-19 09:14:59 -08:00
c704162800
fix(docs-infra): use consistent padding in marketing pages ( #40881 )
...
This commit makes the padding of the "Events", "Features" and
"Press kit" pages consistent with that of other marketing pages.
Before: ![presskit padding before][1]
After: ![presskit padding after][2]
[1]: https://user-images.githubusercontent.com/8604205/107986067-f8547800-6fd3-11eb-9164-51793e431d05.png
[2]: https://user-images.githubusercontent.com/8604205/107986064-f7234b00-6fd3-11eb-9050-ed7ec04e7443.png
PR Close #40881
2021-02-19 09:14:59 -08:00
09d36369b0
fix(docs-infra): make top-nav consistent across all marketing pages ( #40881 )
...
Previously, some of the marketing pages had different styles for the
top-nav than others (even if they had the same layout and
blue-background header). More specifically, the top-nav had a box-shadow
and it was absolutely positioned on some marketing pages, while it had
no box-shadow and was statically positioned on others.
This commit makes the appearance of marketing pages wrt the top-nav
consistent across all marketing pages by changing the styles for the
remaining pages:
- Contributors (`/about`)
- Contribute (`/contribute`)
- Press kit (`/presskit`)
Before: ![contribute topnav shadow before][1]
After: ![contribute topnav shadow after][2]
[1]: https://user-images.githubusercontent.com/8604205/107984898-a6aaee00-6fd1-11eb-8bf3-79393c8983ff.png
[2]: https://user-images.githubusercontent.com/8604205/107984900-a7438480-6fd1-11eb-8d9b-a643d69ab692.png
PR Close #40881
2021-02-19 09:14:59 -08:00
b509a7dc42
fix(docs-infra): make the "Contributors" page header similar to other marketing pages ( #40881 )
...
Before (wide screen): ![contributors (wide screen) before][1]
Before (narrow screen): ![contributors (narrow screen) before][2]
After (wide screen): ![contributors (wide screen) after][3]
After (narrow screen): ![contributors (narrow screen) after][4]
[1]: https://user-images.githubusercontent.com/8604205/107983880-634f8000-6fcf-11eb-8ad9-5a5df65d3d5e.png
[2]: https://user-images.githubusercontent.com/8604205/107983893-6a768e00-6fcf-11eb-9ccd-158ec491404f.png
[3]: https://user-images.githubusercontent.com/8604205/107983903-6f3b4200-6fcf-11eb-94e1-182893b7a715.png
[4]: https://user-images.githubusercontent.com/8604205/107983895-6ba7bb00-6fcf-11eb-9ff5-59d221ba906d.png
PR Close #40881
2021-02-19 09:14:59 -08:00
b0c8c4d696
fix(docs-infra): add spacing between past and future events sections ( #40881 )
...
This commit adds some more spacing between the past and future events
sections on the "Events" page.
Before: ![events spacing before][1]
After: ![events spacing after][2]
[1]: https://user-images.githubusercontent.com/8604205/107989711-82eca580-6fdb-11eb-837e-1255d439d51a.png
[2]: https://user-images.githubusercontent.com/8604205/107989708-81bb7880-6fdb-11eb-8cf4-4653254e1c37.png
PR Close #40881
2021-02-19 09:14:59 -08:00
71ccb545c6
refactor(docs-infra): create mixin for styling docs pages ( #40881 )
...
Previously, in order to apply some styles to docs (i.e. non-marketing)
pages, we listed the various `.folder-*` classes that corresponded to
docs pages. This meant that adding/removing a docs area required updates
in several places, which is error-prone.
This commit avoids this by using a Sass mixin for applying styles to
docs pages.
PR Close #40881
2021-02-19 09:14:59 -08:00
44e1f956d0
fix(docs-infra): ensure the main font is applied to inputs ( #40881 )
...
It turns out that `<input>` and `<button>` elements do not inherit the
`font-family` style from `<body>` by default, but rather use a
user-agent defined style. This means that their font-family might be
different than the one used in the rest of the page.
This commit fixes it by ensuring `<input>` (and other) elements inherit
their `font-family` style from their parent element.
Before: ![inputs font before][1]
After: ![inputs font after][2]
(The difference in font is subtle, but it's there.)
[1]: https://user-images.githubusercontent.com/8604205/107853245-76bae980-6e1d-11eb-8318-e5f6e13876cc.png
[2]: https://user-images.githubusercontent.com/8604205/107853246-77538000-6e1d-11eb-86f2-e3e7e41158f5.png
PR Close #40881
2021-02-19 09:14:59 -08:00
7bcef26852
refactor(docs-infra): remove unnecessary `font-family` styles ( #40881 )
...
This commit removes some unnecessary styles setting `font-family` to
`$main-font`. These styles are redundant, because the targeted elements
already inherit this style from `<body>`.
PR Close #40881
2021-02-19 09:14:59 -08:00
90a61618c7
refactor(docs-infra): remove unused CSS for the version selector ( #40881 )
...
This commit removes some CSS rules targeting `.doc-version select` in
the sidenav. These rules do not match any elements any more, since now
we use a custom `<aio-select>` component (instead of the `<select>`
element).
PR Close #40881
2021-02-19 09:14:59 -08:00
64efe38d66
fix(docs-infra): merge `docs` with `guide` and `start` with `tutorial` in search-results ( #40881 )
...
Previously, the `docs.md` guide was appearing under "OTHER" in search
results and the results for the `/start*` tutorial pages were appearing
under "START".
This commit changes this so that `docs.md` appears under "GUIDES" and
`/start*` appear under "TUTORIALS", since that is where they belong
conceptually.
It also changes the header of the guides search-area from "GUIDE" to
"GUIDES" and that of tutorials from "TUTORIAL" to "TUTORIALS".
Before: ![search-results areas before][1]
After: ![search-results areas after][2]
[1]: https://user-images.githubusercontent.com/8604205/107811568-0ce80480-6d77-11eb-8652-e7a947c36e63.png
[2]: https://user-images.githubusercontent.com/8604205/107811569-0eb1c800-6d77-11eb-9a69-0000a3703c8a.png
PR Close #40881
2021-02-19 09:14:59 -08:00
4fac4a8880
fix(docs-infra): show the "Errors List" page under "ERRORS" in search results ( #40881 )
...
Previously, the "Errors List" page was appearing under the "OTHER"
section in search results.
This commit fixes this to make it appear under the "ERRORS" section.
Before: ![search-results before][1]
After: ![search-results after][2]
[1]: https://user-images.githubusercontent.com/8604205/107691151-c1b8ed80-6cb3-11eb-8079-fcace685f0ec.png
[2]: https://user-images.githubusercontent.com/8604205/107691145-bfef2a00-6cb3-11eb-8523-b2747fa40469.png
PR Close #40881
2021-02-19 09:14:59 -08:00
fb58a2bd54
fix(docs-infra): use relative URLs for internal links on error pages ( #40881 )
...
Previously, some of the links on the error pages had URLs prefixed with
`https://angular.io/ `. This caused them to be treated as external URLs,
which had the following downsides:
- Links would always point to `angular.io` instead of the same version
as the error page (e.g. `next.angular.io` or `v11.angular.io`).
- Dgeni would not be able to check that the URLs are valid (i.e. point
to existing pages).
- An external link icon would incorrectly be shown next to the links on
`angular.io`.
This commit fixes the links to use relative URLs.
PR Close #40881
2021-02-19 09:14:59 -08:00
51c7d32c09
fix(docs-infra): show external link icons for external links on error pages ( #40881 )
...
This commit adds error pages to the list of docs pages that have an
external link icon next to links to external URLs.
PR Close #40881
2021-02-19 09:14:59 -08:00
d0b6270990
docs: edit Component lifecycle title ( #40894 )
...
PR Close #40894
2021-02-19 09:10:37 -08:00
aed2782c4a
docs: the token should be associated with LibHeaderComponent ( #40922 )
...
PR Close #40922
2021-02-19 09:07:00 -08:00
30d5e25a28
docs: edit attribute-directives.md, move best practice to styleguide ( #39849 )
...
PR Close #39849
2021-02-19 08:14:54 -08:00
65baac6055
docs: update attribute-binding.md to correctly describe [attr.binding] rules ( #40878 )
...
PR Close #40878
2021-02-17 17:05:17 -08:00
2375b85fe0
docs: remove mention of unused `Intl` polyfill ( #40883 )
...
Since `Intl` API was dropped to use to improve browser support,
it is no longer needed as a polyfill to test Angular.
PR Close #40883
2021-02-17 17:04:15 -08:00
1de999b89d
docs: fix minor grammar mistakes in What is Angular topic ( #40892 )
...
PR Close #40892
2021-02-17 13:23:49 -08:00
8658cd59b2
docs: add what is angular topic ( #40811 )
...
PR Close #40811
2021-02-17 11:13:21 -08:00
9b26f462d0
docs: fix grammar in angular-compiler-options file ( #40879 )
...
PR Close #40879
2021-02-17 06:56:38 -08:00
0807d13201
docs: remove the extra backtick character ( #40873 )
...
PR Close #40873
2021-02-17 06:56:03 -08:00
322951af49
refactor(compiler-cli): error on cyclic imports in partial compilation ( #40782 )
...
Our approach for handling cyclic imports results in code that is
not easy to tree-shake, so it is not suitable for publishing in a
library.
When compiling in partial compilation mode, we are targeting
such library publication, so we now create a fatal diagnostic
error instead of trying to handle the cyclic import situation.
Closes #40678
PR Close #40782
2021-02-17 06:53:38 -08:00
a4c00c2148
build: upgrade `webdriver-manager` to v12.1.8 ( #40756 )
...
ChromeDriver now supports Apple Silicon ARM processors.
`webdriver-manager` versions 12.1.7 and earlier will, however,
incorrectly download the arm64 ChromeDriver regardless of the
system's architecture. This results in failure to run Protractor tests
on macOS with the error: `spawn Unknown system error -86`
This commit fixes the problem by upgrading `webdriver-manager` to
version 12.1.8, which includes a fix.
See also https://stackoverflow.com/questions/65618558 .
PR Close #40756
2021-02-17 06:52:31 -08:00
75db0c7445
docs: edit builtin-directives doc ( #39816 )
...
Edit built-in-directives.md copy and headers, fixes affected
links, adds a docregion to make steps clearer.
PR Close #39816
2021-02-16 13:04:41 -08:00
c47dbbede7
docs: fix broken link in `Default Architect builders and targets` section (+ remove typo 'the') ( #40847 )
...
PR Close #40847
2021-02-16 10:04:48 -08:00
82e7ba2702
docs: add observer-spy to resources page ( #40624 )
...
PR Close #40624
2021-02-16 10:03:58 -08:00
dd3dd63845
docs: use shorthand background CSS property in Routing example ( #40834 )
...
PR Close #40834
2021-02-16 09:26:26 -08:00
d6440c1808
docs: fix missing code line from tutorial example ( #40789 )
...
In #40419 we move the code that creates the `heroes` object
above the code that updates the message service. But this moved
that line of code outside of the docregion that is displayed in
the tutorial ealier on, making it non-sensical.
This commit ensures that this line of code is now rendered in the
tutorial be moving it within the correct docregion.
Closes #40788
PR Close #40789
2021-02-16 08:40:26 -08:00
013f7be0bc
fix(docs-infra): fix top padding of main content when a notification is visible ( #40802 )
...
This commit fixes the top padding of the main content on the homepage
and other pages when a notification is visible at the top of the page.
The problem was particularly obvious on the homepage (see images below).
Before: ![homepage top-right before][1]
After: ![homepage top-right after][2]
[1]: https://user-images.githubusercontent.com/8604205/107394349-74e2e480-6b04-11eb-8853-71a153cdc459.png
[2]: https://user-images.githubusercontent.com/8604205/107394336-71e7f400-6b04-11eb-9ef0-ff82f6f27875.png
PR Close #40802
2021-02-16 08:39:49 -08:00
fae0f1f213
fix(docs-infra): fix placement of TOC hover/active markers (dots) ( #40802 )
...
This commit fixes the placement of the TOC hover/active markers (dots)
so that they are horizontally in the middle of the marker "rail" and
vertically in the middle of the item's first line.
This commit also refactors the `_toc.scss` to be more DRY (wrt styling
the TOC markers/marker rail) and uses Sass variables and mixins to
ensure that the styling is kept up-to-date wrt future typography changes
to TOC items.
Before: ![toc marker before][1]
After: ![toc marker after][2]
[1]: https://user-images.githubusercontent.com/8604205/107270751-03e3f400-6a54-11eb-9d77-5b0a3cfb1c2b.png
[2]: https://user-images.githubusercontent.com/8604205/107270758-047c8a80-6a54-11eb-82c0-98b832c109a3.png
PR Close #40802
2021-02-16 08:39:49 -08:00
5a7eba294a
fix(docs-infra): improve line-spacing between TOC items (esp. for wrapped lines) ( #40802 )
...
Previously, the line-spacing between different TOC items was almost the
same as that between wrapped lines of the same item. This made it more
diffucult to distinguish the different items.
This commit fixes this by reducing the line-spacing between wrapped
lines of the same item and keeping a larger line-spacing between
different items.
Before: ![toc line-spacing before][1]
After: ![toc line-spacing after][2]
[1]: https://user-images.githubusercontent.com/8604205/107255272-ccb81780-6a40-11eb-9612-4e7b2058417d.png
[2]: https://user-images.githubusercontent.com/8604205/107255280-cd50ae00-6a40-11eb-8f60-9ce8fba10e12.png
PR Close #40802
2021-02-16 08:39:49 -08:00
9740b1bb62
fix(docs-infra): fix sidenav top position on narrow screens ( #40802 )
...
On larger screens the top-bar has a height of 64px. On screens smaller
than 600px, the top-bar has a height of 56px. As a result, the sidenav
should have a top position of 56px on screens smaller than 600px and
64px on other screens.
Previously, the style setting the top position to 56px was tied to the
presence of the `.collapsed` class, which depends on whether the sidenav
is docked or not. The change from docked to collapsed sidenav, however,
happens at 992px. As a result, the sidenav had an incorrect top position
(56px instead of 64px) on screens between 600px and 991px.
This commit fixes this by ensuring the change of the top position for
the sidenav happens at 600px.
PR Close #40802
2021-02-16 08:39:49 -08:00
01ed63522a
fix(docs-infra): improve line-spacing between search results (esp. for wrapped lines) ( #40802 )
...
Previously, the line-spacing between different search result items was
the same as that between wrapped lines of the same result. This made it
difficult to distinguish the different results.
This commit fixes it by reducing the line-spacing between wrapped lines
of the same result item and keeping a larger line-spacing between
different results.
Before: ![search-results before][1]
After: ![search-results after][2]
[1]: https://user-images.githubusercontent.com/8604205/107229685-ca48c400-6a26-11eb-8161-0c0768b10a2d.png
[2]: https://user-images.githubusercontent.com/8604205/107229691-ccab1e00-6a26-11eb-9594-d4c37d0d72b2.png
PR Close #40802
2021-02-16 08:39:49 -08:00
2a302dd3cf
fix(docs-infra): avoid page-breaks inside an image when printing ( #40802 )
...
Previously, when printing, a page-break could be inserted inside an
image (contained in a `.lightbox` element).
This commit ensures no page-breaks are inserted inside `.lightbox`
elements (which contain images).
Before: ![print-page-break before][1]
After: ![print-page-break after][2]
[1]: https://user-images.githubusercontent.com/8604205/106939709-48f0e900-6729-11eb-912c-e5cd0cb40897.png
[2]: https://user-images.githubusercontent.com/8604205/106939707-48585280-6729-11eb-8d5f-a12312f32056.png
PR Close #40802
2021-02-16 08:39:49 -08:00
c98ab1f9e7
fix(docs-infra): fix search results top padding when a notification is visible ( #40802 )
...
Previously, when a notification was visible at the top of the page, the
search results pane had more top padding than necessary.
This commit fixes it by removing the extra padding.
Before: ![search-results before][1]
After: ![search-results after][2]
[1]: https://user-images.githubusercontent.com/8604205/106938100-3970a080-6727-11eb-8ae8-4e7a33af1daf.png
[2]: https://user-images.githubusercontent.com/8604205/106938103-3aa1cd80-6727-11eb-96f5-f607bde314be.png
PR Close #40802
2021-02-16 08:39:49 -08:00
93e2aea4bd
fix(docs-infra): dim line-numbers in code examples ( #40802 )
...
This commit ensures that the line-numbers in code examples appear
"dimmed" to make it clearer that they are not part of the actual code.
Based on the CSS rules, it seems that the intention was to make it so,
but the color was incorrectly set on the `<ol>` elements instead of
targeting `li::marker`.
Before: ![line-numbers before][1]
After: ![line-numbers after][2]
[1]: https://user-images.githubusercontent.com/8604205/106937191-23aeab80-6726-11eb-9178-bdc067fa3d09.png
[2]: https://user-images.githubusercontent.com/8604205/106937184-227d7e80-6726-11eb-81d1-f709537b6a56.png
PR Close #40802
2021-02-16 08:39:48 -08:00
8cea3be8f7
fix(docs-infra): fix vertical alignment of contributor info items ( #40802 )
...
This commit fixes the vertical alignment of info items (i.e. links to
bio, Twitter, website) in the contributor list.
Before: ![contributor alignment before][1]
After: ![contributor alignment after][2]
[1]: https://user-images.githubusercontent.com/8604205/106926453-ca407f80-6719-11eb-9580-8614cc4f4907.png
[2]: https://user-images.githubusercontent.com/8604205/106926469-cd3b7000-6719-11eb-8ba8-c8ae01996c02.png
PR Close #40802
2021-02-16 08:39:48 -08:00
8f7fea4ad8
fix(docs-infra): clear unneeded DOM nodes in `CodeExample/TabsComponent` ( #40802 )
...
Both `CodeExampleComponent` and `CodeTabsComponent` components receive
some code via content projection, grab the projected content and pass it
through to a `CodeComponent` instance for formatting and displaying.
Previously, the projected content was kept in the DOM (hidden). This
unnecessarily increased the number of DOM nodes.
This commit fixes this by clearing the projected DOM nodes once their
content has been captured.
PR Close #40802
2021-02-16 08:39:48 -08:00
Kapunahele Wong
Daniel Díaz
George Kalpakas
Amadou Sall
DerekRTP
Dmitrij Kuba
David Shevitz
Pete Bacon Darwin
Alexey Elin
