angular-cn

Commit Graph

Author	SHA1	Message	Date
Joey Perrott	350dadab73	fix(router): update type castings for JSON.parse usage (#40710 ) Update usages of JSON.parse to be cast as specific types. PR Close #40710	2021-02-09 10:48:43 -08:00
Joey Perrott	d1ea1f4c7f	build: update license headers to reference Google LLC (#37205 ) Update the license headers throughout the repository to reference Google LLC rather than Google Inc, for the required license headers. PR Close #37205	2020-05-26 14:26:58 -04:00
Martin Sikora	d9c4840a9c	fix(router): cancel navigation when at least one resolver completes with no "next" emission (#24621 ) This change aligns behavior for resolvers which return EMPTY. Currently EMPTY resolvers have inconsistent behavior: - One resolver that returns EMPTY => won't navigate and just ends on ResolveStart router event. - Two resolvers where both return EMPTY => throws "Error: Uncaught (in promise): EmptyError: no elements in sequence" - Two resolvers where one returns a value and the other one returns EMPTY => Navigates successfully. With this change any EMPTY resolver will cancel navigation. BREAKING CHANGE: Any resolver which return EMPTY will cancel navigation. If you want to allow the navigation to continue, you will need to update the resolvers to emit some value, (i.e. defaultIfEmpty(...), of(...), etc). PR Close #24195 PR Close #24621	2020-05-04 12:36:49 -07:00

Author

SHA1

Message

Date

Joey Perrott

350dadab73

fix(router): update type castings for JSON.parse usage (#40710 )

Update usages of JSON.parse to be cast as specific types.

PR Close #40710

2021-02-09 10:48:43 -08:00

Joey Perrott

d1ea1f4c7f

build: update license headers to reference Google LLC (#37205 )

Update the license headers throughout the repository to reference Google LLC
rather than Google Inc, for the required license headers.

PR Close #37205

2020-05-26 14:26:58 -04:00

Martin Sikora

d9c4840a9c

fix(router): cancel navigation when at least one resolver completes with no "next" emission (#24621 )

This change aligns behavior for resolvers which return EMPTY. Currently EMPTY resolvers have inconsistent behavior:
- One resolver that returns EMPTY => won't navigate and just ends on ResolveStart router event.
- Two resolvers where both return EMPTY => throws "Error: Uncaught (in promise): EmptyError: no elements in sequence"
- Two resolvers where one returns a value and the other one returns EMPTY => Navigates successfully.
With this change any EMPTY resolver will cancel navigation.

BREAKING CHANGE: Any resolver which return EMPTY will cancel navigation.
If you want to allow the navigation to continue, you will need to update the resolvers to emit
some value, (i.e. defaultIfEmpty(...), of(...), etc).
PR Close #24195

PR Close #24621

2020-05-04 12:36:49 -07:00

3 Commits