b4b21bdff4
fix(upgrade): fix HMR for hybrid applications ( #40045 )
...
Previously, trying to apply a change via Hot Module Replacement (HMR) in
a hybrid app would result in an error. This was caused by not having the
AngularJS app destroyed and thus trying to bootstrap an AngularJS app on
the same element twice.
This commit fixes HMR for hybrid apps by ensuring the AngularJS app is
destroyed when the Angular `PlatformRef` is [destroyed][1] in the
[`module.hot.dispose()` callback][2].
NOTE:
For "ngUpgradeLite" apps (i.e. those using `downgradeModule()`), HMR
will only work if the downgraded module has been bootstrapped and there
is at least one Angular component present on the page. The is due to a
combination of two facts:
- The logic for setting up the listener that destroys the AngularJS app
depends on the downgraded module's `NgModuleRef`, which is only
available after the module has been bootstrapped.
- The [HMR dispose logic][3] depends on having an Angular element
(identified by the auto-geenrated `ng-version` attribute) present in
the DOM in order to retrieve the Angular `PlatformRef`.
[1]:
https://github.com/angular/angular-cli/blob/205ea2b638f154291993bfd9e065cd66ff20503/packages/angular_devkit/build_angular/src/webpack/plugins/hmr/hmr-accept.ts#L75
[2]:
205ea2b638/packages/angular_devkit/build_angular/src/webpack/plugins/hmr/hmr-accept.ts (L31)205ea2b638/packages/angular_devkit/build_angular/src/webpack/plugins/hmr/hmr-accept.ts (L116)Fixes #39935
PR Close #40045
2020-12-10 13:40:53 -08:00
Paul Gschwendtner
George Kalpakas
Joey Perrott