Fabian Wiles
1b0b36d143
fix(forms): match getError and hasError to get method signature ( #20211 )
...
Internally getError and hasError call the AbstractControl#get method which takes `path: Array<string | number> | string` as input, since there are different ways to traverse the AbstractControl tree.
This change matches the method signitures of all methods that use this.
PR Close #20211
2019-01-03 10:16:06 -08:00
Kara Erickson
e268a0579a
docs(forms): update desc for hasError and getError ( #27861 )
...
This commit adds docs for the changes made in #20211 .
Closes #19734 .
PR Close #27861
2019-01-03 10:15:23 -08:00
jnizet
bba5e2632e
docs(forms): clarify the pattern validator behavior ( #27560 )
...
PR Close #27560
2018-12-21 15:12:31 -05:00
Brandon Roberts
a433baf99a
docs(forms): update API reference for validator directives ( #26926 )
...
PR Close #26926
2018-12-17 16:45:35 -08:00
Alex Eagle
d32939d51a
build: restrict visibility of npm_package targets ( #27611 )
...
dependencies on these cause very long rebuilds which have to re-package angular.
Such tests belong in the integration/ folder
PR Close #27611
2018-12-14 10:20:40 -08:00
cexbrayat
b0c75611d6
fix(forms): typed argument for FormBuilder group ( #26985 )
...
PR Close #26985
2018-12-07 09:30:07 -08:00
Igor Minar
1b84b11cf5
Revert "fix(forms): apply unicode flag to pattern attribute when supported ( #20819 )" ( #27375 )
...
This reverts commit 3c34b8b4f1
.
breaks google3 see http://cl/223526995
PR Close #27375
2018-11-30 10:49:27 -08:00
Igor Minar
63e125986c
Revert "test(forms): add test on applying unicode flag ( #20819 )" ( #27375 )
...
This reverts commit 619b8ab822
.
breaks google3 see http://cl/223526995
PR Close #27375
2018-11-30 10:49:27 -08:00
Igor Minar
1439071b7e
Revert "docs(forms): take words suggestion ( #20819 )" ( #27375 )
...
This reverts commit e024f2f8b7
.
breaks google3 see http://cl/223526995
PR Close #27375
2018-11-30 10:49:27 -08:00
Brandon Roberts
c331fc6f0c
docs(forms): update API reference for common APIs and template-driven directives ( #27033 )
...
PR Close #27033
2018-11-29 21:33:07 -08:00
Igor Minar
e024f2f8b7
docs(forms): take words suggestion ( #20819 )
...
Co-Authored-By: JLHwung <JLHwung@users.noreply.github.com>
PR Close #20819
2018-11-29 21:19:37 -08:00
Huáng Jùnliàng
619b8ab822
test(forms): add test on applying unicode flag ( #20819 )
...
PR Close #20819
2018-11-29 21:19:37 -08:00
Huáng Jùnliàng
3c34b8b4f1
fix(forms): apply unicode flag to pattern attribute when supported ( #20819 )
...
Both Firefox and Chrome have applied unicode flag to the `pattern` content attribute of INPUT element.
See https://www.chromestatus.com/feature/4753420745441280
PR Close #20819
2018-11-29 21:19:37 -08:00
Miško Hevery
ca40565f9a
fix(ivy): hack implementation of host styles ( #27180 )
...
PR Close #27180
2018-11-20 11:43:29 -08:00
Nick Tobolski
975c269752
docs(forms): language correction ( #27177 )
...
Word missing from docs
PR Close #27177
2018-11-20 10:46:34 -08:00
Huáng Jùnliàng
34306c356e
docs(forms): close markdown backticks ( #27189 )
...
PR Close #27189
2018-11-20 10:45:16 -08:00
Kara Erickson
1810cdf2c3
fix(ivy): compiler should generate restoreView() for local refs in listeners ( #27034 )
...
PR Close #27034
2018-11-12 12:50:58 -08:00
Brandon Roberts
99c5db1fb1
docs(forms): update API reference for value accessors ( #26946 )
...
PR Close #26946
2018-11-12 12:48:33 -08:00
Kara Erickson
78b6f88cb3
fix(ivy): TestBed should use an NgZone ( #27015 )
...
PR Close #27015
2018-11-09 09:56:36 -08:00
Kara Erickson
552836ebf0
fix(ivy): merged host bindings functions should take superclass hostVars into account ( #27013 )
...
PR Close #27013
2018-11-09 09:55:47 -08:00
Kara Erickson
9e26216c40
fix(ivy): compiler should generate bindings to host attrs properly ( #26973 )
...
PR Close #26973
2018-11-07 11:09:31 -08:00
Kara Erickson
a4398aa17f
docs(forms): update description for FormBuilder.group ( #26970 )
...
PR Close #26970
2018-11-07 10:39:12 -08:00
Kara Erickson
3ca1a57f81
test(ivy): run forms tests with ivy on ci ( #26968 )
...
PR Close #26968
2018-11-06 15:09:35 -08:00
Brandon Roberts
099d1a67a0
docs(forms): update reactive form directives API reference ( #26823 )
...
PR Close #26823
2018-11-05 15:11:42 -08:00
Misko Hevery
7d2a746090
build: remove ivy JIT mode ( #26863 )
...
PR Close #26863
2018-11-02 15:44:05 -07:00
Lars Gyrup Brink Nielsen
e9e804fb02
feat(forms): add updateOn option to FormBuilder ( #24599 )
...
PR Close #24599
2018-11-01 15:31:11 -07:00
Igor Minar
ee0b857172
build: rename the ivy compile mode 'local' to 'aot' ( #26686 )
...
PR Close #26686
2018-10-23 14:14:49 -07:00
Igor Minar
4237c34c78
test(ivy): mark failing test targets with fixme-ivy-jit and fixme-ivy-local tags ( #26471 )
...
We are close enough to blacklist a few test targets, rather than whitelist targets to run...
Because bazel rules can be composed of other rules that don't inherit tags automatically,
I had to explicitly mark all of our ts_library and ng_module targes with "ivy-local" and
"ivy-jit" tags so that we can create a query that excludes all fixme- tagged targets even
if those targets are composed of other targets that don't inherit this tag.
This is the updated overview of ivy related bazel tags:
- ivy-only: target that builds or runs only under ivy
- fixme-ivy-jit: target that doesn't yet build or run under ivy with --compile=jit
- fixme-ivy-local: target that doesn't yet build or run under ivy with --compile=local
- no-ivy-jit: target that is not intended to build or run under ivy with --compile=jit
- no-ivy-local: target that is not intended to build or run under ivy with --compile=local
PR Close #26471
2018-10-23 08:57:42 -07:00
Pete Bacon Darwin
982bc7f2aa
docs: update forms with `@publicApi` tags ( #26595 )
...
PR Close #26595
2018-10-19 14:35:53 -07:00
Pete Bacon Darwin
24521f549c
docs: convert all `@experimental` tags to `@publicApi` tags ( #26595 )
...
PR Close #26595
2018-10-19 14:35:52 -07:00
Brandon Roberts
ebd01e8e79
docs: more form overview edits ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
Brandon Roberts
04dfca41f4
docs(forms): add package overview for forms ( #25663 )
...
PR Close #25663
2018-09-25 18:48:15 -07:00
Frederik Schlemmer
1e02cd9961
docs: Fixes typo in FormArray ( #26031 )
...
PR Close #26031
2018-09-24 09:14:07 -07:00
Pete Bacon Darwin
7d39bc68fb
docs(forms): move extended text to @usageNotes ( #26039 )
...
Headings are not allowed in the basic description block.
PR Close #26039
2018-09-24 09:11:02 -07:00
Pete Bacon Darwin
927323f24e
docs: add missing `@ngModule` tags ( #25734 )
...
PR Close #25734
2018-09-19 16:18:24 -07:00
Brandon Roberts
a9a81f91cf
docs(forms): update form apis based on review feedback ( #25724 )
...
PR Close #25724
2018-09-19 16:09:00 -07:00
Brandon Roberts
07c10e2844
docs(forms): update API reference for forms interfaces and abstract classes ( #25724 )
...
PR Close #25724
2018-09-19 16:09:00 -07:00
Judy Bogart
dd5e35ee67
docs: add ngmodule api doc ( #25618 )
...
PR Close #25618
2018-09-19 10:40:58 -07:00
Alex Eagle
cbbad1b791
refactor(ivy): pre-factor: set explicit type parameters for ModuleWithProviders ( #25970 )
...
Ivy depends on having the generic type token later when reading the ModuleWithProviders from a .d.ts file.
PR Close #25970
2018-09-18 13:28:44 -07:00
George Wilde
ddd3bf83c7
docs(forms): change documentation of the FormGroup patchValue method ( #25901 )
...
Improve the grammar of the description to make it more readable.
PR Close #25901
2018-09-18 13:08:05 -07:00
Greg Magolan
b99d7ed5bf
build(bazel): update to rules_typescript 0.17.0 & rules_nodejs 0.13.4 ( #25920 )
...
PR Close #25920
2018-09-18 13:05:38 -07:00
Brandon Roberts
abd29f5049
docs(forms): update API reference for reactive and template-driven forms modules ( #25687 )
...
PR Close #25687
2018-08-31 13:37:40 -07:00
Alan
3ba5220839
refactor(forms): `ngForm` element selector has been deprecated in favor of `ng-form` ( #23721 )
...
This has been deprecated to keep selector consistent with other core Angular selectors. As element selectors are in kebab-case.
Now deprecated:
```
<ngForm #myForm="ngForm">
```
After:
```
<ng-form #myForm="ngForm">
```
You can also choose to supress this warnings by providing a config for `FormsModule` during import:
```ts
imports: [
FormsModule.withConfig({warnOnDeprecatedNgFormSelector: 'never'});
]
Closes : #23678
PR Close #23721
2018-08-02 08:34:43 -07:00
denjamal
3f6fc00d73
docs(forms): fix incorrect variables naming in the comments ( #25150 )
...
PR Close #25150
2018-07-31 11:42:15 -07:00
Alex Rickabaugh
60aeee7abf
feat(ivy): selector side of ModuleWithProviders via type metadata ( #24862 )
...
Within an @NgModule it's common to include in the imports a call to
a ModuleWithProviders function, for example RouterModule.forRoot().
The old ngc compiler was able to handle this pattern because it had
global knowledge of metadata of not only the input compilation unit
but also all dependencies.
The ngtsc compiler for Ivy doesn't have this knowledge, so the
pattern of ModuleWithProviders functions is more difficult. ngtsc
must be able to determine which module is imported via the function
in order to expand the selector scope and properly tree-shake
directives and pipes.
This commit implements a solution to this problem, by adding a type
parameter to ModuleWithProviders through which the actual module
type can be passed between compilation units.
The provider side isn't a problem because the imports are always
copied directly to the ngInjectorDef.
PR Close #24862
2018-07-20 11:48:35 -07:00
Brandon Roberts
80a74b450a
docs(forms): update form builder API reference ( #24693 )
...
PR Close #24693
2018-07-12 16:38:26 -04:00
Alex Rickabaugh
02b5087685
build(ivy): enable ngtsc AOT builds for a few packages ( #24738 )
...
Turn on AOT builds using ngtsc for:
* animations
* common
* compiler
* compiler-cli
* forms
* platform-browser
PR Close #24738
2018-07-12 16:36:35 -04:00
Brandon Roberts
05e3e4d71e
docs(forms): update API reference for form validators ( #24734 )
...
PR Close #24734
2018-07-10 18:52:40 -07:00
Tyler Akins
81a9db2b0a
docs(forms): added missing backtick ( #24451 )
...
Fixed trivial markdown problem with a missing backtick.
PR Close #24451
2018-07-10 18:51:08 -07:00
George Kalpakas
787c54736c
test: run unit tests in random order ( #19904 )
...
PR Close #19904
2018-07-06 13:48:02 -07:00