Dan Bucholtz
92a5876f51
refactor(router): move activation to private method ( #22033 )
...
PR Close #22033
2018-02-12 10:00:36 -08:00
JiaLi.Passion
f791e9f081
fix(core): fix #20582 , don't need to wrap zone in location change listener ( #20640 )
...
PR Close #20640
2018-02-05 13:06:22 -08:00
vsavkin
c40ae7f7cf
feat(router): add navigationSource and restoredState to NavigationStart event ( #21728 )
...
Currently, NavigationStart there is no way to know if an navigation was triggered imperatively or via the location change. These two use cases should be handled differently for a variety of use cases (e.g., scroll position restoration). This PR adds a navigation source field and restored navigation id (passed to navigations triggered by a URL change).
PR Close #21728
2018-01-29 10:22:59 -08:00
Jason Aden
ede9cb7c2f
Revert: "feat(router): add navigationSource and restoredState to NavigationStart event ( #21728 )"
...
This reverts commit 3b7bab7d22
. Will be re-merged after fixing integration of minor breaking change.
2018-01-26 16:24:56 -08:00
Patrick Shields
d964491f2a
fix(router): remove @internal tag on ParamInheritanceType ( #21773 )
...
This is a more defensive approach to ensure that references to
ParamInheritanceType from the published declarations do not cause
compilation errors when compiling Angular from the published packages.
Fixes #21456
PR Close #21773
2018-01-26 10:28:33 -08:00
vsavkin
3b7bab7d22
feat(router): add navigationSource and restoredState to NavigationStart event ( #21728 )
...
Currently, NavigationStart there is no way to know if an navigation was triggered imperatively or via the location change. These two use cases should be handled differently for a variety of use cases (e.g., scroll position restoration). This PR adds a navigation source field and restored navigation id (passed to navigations triggered by a URL change).
PR Close #21728
2018-01-26 10:25:32 -08:00
Patrick Shields
925e654a29
fix(router): don't use ParamsInheritanceStrategy in declarations ( #21574 )
...
ParamsInheritanceStrategy is internal, so any references to it from the
published .d.ts files will fail.
Fixes #21456 .
PR Close #21574
2018-01-23 21:34:37 -08:00
Alex Eagle
a1492a73ce
build: Remove angular_src nested workspace ( #21096 )
...
PR Close #21096
2018-01-19 10:17:37 -08:00
Alex Eagle
c4f02e21dd
build: move repeated tsconfig attributes to a macro ( #20964 )
...
This helps ensure we use the same tsconfig.json file for all compilations.
Next steps are to make it the same tsconfig.json file used by the editor
PR Close #20964
2018-01-10 12:30:19 -08:00
courtneypattison
a76ab1f42a
docs(router): remove extra brackets ( #21294 )
...
PR Close #21294
2018-01-10 12:20:16 -08:00
Jason Aden
b5934fc582
docs(router): fix missing export in docs for UrlMatcher ( #21095 )
...
Fixes #21042
PR Close #21095
2018-01-04 17:48:32 -05:00
Siyao Li
2402224b4e
docs(common): update copyright years ( #21232 )
...
PR Close #21232
2018-01-04 17:45:36 -05:00
Miško Hevery
ae97920fe2
build: move _testing_init into tools; limit web_test concurrency ( #21053 )
...
PR Close #21053
2017-12-22 13:10:51 -08:00
Misko Hevery
40dfe39e64
build(router): enable bazel tests for router ( #21053 )
...
Bazel runs on newer version of RxJs than is installed in Yarn. The never version subclasses `EmptyError` in a different way which fails the `instanceof` check. This change makes the `instanceof` check more robust with respect to `EmptyError`.
PR Close #21053
2017-12-22 13:10:51 -08:00
Misko Hevery
3d50fd7cac
build: add bazel test rules for remainder of packages ( #21053 )
...
PR Close #21053
2017-12-22 13:10:51 -08:00
Jason Aden
5ba1cf1063
fix(router): fix wildcard route with lazy loaded module (again) ( #18139 )
...
Closes #13848
Description:
We doesn't handle children of wildcard route properly link. It's always an empty array.
Created from #13851
PR Close #18139
2017-12-22 09:20:11 -08:00
Zaven Muradyan
5efea2f6a0
feat(router): add "paramsInheritanceStrategy" router configuration option
...
Previously, the router would merge path and matrix params, as well as
data/resolve, with special rules (only merging down when the route has
an empty path, or is component-less). This change adds an extra option
"paramsInheritanceStrategy" which, when set to 'always', makes child
routes unconditionally inherit params from parent routes.
Closes #20572 .
2017-12-20 10:06:24 -08:00
Alex Rickabaugh
e4c53f8529
Revert "feat(router): add a function set up router sync when used with downgradeModule"
...
This reverts commit f5bb999319
. The commit
does not include proper tests.
2017-12-20 09:15:15 -08:00
Alex Rickabaugh
b61e3e9d20
Revert "fix(router): replaceURL when reacting to a change coming from angularjs"
...
This reverts commit 0b2d636b75
. The commit
does not include proper tests.
2017-12-20 09:14:27 -08:00
vsavkin
0b2d636b75
fix(router): replaceURL when reacting to a change coming from angularjs
...
Closes : #20549
2017-12-15 07:59:56 -08:00
vsavkin
f5bb999319
feat(router): add a function set up router sync when used with downgradeModule
2017-12-15 07:59:56 -08:00
Yuan Gao
e544742156
refactor(core): Removed readonly getters and changed to readonly ( #19842 )
...
variables
PR Close #19842
2017-12-08 10:24:19 -08:00
vsavkin
d8cc09b76c
fix(router): NavigatonError and NavigationCancel should be emitted after resetting the URL ( #20803 )
...
PR Close #20803
2017-12-07 13:34:20 -08:00
Alex Eagle
ef534c0cc1
build: upgrade bazel rules to latest ( #20768 )
...
Add enough BUILD files to make it possible to
`bazel build packages/core/test`
Also re-format BUILD.bazel files with Buildifier.
Add a CI lint check that they stay formatted.
PR Close #20768
2017-12-07 11:27:50 -08:00
Alex Eagle
5ec1717c58
fix: Update test code to type-check under TS 2.5 ( #20175 )
...
PR Close #20175
2017-11-15 18:12:16 -06:00
Mark Kennedy
a622e19df6
fix(router): 'merge' queryParamHandling strategy should be able to remove query params ( #19733 )
...
Closes #18463 , #17202
PR Close #19733
2017-11-14 11:01:04 -08:00
George Kalpakas
901436e46f
docs: fix link texts
...
Fixes #19701
PR Close #19709
2017-11-01 15:44:59 -04:00
Hans Larsen
13f8648a00
fix: add missing globals from each rollup configuration ( #20028 )
...
PR Close #20028
2017-10-30 23:09:17 -04:00
Hans Larsen
b6abcb2500
refactor: make all rollup config ES5 compatible ( #20028 )
...
So they can be required by other Node scripts.
PR Close #20028
2017-10-30 23:09:17 -04:00
vsavkin
d3211a2468
feat(router): add "onSameUrlNavigation" router configuration option ( #19463 )
...
PR Close #19463
2017-10-23 20:56:53 -04:00
vsavkin
adab4f3e49
fix(router): do not call `location.go` when skipping a navigation ( #19463 )
...
Closes #18036
PR Close #19463
2017-10-23 20:56:52 -04:00
vsavkin
82fed62af2
fix(router): navigating to the current location works ( #19463 )
...
Closes #13340
PR Close #19463
2017-10-23 20:56:52 -04:00
vsavkin
6f2939da62
fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )
...
Closes #18983
PR Close #19449
2017-10-18 11:17:55 -07:00
Jason Aden
7d1abd9adb
build: update to rxjs@5.5.0 ( #19345 )
...
PR Close #19345
2017-10-18 11:17:43 -07:00
Tobias Bosch
b0c7ea8181
Revert "fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )"
...
This reverts commit c569b75249
.
As it was synched together with 5a9ed2de27
which broke an internal test.
2017-10-18 09:58:41 -07:00
vsavkin
c569b75249
fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )
...
Closes #18983
PR Close #19449
2017-10-17 20:57:30 -07:00
Chuck Jazdzewski
d7eac7ee56
Revert "fix(router): navigating to the current location works ( #19463 )"
...
This reverts commit 43c5b638b9
.
2017-10-09 16:38:12 -07:00
Chuck Jazdzewski
d53b96f2a2
Revert "fix(router): do not call `location.go` when skipping a navigation ( #19463 )"
...
This reverts commit 6651541230
.
2017-10-09 16:37:31 -07:00
vsavkin
6651541230
fix(router): do not call `location.go` when skipping a navigation ( #19463 )
...
Closes #18036
PR Close #19463
2017-10-09 11:45:13 -07:00
vsavkin
43c5b638b9
fix(router): navigating to the current location works ( #19463 )
...
Closes #13340
PR Close #19463
2017-10-09 11:45:13 -07:00
Chuck Jazdzewski
8e5b582b61
Revert "fix(router): navigating to the current location works ( #19463 )"
...
This reverts commit b67d574a95
.
2017-10-06 18:15:19 -07:00
Chuck Jazdzewski
0cc87c5ba1
Revert "fix(router): do not call `location.go` when skipping a navigation ( #19463 )"
...
This reverts commit fdfa31798b
.
2017-10-06 18:15:16 -07:00
vsavkin
fdfa31798b
fix(router): do not call `location.go` when skipping a navigation ( #19463 )
...
Closes #18036
PR Close #19463
2017-10-06 15:35:25 -07:00
vsavkin
b67d574a95
fix(router): navigating to the current location works ( #19463 )
...
Closes #13340
PR Close #19463
2017-10-06 15:35:24 -07:00
Victor Berchet
6a9ce67714
Revert "refactor(core): Removed readonly getters and changed to readonly ( #19225 )"
...
This reverts commit 2b84b86fc0
.
2017-09-28 13:36:44 -07:00
Victor Savkin
a9d32a3f89
fix(router): resolve and guards should be able to reject with null and undefined ( #19418 )
...
Closes #17148
2017-09-28 11:06:08 -07:00
tinayuangao
2b84b86fc0
refactor(core): Removed readonly getters and changed to readonly ( #19225 )
...
variables
2017-09-28 09:36:29 -07:00
Alex Eagle
82e49230ff
build: Give names to the AMD modules nested in Angular UMD distro ( #19425 )
2017-09-28 09:29:22 -07:00
Olivier Combe
0f5c70d563
build: update npm dependencies ( #19328 )
...
PR Close #19328
2017-09-22 13:20:52 -07:00
Chuck Jazdzewski
f96142cd7c
build: remove references to `tsc-wrapped` ( #19298 )
...
With this commit `ngc` is used instead of `tsc-wrapped` for
collecting metadata and tsickle rewriting and `tsc-wrapped`
is removed from the repository.
`@angular/tsc-wrapped@5` is now deprecated and is no longer
used, updated, or maintained as part as of Angular 5.x.x.
`@angular/tsc-wrapped@4` is still maintained and required by
Angular 4.x.x and will be maintained as long as 4.x.x is in
LTS.
PR Close #19298
2017-09-21 13:55:52 -07:00