Commit Graph

48 Commits

Author SHA1 Message Date
Kapunahele Wong c88305d2eb docs: add Injectable migration docs (#32581)
PR Close #32581
2019-10-11 15:46:12 -07:00
Kapunahele Wong 206fb82330 docs: add dynamic queries flag migration documentation (#32582)
PR Close #32582
2019-10-01 17:19:05 -07:00
Joey Perrott be13e8b1e4 ci: update owners for /tools/size-tracking (#32615)
PR Close #32615
2019-09-13 13:23:07 -07:00
George Kalpakas 082b0d3ef8 ci: add @josephperrott to global approvers in `CODEOWNERS` (#32667)
This change aims to align the documented members in `CODEOWNERS` with
the actual members of the secret `framework-global-approvers` GitHub
team.

PR Close #32667
2019-09-13 08:55:56 -07:00
Kapunahele Wong bd679581e2 docs: add undecorated classes migration faq (#32478)
PR Close #32478
2019-09-12 12:16:14 -07:00
Kapunahele Wong 222af38462 docs: move renderer2 deprecation guide into own file (#32626)
PR Close #32626
2019-09-12 10:42:59 -07:00
George Kalpakas 5356826a38 ci: update codeowners to reflect GitHub team members (#32569)
PR Close #32569
2019-09-11 20:26:28 -04:00
George Kalpakas 6ccb4e0bab ci: add missing code-owners (#32577)
PR Close #32577
2019-09-10 17:30:55 -04:00
Pete Bacon Darwin 544eb89198 ci: update i18n CODEOWNERS for @angular/localize package (#32570)
PR Close #32570
2019-09-10 13:09:12 -04:00
George Kalpakas 60f963986f ci: update codeowners for docs guides/examples/images (#32360)
Based on the output of `node aio\scripts\verify-docs-codeownership`, the
following guides still have no owners:

- accessibility.md
- angular-compiler-options.md
- aot-metadata-errors.md
- bazel.md
- cli-builder.md
- static-query-migration.md

PR Close #32360
2019-08-30 12:48:24 -07:00
Joey Perrott 375897801b fix: update all files/directories owned by DevInfra to new DevInfra Framework team alias (#32247)
PR Close #32247
2019-08-29 12:36:18 -07:00
jenniferfell 10ea3a9f4d docs: change to global approvers (#31940)
PR Close #31940
2019-08-20 16:47:16 -07:00
Kara Erickson 388578fec9 Revert "ci: remove material-unit-tests failure blocklist (#32138)" (#32226)
This reverts commit 0660903784 so we
can add some tests to the blocklist.

PR Close #32226
2019-08-20 16:39:54 -07:00
Paul Gschwendtner 0660903784 ci: remove material-unit-tests failure blocklist (#32138)
Initially when the `material-unit-tests` job got wired up,
Ivy was not really backwards-compatible and a few bugs caused
test failures when running the Angular Material test suites w/ Ivy.

These bugs got fixed progressively and eventually the test
blocklist became empty. At this point we don't want to regress
in the future and the blocklist should never have new items.

Additionally since we switched the unit-tests job to run against
Angular Material `master` with Bazel, the blocklist is no
longer respected. Therefore we can safely remove the blocklist.

PR Close #32138
2019-08-14 12:02:12 -07:00
Joey Perrott fd6ed1713d ci: remove codefresh config and supporting files (#32058)
PR Close #32058
2019-08-09 10:53:20 -07:00
George Kalpakas 3846192bde ci: add owners for zone.js to CODEOWNERS (#31203)
Follow-up to #30962.

PR Close #31203
2019-06-25 11:20:01 -07:00
George Kalpakas a4fc98cace ci: add josephperrott to `dev-infra` owners (#31205)
PR Close #31205
2019-06-21 15:29:09 -07:00
Kara Erickson 7a53b9090e ci: add jasonaden to forms owners (#31117)
PR Close #31117
2019-06-18 13:58:29 -07:00
Kapunahele Wong e76690be29 docs: edit codeowners for new Template Syntax examples (#31060)
PR Close #31060
2019-06-14 11:54:29 -07:00
Kapunahele Wong bb4e230eae docs: rewrite binding-syntax section in template-syntax.md (#25561)
PR Close #25561
2019-06-14 10:25:06 -07:00
Trotyl Yu fa354888b1 ci: add reviewer group for deprecations guide (#30722)
PR Close #30722
2019-05-30 20:45:58 -07:00
Brandon c9f5f3d802 docs: add section to upgrade guide on lazy loading AngularJS (#30541)
PR Close #30541
2019-05-21 13:06:01 -07:00
George Kalpakas f78bda9ff0 build: add recommended config files for VSCode remote development (#30450)
Add some recommended config files to use (as is or as basis) for setting
up [remote development using docker containers][1] with VSCode. This is
an opt-in feature. See `.devcontainer/README.md` for more info.

The configuration can be further tweaked/improved, but is a good
starting point.

[1]: https://code.visualstudio.com/docs/remote/containers

PR Close #30450
2019-05-20 10:13:53 -07:00
Jason Aden 04a9f28c3d build: add jasonaden to angular/upgrade in CODEOWNERS (#30307)
PR Close #30307
2019-05-08 09:20:24 -07:00
jenniferfell e720675f8b docs(docs-infra): add jennifer to fw-docs-intro codeowners, add codeowners for schematics docs (#28992)
PR Close #28992
2019-04-24 17:12:05 -07:00
George Kalpakas 6c88eb7477 ci: add `aio/content/examples/*` to `docs-infra` group (#30087)
This directory contains some top-level files (`.gitignore`,
`tsconfig.json`, `tslint.json`) that are related to the examples
infrastructure (building, linting, etc.).

They had previously no owner; now they are owned by the `docs-infra`
group.

PR Close #30087
2019-04-24 10:50:01 -07:00
George Kalpakas c5799491e7 ci: fix CODEOWNERS for ngcc (#29660)
With a770aa231, ngcc was moved to a different directory
(`compiler/src/ngcc/` --> `compiler/ngcc/`), but the `CODEOWNERS` file
was not updated to reflect that.
PR Close #29660
2019-04-02 15:57:36 -07:00
Filipe Silva 8bfaaf164a docs: add Web Worker guide (#29633)
Followup to https://github.com/angular/angular-cli/pull/13700

PR Close #29633
2019-04-01 15:31:47 -07:00
George Kalpakas 717aa7c6e4 docs: update CODEOWNERS with missing or removed guides/examples (#29612)
PR Close #29612
2019-04-01 11:52:23 -07:00
Brandon 12c9bd257d docs: add new getting started guide (#27684)
PR Close #27684
2019-03-29 10:47:37 -07:00
George Kalpakas 6a66af7a27 ci: add `packages/examples/common/` to `fw-core` (#29533)
PR Close #29533
2019-03-27 13:44:02 -07:00
George Kalpakas 9bcc1e8dce ci: add `.codefresh/` to the `fw-dev-infra` group (#29478)
PR Close #29478
2019-03-22 13:16:16 -07:00
George Kalpakas 0d0445063a ci: add devversion to fw-dev-infra (#29418)
PR Close #29418
2019-03-20 13:44:30 -04:00
Alex Eagle ddfdf3cd26 docs: add alexeagle to @angular/fw-global-approvers (#29287)
This is for large-scale refactorings

PR Close #29287
2019-03-20 13:43:23 -04:00
George Kalpakas e9fab63385 ci: add `.vscode/**` to the `@angular/fw-dev-infra` group (#29302)
PR Close #29302
2019-03-19 02:46:34 -04:00
George Kalpakas ad9415af1d docs: remove unused examples and images (#28597)
PR Close #28597
2019-03-07 13:24:01 -08:00
George Kalpakas 4f2773eaef docs: add missing guides, examples, images to CODEOWNERS (#28597)
PR Close #28597
2019-03-07 13:24:01 -08:00
Kara Erickson 0bc26fc4e8 ci: remove dev-infra as owner on material-ci folder (#28990)
Currently, whenever someone on fw-core approvals list approves a change
to the angular_material_blocklist.js file, it is not sufficient because
dev-infra is also requested as a mandatory reviewer. This does not make
sense because this folder only contains the list of ignored tests and
not anything dev-infra related.

Previously, we tried to fix this by creating a "Material CI" section
underneath the existing "Build & CI" section, so that the "Material CI"
rule would override the rule matching the entire "tools" folder.
Unfortunately, this did not work. This commit attempts to resolve the
problem by explicitly marking all sub-folders in the "tools" folder
as owned by dev-infra (leaving out "material-ci"), so "material-ci"
is only referenced by the rule assigning fw-core as code owners.

PR Close #28990
2019-02-28 14:19:59 -08:00
Filipe Silva 90b304612e ci: add gkalpak and filipesilva to fw-dev-infra (#28807)
PR Close #28807
2019-02-19 12:31:28 -08:00
Igor Minar caefc5d4c4 ci: add /aio/content/images/bios/** to @angular/fw-docs-marketing group (#28835)
we previously missed it.

PR Close #28835
2019-02-19 12:30:37 -08:00
Igor Minar 04a1923af7 ci: add /packages/* to the @angular/fw-dev-infra CODEOWNERS group (#28745)
It was previously missing which is a bug.

PR Close #28745
2019-02-16 20:58:47 -08:00
Kara Erickson 8edd9cd6c0 ci: move material-ci blocklist into core approval group (#28531)
PR Close #28531
2019-02-05 14:24:22 -05:00
Minko Gechev 7a22019b3d ci: add mgechev to tools & tools-bazel codeowners (#28384)
PR Close #28384
2019-02-04 03:31:28 -08:00
Igor Minar 76580b98f0 ci: add brandonroberts to @angular/docs-infra codeowners (#28023)
Brandon is joining the docs-infra team in addition to the docs team.

PR Close #28023
2019-01-09 11:50:40 -08:00
Igor Minar 3fba6eff79 ci: fix public api rule in codeowners (#27999)
@alxhub spotted that the public api rule in codeowners is being overriden by the Build & CI Owners rule.

swapping the two sections fixes the problem.

PR Close #27999
2019-01-08 15:56:13 -08:00
Igor Minar 654055b22f ci: add brandonroberts to @angular/framework-global-approvers-for-docs-only-changes (#27949)
I’ve observed that Brandon reviews many docs-only PRs and then we still need me or Jeniffer to approve them.

In most cases, Brandon is perfectly qualified to approve these, so I’m proposing that Brandon is added to the framework-global-approvers-for-docs-only-changes group.

PR Close #27949
2019-01-07 08:35:22 -08:00
Kara Erickson 4c9aff5695 ci: fix typos in codeowners file (#27945)
PR Close #27945
2019-01-05 17:46:27 -08:00
Igor Minar 224d78765f ci: replace our pullapprove setup with GitHub CODEOWNERS (#27690)
Summary of changes:
- created .github/CODEOWNERS with docs and config similar to the one in .pullapprove.yml
- updated docs
- updated .github/angular-robot.yml to not expect pullapprove status
- removed .pullapprove.yml

The primary motivations behind this change are:
- CODEOWNERS didn't exist when we introduced pullapprove
- CODEOWNERS is a functionality tightly integrated with github which results in better DX
- pullapprove v2 has been very unstable recently causing productivity loss
- pullapprove v2 has been deprecated in favor of v3, which requires and migration

PR Close #27690
2019-01-05 17:39:00 -08:00