2264 Commits

Author SHA1 Message Date
WilliamKoza
f7c551e16b fix(docs-infra): upgrade codelyzer to 4.5.0 ()
PR Close 
2019-01-28 11:51:56 -08:00
George Kalpakas
7496630a94 test(docs-infra): increase timeout for redirection tests more ()
Occasionally, external URLs take even longer than the previously set 60s
to load, which causes CI flakes.

PR Close 
2019-01-25 12:51:36 -08:00
George Kalpakas
6e949f9e98 test(docs-infra): unregister the SW after each test ()
This ensures that the SW is cleaned up, even in cases where
synchronization is disabled (and thus the clean-up inside `goTo()`
happens without waiting for Angular).

PR Close 
2019-01-25 12:51:36 -08:00
George Kalpakas
6ad1c47df8 test(docs-infra): unregister the SW after waitForAngular() ()
This increases the chances that the clean-up will take place _after_ the
SW has been registered.

PR Close 
2019-01-25 12:51:36 -08:00
George Kalpakas
76144f156c test(docs-infra): properly report errors if page.init() fails/rejects ()
For asynchronous callbacks, this can be done either by calling
`done.fail()` or by returning the promise directly (without requesting a
`done` callback). (Using the latter, because it is shorter.)

PR Close 
2019-01-25 12:51:36 -08:00
WilliamKoza
e2c98fbe11 fix(docs-infra): change the key used to find out the cli section ()
PR Close 
2019-01-24 15:41:44 -08:00
Carlos Schneider
02975e9166 docs(docs-infra): show top menu at 992px screen width ()
Show top menu at 992px screen width. The JS expression was checking just for screen widths
strictly greater than 992px to show the menu, while the CSS media query was showing the hamburger
icon just for screen widths strictly smaller than 992px, so there was a gap of 1px that the user
could't navigate through the top menu.

closes 

PR Close 
2019-01-24 10:26:54 -08:00
WilliamKoza
3414316fc8 feat(docs-infra): saves the scroll position before the change of location ()
Issue , 

PR Close 
2019-01-24 10:24:43 -08:00
George Kalpakas
67a41d8bff fix(docs-infra): align property names to the top ()
This looks better when the property descriptions span multiple lines;
especially when scrolling to a specific property (e.g.
[AbstractControl#status][1]).

[1]: https://next.angular.io/api/forms/AbstractControl#status

PR Close 
2019-01-24 10:24:03 -08:00
George Kalpakas
e50c5293fc refactor(docs-infra): remove unused CSS style rule ()
The `.properties-table` selector does not match any element and the
styles don't look relevant for the similarly named `.property-table`
class.

PR Close 
2019-01-24 10:24:03 -08:00
Dario Braun
056d35c97c docs: fix typo and add parenthesis to method in HTTP tutorial ()
Merge remote-tracking branch 'origin/TOH' into TOH


PR Close 
2019-01-24 10:23:25 -08:00
Daniel Ruf
583061d043 refactor: remove unused parameter in _main method invocation ()
PR Close 
2019-01-23 10:58:38 -08:00
Kapunahele Wong
75074d009f docs: rewrite event binding section and add example ()
PR Close 
2019-01-22 11:31:41 -08:00
Giorgos Bamparopoulos
197676a6dd docs: rename "internal" access modifier to "protected" ()
PR Close 
2019-01-22 11:20:26 -08:00
Luiz Machado
1fb6731285 docs: fix crisis-detail milestone files ()
Crisis Detail's template was being added two times and the component's TS none.
PR Close 
2019-01-22 11:19:51 -08:00
Hamza TEI
1df8be5573 docs: update link to post on redirects in router guide ()
Change victor savkin's url post on redirects to:
http://vsavkin.tumblr.com/post/146722301646/angular-router-empty-paths-componentless-routes

PR Close 
2019-01-22 11:17:18 -08:00
ericksoen
6324ad45e7 docs: correct minor typo ()
PR Close 
2019-01-22 10:19:05 -08:00
Stepan Suvorov
7439b46c5a docs: fix explanation of Injectable decorator in architecture guide ()
PR Close 
2019-01-22 10:18:05 -08:00
WilliamKoza
351ef2a6de fix(docs-infra): removal of the use of the ChildNode.remove() method that it isn't supported by IE ()
fixes 

PR Close 
2019-01-22 09:48:19 -08:00
Tomas Veras
6bd20e8b2f docs: add missing type when handling errors in hero service. ()
PR Close 
2019-01-22 09:43:43 -08:00
Kayce Basques
366a6bf192 docs: make the styles section less ambiguous ()
PR Close 
2019-01-22 09:42:51 -08:00
WilliamKoza
5b08a880f7 style(docs-infra): Active tslint rule semicolon ()
PR Close 
2019-01-22 09:38:44 -08:00
George Kalpakas
7db035842d build(docs-infra): upgrade cli command docs sources to fd4e960d6 ()
Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master).
Relevant changes in [commit range](4ae713b5a...fd4e960d6):

**Modified**
- help/generate.json
- help/new.json

Closes 

PR Close 
2019-01-22 09:38:12 -08:00
George Kalpakas
a0cdefb5fb ci(docs-infra): do not automatically post preview comments on PRs for team ()
Right now, we post such comments whenever a file has been touched that
could potentially have affected the docs. Since the API docs are built
from comments in the source code, almost all non-docs changes are
generating such preview comments, even though most of the time they are
irrelevant to the author and create unnecessary noise on the PR
(especially for actively worked-on PRs).

This commit removes the `team` GitHub team from the list of teams whose
members will automatically get preview comments.
(Adding the `aio: preview` label would still work on any PR.)

Jira: FW-967

PR Close 
2019-01-17 14:11:42 -08:00
Kapunahele Wong
8a08ff1571 docs: fix comments in services example ()
PR Close 
2019-01-16 17:38:23 -08:00
WilliamKoza
50cf2ac6d8 fix(docs-infra): improve a11y ()
Issue 

PR Close 
2019-01-16 17:37:45 -08:00
George Kalpakas
47665c9937 build(docs-infra): upgrade cli command docs sources to 4ae713b5a ()
Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master).
Relevant changes in [commit range](71e72ecdb...4ae713b5a):

**Modified**
- help/build.json
- help/generate.json

PR Close 
2019-01-16 09:46:03 -08:00
krzysztof-grzybek
cfb41452ce docs: update testing doc example style for HostListener ()
HostListener is preferred over host metadata by official style guide

PR Close 
2019-01-14 17:04:46 -08:00
Malgosia
857fcfe048 docs: ng config link fix ()
Fixed 'ng config' link to lead to proper CLI command site
PR Close 
2019-01-14 10:47:05 -08:00
George Kalpakas
60fb27c4ab build(docs-infra): upgrade cli command docs sources to 71e72ecdb ()
Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master).
Relevant changes in [commit range](02d2ec250...71e72ecdb):

**Modified**
- help/generate.json
- help/new.json

PR Close 
2019-01-14 10:46:23 -08:00
WilliamKoza
4c0104c846 fix(docs-infra): Add crossed through styling ()
PR Close 
2019-01-14 10:45:46 -08:00
WilliamKoza
72f2428cd8 fix(docs-infra): change style of deprecated markers ()
PR Close 
2019-01-14 10:45:46 -08:00
WilliamKoza
d577b8df75 fix(docs-infra): render deprecated markers for CLI command options ()
fixes 
fixes 

PR Close 
2019-01-14 10:45:46 -08:00
javatutorials2016
2c9f0139a3 docs: fix typo in singleton services guide ()
PR Close 
2019-01-14 10:41:30 -08:00
Shivam_Vyas
1ec01d6758 docs: change in(what should I import? answer) NgModule FAQs ()
I think only should be after BrowserModule , because we can import more than BrowserModule and I think we need to import other modules to AppModule in most of cases and we should import BrowserModule only in AppModule,so that thing seems okay.

PR Close 
2019-01-14 10:39:03 -08:00
Ashinze Ekene
4bb5f638bc docs: fix typo in dependency injection guide ()
~~`HeroService` must provided in some parent injector~~
*`HeroService` must be provided in some parent injector*

PR Close 
2019-01-14 10:38:05 -08:00
Brad Brandhorst
0897ebac9e docs: fix typo in docs.md ()
Added a period to the end of the last sentence in the first paragraph
PR Close 
2019-01-14 10:37:21 -08:00
coultonluke
d6aca79410 docs: updates to minor spelling mistakes in pipes guide ()
PR Close 
2019-01-14 10:34:17 -08:00
Brandon Roberts
e4c899e4ba docs: add browser polyfills for IE11 with hash-based routing ()
Closes 

PR Close 
2019-01-14 10:33:23 -08:00
Sasidhar Vanga
5e6e96d844 docs: fix GitHub pages deployment command ()
closes 
PR Close 
2019-01-14 10:32:31 -08:00
Steve Dignan
9c2f6d72d6 docs: minor wording change in code example comment ()
PR Close 
2019-01-14 10:31:23 -08:00
Courtney Pattison
638375b7ca docs: fix typo in testing guide ()
PR Close 
2019-01-14 10:30:33 -08:00
cyraid
c5b67b95b7 docs: update link in universal guide ()
Link to the document "53 percent of mobile site visits" was changed, updated link. Old link led to a page that didn't have the statistics on it.

PR Close 
2019-01-14 10:12:52 -08:00
Alan Agius
78bc21c63a docs: fix scripts section and some minor issues in universal documentation ()
PR Close 
2019-01-14 10:11:08 -08:00
George Kalpakas
48a03fcc80 test(docs-infra): increase timeout for all redirection tests ()
Occasionally, URLs take longer to load, which causes CI flakes.
In , the timeout for external URLs was increased, but internal
URLs turned out to be affected as well.

PR Close 
2019-01-14 10:04:58 -08:00
Judy Bogart
e082fc24b2 docs: add library doc to guides in aio ()
PR Close 
2019-01-11 16:22:19 -08:00
Pete Bacon Darwin
cd51775390 build(docs-infra): render @see information in members ()
Previously `@see` tags were only rendered for top level class-like
docs. Now these tags are rendered for methods and properties too.

PR Close 
2019-01-11 14:35:23 -08:00
George Kalpakas
8c3f98fdbb docs(service-worker): fix example of manually checking for updates ()
Poll for updates in a way that does not prevent the SW from being
registered. Discussed in https://github.com/angular/angular/pull/27332#pullrequestreview-179504620.

PR Close 
2019-01-11 11:17:18 -08:00
George Kalpakas
89a39bb22a style(service-worker): fix code formatting in service-worker-getting-started example ()
PR Close 
2019-01-11 11:17:18 -08:00
George Kalpakas
12f509c218 docs(service-worker): fix the service-worker-getting-started docs example ()
Changes:
- Change the project type to `service-worker`, so that it gets
  appropriate `package.json` (with `@angular/service-worker` dependency)
  and `angular.json` (with `serviceWorker: true` in production config).
- Move `ngsw-config.json` to the correct directory.
- Specify custom test commands for aio's `yarn example-e2e` to also
  verify that the ServiceWorker bits are set up correctly.

PR Close 
2019-01-11 11:17:18 -08:00