Commit Graph

12 Commits

Author SHA1 Message Date
Alex Rickabaugh 2d1347b2ce Revert "refactor: remove checked-in locale files ()" ()
This reverts commit 5822771946.

PR Close 
2021-06-16 09:49:38 -07:00
Paul Gschwendtner 5822771946 refactor: remove checked-in locale files ()
This is a pre-refactor commit allowing us to move
the CLDR locale generation to Bazel where files would
no longer be checked-in, except for the `closure-locale`
file that is synced into Google3.

PR Close 
2021-06-14 09:59:46 -07:00
Jessica Janiuk 66f49c2497 Revert "refactor: remove checked-in locale files" ()
This reverts commit 3a83ec8020f96c293fdc316854e199281d329111.

PR Close 
2021-06-08 10:06:24 -07:00
Paul Gschwendtner 9421bcd978 refactor: remove checked-in locale files ()
This is a pre-refactor commit allowing us to move
the CLDR locale generation to Bazel where files would
no longer be checked-in, except for the `closure-locale`
file that is synced into Google3.

PR Close 
2021-06-07 15:34:38 -07:00
Joey Perrott 1bc807c81a style(common): enforce format on newly included files ()
Historically files to be formatted were added to a listing (via matchers)
to be included in formatting.  Instead, this change begins efforts to
instead include all files in format enforcement, relying instead on an
opt out methodology.

PR Close 
2020-06-12 15:06:41 -07:00
Joey Perrott d1ea1f4c7f build: update license headers to reference Google LLC ()
Update the license headers throughout the repository to reference Google LLC
rather than Google Inc, for the required license headers.

PR Close 
2020-05-26 14:26:58 -04:00
Misko Hevery cb6ddfc215 Revert "fix(common): `locales/global/*.js` are not ES5 compliant ()" ()
This reverts commit 078b0be4dc.

The original commit was a work around for a bug in CLI. That bug was fixed in the CLI, as a result this change is no longer needed and is being reverted.

PR Close 
2020-05-12 13:11:57 -07:00
Terence D. Honles 078b0be4dc fix(common): `locales/global/*.js` are not ES5 compliant ()
Although this code has been part of Angular 9.x I only noticed this
error when upgrading to Angular 9.1.x because historically the source
locale data was not injected when localizing, but as of
angular/angular-cli#16394 (9.1.0) it is now included. This tipped me off
that my other bundles were not being built properly, and this change
allows me to build a valid ES5 bundle (I have also added a verification
step to my build pipeline to alert me if this error appears again in any
of my bundles).

I found the `locales/global/*.js` file paths being referenced by the
`I18nOptions` in
@angular-devkit/build-angular/src/utils/i18n-options.ts,
and following that it looks like it is actually loaded and used in
@angular-devkit/build-angular/src/utils/process-bundle.ts. I saw the
function `terserMangle` does appear that it is likely aware of the build
being ES5, but I'm not sure why this is not producing a valid ES5
bundle.

This change updates `tools/gulp-tasks/cldr/extract.js` to produce ES5
compliant `locales/global/*.js` and that fixes my issue. However, I am
not sure if @angular-devkit/build-angular should be modified to produce
a valid ES5 bundle instead or if the files could be TypeScript rather
than JavaScript files.

A test that a valid ES5 bundle is produced would be helpful, and I hope
this is reproducible and not some issue with my config.

PR Close 
2020-04-09 11:30:32 -07:00
Pete Bacon Darwin 2f31ceca47 refactor: update locales with extracted currency codes ()
The locale data extraction has been modified to include the default
currency code in the generated locale data. This commit updates these
generated files accordingly.

PR Close 
2020-01-13 09:57:06 -08:00
Feliks Khantsis 15d3e741e9 feat: update the locale files ()
PR Close 
2019-12-03 15:58:09 -08:00
Pete Bacon Darwin 2f0b8bc541 build(common): generate correct "global" locale files ()
PR Close 
2019-11-12 11:39:19 -08:00
Pete Bacon Darwin cd6ab209b6 build: generate global locale files ()
This commit contains the global locale files generated by the change to
the CLDR `extract.js` tool, from the previous commit.

PR Close 
2019-11-05 17:26:59 +00:00