Commit Graph

35 Commits

Author SHA1 Message Date
Kristiyan Kostadinov 842d615928 test(ivy): update root causes for chip list (#29081)
Updates the remaining unknown root causes for `MatChipList`.

This PR resolves FW-1125.

PR Close #29081
2019-03-04 10:08:28 -08:00
Kristiyan Kostadinov a352b73962 test(ivy): update root causes for drag drop (#29080)
Updates the root causes for the failures in `CdkDrag`.

This PR resolves FW-1115.

PR Close #29080
2019-03-04 10:07:55 -08:00
Kristiyan Kostadinov fa82d2d6f1 test(ivy): update root causes for tooltip (#29075)
Updates the root causes for the MatTooltip failures.

These changes resolve FW-1129.

PR Close #29075
2019-03-04 10:07:18 -08:00
Kristiyan Kostadinov 83ba587c18 test(ivy): update sidenav root causes (#29073)
Updates a couple of the root causes for `MatSidenav` which ended up being a different issue.

PR Close #29073
2019-03-04 10:06:43 -08:00
Kristiyan Kostadinov c0757d1d44 fix(ivy): attached flag not being reset when view is destroyed (#29064)
Currently we only reset the `Attached` flag of a view if it is detached through its parent, however this means that if a root view is destroyed, its flag will never be reset. This manifested itself in one of the Material tests where we were destroying the root view.

This PR resolves FW-1130.

PR Close #29064
2019-03-01 16:56:03 -08:00
Kara Erickson 7ac58bec8a fix(ivy): move views that are already attached in insert() (#29047)
Currently if a user accidentally calls ViewContainerRef.insert() with
a view that has already been attached, we do not clean up the references
properly, so we create a view tree with a cycle. This causes an infinite
loop when the view is destroyed.

This PR ensures that we fall back to ViewContainerRef.move() behavior
if we try to insert a view that is already attached. This fixes the
cycle and honors the user intention.

PR Close #29047
2019-03-01 15:17:24 -08:00
Kristiyan Kostadinov daf8251998 test(ivy): update root causes for expansion panel and accordion (#29011)
Removes some tests, that were failing due to static queries, from the blocklist. Related Material PR https://github.com/angular/material2/pull/15330.

PR Close #29011
2019-02-27 14:00:55 -08:00
Kara Erickson b8d87490f5 test(ivy): record root cause of CdkVirtualScrollViewport failures (#28999)
PR Close #28999
2019-02-27 10:24:04 -08:00
Kristiyan Kostadinov 41de05e1ae test(ivy): update select root causes (#28989)
Updates the root causes for the `MatSelect` failures. A few of them were fixed by https://github.com/angular/material2/pull/15320.

PR Close #28989
2019-02-26 16:58:54 -08:00
Marc Laval dc9f0af080 fix(ivy): static host classes and styles should work on root component (#28926)
PR Close #28926
2019-02-26 13:29:36 -08:00
Marc Laval 8f8f9a6e61 fix(ivy): ngtsc should correctly bind to context in nested template with many bindings (#28982)
PR Close #28982
2019-02-26 11:54:13 -08:00
Kristiyan Kostadinov 25a2fef303 fix(ivy): ViewRef.rootNodes not including projected nodes (#28951)
Currently if an embedded view contains projected nodes, its `rootNodes` array will include `null` instead of the root nodes inside the projection slot. This manifested itself in one of the Material unit tests where we stamp out a template and then move its `rootNodes` into the overlay container.

This PR is related to FW-1087.

PR Close #28951
2019-02-26 10:49:01 -08:00
Kristiyan Kostadinov dbd9ecfd4c test(ivy): update sidenav and drawer root causes (#28972)
Updates the root causes for the `MatDrawer` and `MatSidenav` tests. All of the `MatDrawer` failures were fixed by https://github.com/angular/material2/pull/15300.

PR Close #28972
2019-02-26 10:48:32 -08:00
Kristiyan Kostadinov 9f7a9c607e test(ivy): update root causes for material menu (#28952)
Updates the root causes for the remaining `MatMenu` tests. Note that two tests are omitted from this PR, because one will be fixed by https://github.com/angular/angular/pull/28951 and the other one depends on static queries and will be refactored by https://github.com/angular/material2/pull/15289.

PR Close #28952
2019-02-25 08:16:52 -08:00
Marc Laval 9dac04ff50 fix(ivy): ngOnChanges hooks should be inherited from grand-superclasses (#28888)
PR Close #28888
2019-02-22 12:00:15 -08:00
Marc Laval 33f71e8ce3 test(ivy): diagnose root causes of failures in Dialog and MatDialog (#28925)
PR Close #28925
2019-02-22 08:58:50 -08:00
Kristiyan Kostadinov 32ae84da28 fixup! fix(ivy): incorrectly remapping certain properties that refer to inputs (#28765)
PR Close #28765
2019-02-21 17:59:50 -08:00
Kara Erickson d8704a3069 test(ivy): turn on passing Material tests for paginator (#28890)
PR Close #28890
2019-02-21 12:34:55 -08:00
Kristiyan Kostadinov e1aaa7ec48 fix(ivy): component destroy hook called twice when configured as provider (#28470)
Fixes the `ngOnDestroy` hook on a component or directive being called twice, if the type is also registered as a provider.

This PR resolves FW-1010.

PR Close #28470
2019-02-21 09:34:26 -08:00
Kara Erickson 0ea216b993 test(ivy): update material blocklist with root causes, remove passing tests (#28879)
PR Close #28879
2019-02-21 07:46:57 -08:00
Kara Erickson d0b6622b9a test(ivy): turn on more passing Material tests (#28876)
This commit removes more test from the Material blocklist so that
they will run on CI. After static query support was added, they
are no longer failing.

PR Close #28876
2019-02-20 16:49:00 -08:00
Kara Erickson 68da4658ff test(ivy): update material blocklist to turn on passing tests (#28873)
We added the static flag to some dialog queries and new tests are passing.

PR Close #28873
2019-02-20 11:25:16 -08:00
Kara Erickson 669b4410f2 test(ivy): update material golden file to turn on passing tests (#28848)
We marked some queries in MatTab as static, which made some
more Material tests pass in CI.

PR Close #28848
2019-02-19 22:27:29 -08:00
Kristiyan Kostadinov 63e5d2787b fix(ivy): rethrow event handler errors in tests (#28707)
Currently errors thrown inside event handler in Ivy are caught and forwarded to the `ErrorHandler`, however this means that if they happen during a unit test, the test won't fail. These changes add a test-specific `ErrorHandler` that throws the error rather than logging it out.

PR Close #28707
2019-02-14 19:26:56 +00:00
Pawel Kozlowski 6fa4235543 test(ivy): enable passing Material tests (#28687)
PR Close #28687
2019-02-13 12:12:45 -08:00
Andrew Kushnir 553f80ff46 fix(ivy): set proper implementation for module injector (#28667)
Prior to this change we used current injector implementation for module injector, which was causing problems and produces circular dependencies in case the same token is referenced (with @SkipSelf flag) in the `deps` array. The origin of the problem was that once `directiveInject` implementation becomes active, it was used for module injector as well, thus searching deps in Component/Directive DI scope. This fix sets `injectInjectorOnly` implementation for module injector to resolve the problem.

PR Close #28667
2019-02-13 12:05:13 -08:00
crisbeto 1b82e11e69 test(ivy): update root causes for autocomplete tests (#28657)
Updates the root cause notes for the Material autocomplete tests.

This PR resolves FW-1017.

PR Close #28657
2019-02-12 09:47:20 -08:00
Pawel Kozlowski 81329c85b3 test(ivy): enable passing material tests (#28560)
PR Close #28560
2019-02-08 16:42:45 -08:00
Andrew Kushnir 90670252de test: update Material blocklist (#28605)
This commit updates Material blocklist, which was changed as a result of a couple Material-related fixes merged into master.

PR Close #28605
2019-02-07 21:54:28 -08:00
Andrew Seguin 00e24b3000 test: update material ivy errors notes (#28582)
PR Close #28582
2019-02-07 12:37:55 -08:00
Kara Erickson 1950e2d9ba fix(ivy): throw on bindings to unknown properties (#28537)
This commit adds a devMode-only check which will throw if a user
attempts to bind a property that does not match a directive
input or a known HTML property.

Example:
```
<div [unknownProp]="someValue"></div>
```

The above will throw because "unknownProp" is not a known
property of HTMLDivElement.

This check is similar to the check executed in View Engine during
template parsing, but occurs at runtime instead of compile-time.

Note: This change uncovered an existing bug with host binding
inheritance, so some Material tests had to be turned off. They
will be fixed in an upcoming PR.

PR Close #28537
2019-02-07 12:37:32 -08:00
Kristiyan Kostadinov ae8b7b1fdb test(ivy): root cause analysis for mat-selection-list (#28525)
Updates the root cause for the `MatSelectionList` test failures.

This PR resolves FW-1018.

PR Close #28525
2019-02-06 00:49:16 -05:00
Andrew Seguin 63b744bb6a test: enter notes on ivy-related material test errors (#28527)
PR Close #28527
2019-02-05 20:12:40 -05:00
Matias Niemelä 76a6eacb4e refactor(ivy): rename "blacklist" to "blocklist" (#28536)
PR Close #28536
2019-02-05 14:06:15 -05:00
Jeremy Elbourn 1b33142595 build: run angular/material2 unit tests on ci (#28197)
PR Close #28197
2019-02-01 12:15:35 -05:00