146 Commits

Author SHA1 Message Date
Oussama Ben Brahim
f1a063298e feat(core): set preserveWhitespaces to false by default ()
Fixes 

PR Close 
2018-02-16 09:06:14 -08:00
Alex Eagle
a069e08354 refactor(bazel): convert most ts_library to ng_module ()
This is necessary so we can produce ng metadata for our packages that are published as libraries

PR Close 
2018-02-15 14:08:53 -08:00
Dan Bucholtz
92a5876f51 refactor(router): move activation to private method ()
PR Close 
2018-02-12 10:00:36 -08:00
JiaLi.Passion
f791e9f081 fix(core): fix , don't need to wrap zone in location change listener ()
PR Close 
2018-02-05 13:06:22 -08:00
vsavkin
c40ae7f7cf feat(router): add navigationSource and restoredState to NavigationStart event ()
Currently, NavigationStart there is no way to know if an navigation was triggered imperatively or via the location change. These two use cases should be handled differently for a variety of use cases (e.g., scroll position restoration). This PR adds a navigation source field and restored navigation id (passed to navigations triggered by a URL change).

PR Close 
2018-01-29 10:22:59 -08:00
Jason Aden
ede9cb7c2f Revert: "feat(router): add navigationSource and restoredState to NavigationStart event ()"
This reverts commit 3b7bab7d22064d545f1745dc3e062fcb1d91073b. Will be re-merged after fixing integration of minor breaking change.
2018-01-26 16:24:56 -08:00
Patrick Shields
d964491f2a fix(router): remove @internal tag on ParamInheritanceType ()
This is a more defensive approach to ensure that references to
ParamInheritanceType from the published declarations do not cause
compilation errors when compiling Angular from the published packages.

Fixes 

PR Close 
2018-01-26 10:28:33 -08:00
vsavkin
3b7bab7d22 feat(router): add navigationSource and restoredState to NavigationStart event ()
Currently, NavigationStart there is no way to know if an navigation was triggered imperatively or via the location change. These two use cases should be handled differently for a variety of use cases (e.g., scroll position restoration). This PR adds a navigation source field and restored navigation id (passed to navigations triggered by a URL change).

PR Close 
2018-01-26 10:25:32 -08:00
Patrick Shields
925e654a29 fix(router): don't use ParamsInheritanceStrategy in declarations ()
ParamsInheritanceStrategy is internal, so any references to it from the
published .d.ts files will fail.

Fixes .

PR Close 
2018-01-23 21:34:37 -08:00
Alex Eagle
a1492a73ce build: Remove angular_src nested workspace ()
PR Close 
2018-01-19 10:17:37 -08:00
Alex Eagle
c4f02e21dd build: move repeated tsconfig attributes to a macro ()
This helps ensure we use the same tsconfig.json file for all compilations.
Next steps are to make it the same tsconfig.json file used by the editor

PR Close 
2018-01-10 12:30:19 -08:00
courtneypattison
a76ab1f42a docs(router): remove extra brackets ()
PR Close 
2018-01-10 12:20:16 -08:00
Jason Aden
b5934fc582 docs(router): fix missing export in docs for UrlMatcher ()
Fixes 

PR Close 
2018-01-04 17:48:32 -05:00
Siyao Li
2402224b4e docs(common): update copyright years ()
PR Close 
2018-01-04 17:45:36 -05:00
Miško Hevery
ae97920fe2 build: move _testing_init into tools; limit web_test concurrency ()
PR Close 
2017-12-22 13:10:51 -08:00
Misko Hevery
40dfe39e64 build(router): enable bazel tests for router ()
Bazel runs on newer version of RxJs than is installed in Yarn. The never version subclasses `EmptyError` in a different way which fails the `instanceof` check. This change makes the `instanceof` check more robust with respect to `EmptyError`.

PR Close 
2017-12-22 13:10:51 -08:00
Misko Hevery
3d50fd7cac build: add bazel test rules for remainder of packages ()
PR Close 
2017-12-22 13:10:51 -08:00
Jason Aden
5ba1cf1063 fix(router): fix wildcard route with lazy loaded module (again) ()
Closes 

Description:
We doesn't handle children of wildcard route properly link. It's always an empty array.

Created from 

PR Close 
2017-12-22 09:20:11 -08:00
Zaven Muradyan
5efea2f6a0 feat(router): add "paramsInheritanceStrategy" router configuration option
Previously, the router would merge path and matrix params, as well as
data/resolve, with special rules (only merging down when the route has
an empty path, or is component-less). This change adds an extra option
"paramsInheritanceStrategy" which, when set to 'always', makes child
routes unconditionally inherit params from parent routes.

Closes .
2017-12-20 10:06:24 -08:00
Alex Rickabaugh
e4c53f8529 Revert "feat(router): add a function set up router sync when used with downgradeModule"
This reverts commit f5bb99931989357c4a053c93c82b92c2740e7d5e. The commit
does not include proper tests.
2017-12-20 09:15:15 -08:00
Alex Rickabaugh
b61e3e9d20 Revert "fix(router): replaceURL when reacting to a change coming from angularjs"
This reverts commit 0b2d636b75d69e17bff2eb875181a2a6242e1abb. The commit
does not include proper tests.
2017-12-20 09:14:27 -08:00
vsavkin
0b2d636b75 fix(router): replaceURL when reacting to a change coming from angularjs
Closes: 
2017-12-15 07:59:56 -08:00
vsavkin
f5bb999319 feat(router): add a function set up router sync when used with downgradeModule 2017-12-15 07:59:56 -08:00
Yuan Gao
e544742156 refactor(core): Removed readonly getters and changed to readonly ()
variables

PR Close 
2017-12-08 10:24:19 -08:00
vsavkin
d8cc09b76c fix(router): NavigatonError and NavigationCancel should be emitted after resetting the URL ()
PR Close 
2017-12-07 13:34:20 -08:00
Alex Eagle
ef534c0cc1 build: upgrade bazel rules to latest ()
Add enough BUILD files to make it possible to
`bazel build packages/core/test`

Also re-format BUILD.bazel files with Buildifier.
Add a CI lint check that they stay formatted.

PR Close 
2017-12-07 11:27:50 -08:00
Alex Eagle
5ec1717c58 fix: Update test code to type-check under TS 2.5 ()
PR Close 
2017-11-15 18:12:16 -06:00
Mark Kennedy
a622e19df6 fix(router): 'merge' queryParamHandling strategy should be able to remove query params ()
Closes , 

PR Close 
2017-11-14 11:01:04 -08:00
George Kalpakas
901436e46f docs: fix link texts
Fixes 

PR Close 
2017-11-01 15:44:59 -04:00
Hans Larsen
13f8648a00 fix: add missing globals from each rollup configuration ()
PR Close 
2017-10-30 23:09:17 -04:00
Hans Larsen
b6abcb2500 refactor: make all rollup config ES5 compatible ()
So they can be required by other Node scripts.

PR Close 
2017-10-30 23:09:17 -04:00
vsavkin
d3211a2468 feat(router): add "onSameUrlNavigation" router configuration option ()
PR Close 
2017-10-23 20:56:53 -04:00
vsavkin
adab4f3e49 fix(router): do not call location.go when skipping a navigation ()
Closes 

PR Close 
2017-10-23 20:56:52 -04:00
vsavkin
82fed62af2 fix(router): navigating to the current location works ()
Closes 

PR Close 
2017-10-23 20:56:52 -04:00
vsavkin
6f2939da62 fix(router): RouterLinkActive should update its state right after checking the children ()
Closes 

PR Close 
2017-10-18 11:17:55 -07:00
Jason Aden
7d1abd9adb build: update to rxjs@5.5.0 ()
PR Close 
2017-10-18 11:17:43 -07:00
Tobias Bosch
b0c7ea8181 Revert "fix(router): RouterLinkActive should update its state right after checking the children ()"
This reverts commit c569b7524974200040c2abae6923cd4e6f59a13b.
As it was synched together with 5a9ed2de272912ac74ed56bfec4bdf4551f7b38e
which broke an internal test.
2017-10-18 09:58:41 -07:00
vsavkin
c569b75249 fix(router): RouterLinkActive should update its state right after checking the children ()
Closes 

PR Close 
2017-10-17 20:57:30 -07:00
Chuck Jazdzewski
d7eac7ee56 Revert "fix(router): navigating to the current location works ()"
This reverts commit 43c5b638b96a0c63f041a0b31e4c646ead72341b.
2017-10-09 16:38:12 -07:00
Chuck Jazdzewski
d53b96f2a2 Revert "fix(router): do not call location.go when skipping a navigation ()"
This reverts commit 66515412308138ad083bdd91ab2e80cd2bdf7fac.
2017-10-09 16:37:31 -07:00
vsavkin
6651541230 fix(router): do not call location.go when skipping a navigation ()
Closes 

PR Close 
2017-10-09 11:45:13 -07:00
vsavkin
43c5b638b9 fix(router): navigating to the current location works ()
Closes 

PR Close 
2017-10-09 11:45:13 -07:00
Chuck Jazdzewski
8e5b582b61 Revert "fix(router): navigating to the current location works ()"
This reverts commit b67d574a9562d76ab0a838f4d1b42501e5c5f09b.
2017-10-06 18:15:19 -07:00
Chuck Jazdzewski
0cc87c5ba1 Revert "fix(router): do not call location.go when skipping a navigation ()"
This reverts commit fdfa31798befb57d90770956cc95511d9b3b7bd1.
2017-10-06 18:15:16 -07:00
vsavkin
fdfa31798b fix(router): do not call location.go when skipping a navigation ()
Closes 

PR Close 
2017-10-06 15:35:25 -07:00
vsavkin
b67d574a95 fix(router): navigating to the current location works ()
Closes 

PR Close 
2017-10-06 15:35:24 -07:00
Victor Berchet
6a9ce67714 Revert "refactor(core): Removed readonly getters and changed to readonly ()"
This reverts commit 2b84b86fc08a4ecb3078bd8b3a1bfc7b07946b20.
2017-09-28 13:36:44 -07:00
Victor Savkin
a9d32a3f89 fix(router): resolve and guards should be able to reject with null and undefined ()
Closes 
2017-09-28 11:06:08 -07:00
tinayuangao
2b84b86fc0 refactor(core): Removed readonly getters and changed to readonly ()
variables
2017-09-28 09:36:29 -07:00
Alex Eagle
82e49230ff build: Give names to the AMD modules nested in Angular UMD distro () 2017-09-28 09:29:22 -07:00