angular-cn

Commit Graph

Author	SHA1	Message	Date
Pete Bacon Darwin	be58159550	build: ensure package-builder finds bazel (#33904 ) Since `scripts/package-builder.js` gets run from the `aio` folder sometimes, it is important to set the cwd for the command that finds the bazel bin directory. PR Close #33904	2019-11-19 11:40:19 -08:00
George Kalpakas	e2cba6ed7d	build: replace `fs` methods with ShellJS' `test('-d')` (#33895 ) This makes the JS script more similar to the original bash script it replaced (see #33854) and will be easier to follow for people that are less familiar with Node.js scripting. Discussed in: https://github.com/angular/angular/pull/33854#discussion_r346949765 PR Close #33895	2019-11-18 09:10:16 -08:00
George Kalpakas	7eb3e3bce6	build: fix build scripts on macOS (#33854 ) In #33823, `scripts/package-builds.sh` (which is used by both `build-packages-dist.sh` and `build-ivy-npm-packages.sh`) was updated to use `realpath`. It turns out that `realpath` does not exist on macOS, so the build scripts do not work there. In order to fix this (and also reduce the likelihood of introducing similar issues in the future), this commit changes these bash scripts to Node.js scripts (using [ShellJS](https://github.com/shelljs/shelljs) for a cross-platform implementation of Unix shell commands where necessary). PR Close #33854	2019-11-15 16:05:00 -08:00

Author

SHA1

Message

Date

Pete Bacon Darwin

be58159550

build: ensure package-builder finds bazel (#33904 )

Since `scripts/package-builder.js` gets run from the
`aio` folder sometimes, it is important to set the cwd
for the command that finds the bazel bin directory.

PR Close #33904

2019-11-19 11:40:19 -08:00

George Kalpakas

e2cba6ed7d

build: replace `fs` methods with ShellJS' `test('-d')` (#33895 )

This makes the JS script more similar to the original bash script it
replaced (see #33854) and will be easier to follow for people that are
less familiar with Node.js scripting.

Discussed in:
https://github.com/angular/angular/pull/33854#discussion_r346949765

PR Close #33895

2019-11-18 09:10:16 -08:00

George Kalpakas

7eb3e3bce6

build: fix build scripts on macOS (#33854 )

In #33823, `scripts/package-builds.sh` (which is used by both
`build-packages-dist.sh` and `build-ivy-npm-packages.sh`) was updated to
use `realpath`. It turns out that `realpath` does not exist on macOS, so
the build scripts do not work there.

In order to fix this (and also reduce the likelihood of introducing
similar issues in the future), this commit changes these bash scripts to
Node.js scripts (using [ShellJS](https://github.com/shelljs/shelljs) for
a cross-platform implementation of Unix shell commands where necessary).

PR Close #33854

2019-11-15 16:05:00 -08:00

3 Commits