angular-cn

Commit Graph

Author	SHA1	Message	Date
Keen Yee Liau	650974e1b3	test(language-service): Remove all markers from test project (#37475 ) This commit removes all markers from the inline template in `AppComponent` and external template in `TemplateReference`. Test scenarios should be colocated with the test cases themselves. Besides, many existing cases are invalid. For example, if we want to test autocomplete for HTML element, the existing test case is like: ``` <~{cursor} h1> ``` This doesn't make much sense, becasue the language service already sees the `h1` tag in the template. The correct test case should be: ``` <~{cursor ``` IMO, this reflects the real-world use case better. This commit also uncovers a bug in the way HTML entities autocompletion is done. There's an off-by-one error in which a cursor that immediately trails the ampersand character fails to trigger HTML entities autocompletion. PR Close #37475	2020-06-08 10:25:42 -07:00
Keen Yee Liau	a04f7c0d5f	fix(language-service): Proper completions for properties and events (#34445 ) This commit fixes autocompletions for properties and events bindings. The language service will no longer provide bindings like (click) or [id]. Instead, it'll infer the context based on the brackets and provide suggestions without any brackets. This fix also adds support for alternative binding syntax such as `bind-`, `on-`, and `bindon`. PR closes https://github.com/angular/vscode-ng-language-service/issues/398 PR closes https://github.com/angular/vscode-ng-language-service/issues/474 PR Close #34445	2019-12-18 09:13:31 -08:00
Keen Yee Liau	9d8dc793da	test(language-service): Create proper test project (#32653 ) Language service uses a canonical "Tour of Heroes" project to test various features, but the files are all contained in test_data.ts which is hard to read and often contains errors that are difficult to catch without proper IDE syntax highlighting. The directory structure is also not clear from first glance. This PR refactors the test project into standalone files in the proper format. Next up: [ ] Update the interface of MockTypeScript to only accept scriptNames. [ ] Remove test_data.ts PR Close #32653	2019-09-18 13:07:01 -07:00

Author

SHA1

Message

Date

Keen Yee Liau

650974e1b3

test(language-service): Remove all markers from test project (#37475 )

This commit removes all markers from the inline template in
`AppComponent` and external template in `TemplateReference`.

Test scenarios should be colocated with the test cases themselves.
Besides, many existing cases are invalid. For example, if we want to
test autocomplete for HTML element, the existing test case is like:
```
<~{cursor} h1>
```
This doesn't make much sense, becasue the language service already sees
the `h1` tag in the template. The correct test case should be:
```
<~{cursor
```
IMO, this reflects the real-world use case better.

This commit also uncovers a bug in the way HTML entities autocompletion
is done. There's an off-by-one error in which a cursor that immediately
trails the ampersand character fails to trigger HTML entities
autocompletion.

PR Close #37475

2020-06-08 10:25:42 -07:00

Keen Yee Liau

a04f7c0d5f

fix(language-service): Proper completions for properties and events (#34445 )

This commit fixes autocompletions for properties and events bindings.

The language service will no longer provide bindings like (click) or [id].
Instead, it'll infer the context based on the brackets and provide suggestions
without any brackets.

This fix also adds support for alternative binding syntax such as
`bind-`, `on-`, and `bindon`.

PR closes https://github.com/angular/vscode-ng-language-service/issues/398
PR closes https://github.com/angular/vscode-ng-language-service/issues/474

PR Close #34445

2019-12-18 09:13:31 -08:00

Keen Yee Liau

9d8dc793da

test(language-service): Create proper test project (#32653 )

Language service uses a canonical "Tour of Heroes" project to test
various features, but the files are all contained in test_data.ts which
is hard to read and often contains errors that are difficult to catch
without proper IDE syntax highlighting. The directory structure is also
not clear from first glance.

This PR refactors the test project into standalone files in the proper
format.

Next up:
[ ] Update the interface of MockTypeScript to only accept scriptNames.
[ ] Remove test_data.ts

PR Close #32653

2019-09-18 13:07:01 -07:00

3 Commits