135 Commits

Author SHA1 Message Date
Brandon Roberts
ebd01e8e79 docs: more form overview edits ()
PR Close 
2018-09-25 18:48:15 -07:00
Brandon Roberts
04dfca41f4 docs(forms): add package overview for forms ()
PR Close 
2018-09-25 18:48:15 -07:00
Frederik Schlemmer
1e02cd9961 docs: Fixes typo in FormArray ()
PR Close 
2018-09-24 09:14:07 -07:00
Pete Bacon Darwin
7d39bc68fb docs(forms): move extended text to @usageNotes ()
Headings are not allowed in the basic description block.

PR Close 
2018-09-24 09:11:02 -07:00
Pete Bacon Darwin
927323f24e docs: add missing @ngModule tags ()
PR Close 
2018-09-19 16:18:24 -07:00
Brandon Roberts
a9a81f91cf docs(forms): update form apis based on review feedback ()
PR Close 
2018-09-19 16:09:00 -07:00
Brandon Roberts
07c10e2844 docs(forms): update API reference for forms interfaces and abstract classes ()
PR Close 
2018-09-19 16:09:00 -07:00
Judy Bogart
dd5e35ee67 docs: add ngmodule api doc ()
PR Close 
2018-09-19 10:40:58 -07:00
Alex Eagle
cbbad1b791 refactor(ivy): pre-factor: set explicit type parameters for ModuleWithProviders ()
Ivy depends on having the generic type token later when reading the ModuleWithProviders from a .d.ts file.

PR Close 
2018-09-18 13:28:44 -07:00
George Wilde
ddd3bf83c7 docs(forms): change documentation of the FormGroup patchValue method ()
Improve the grammar of the description to make it more readable.
PR Close 
2018-09-18 13:08:05 -07:00
Greg Magolan
b99d7ed5bf build(bazel): update to rules_typescript 0.17.0 & rules_nodejs 0.13.4 ()
PR Close 
2018-09-18 13:05:38 -07:00
Brandon Roberts
abd29f5049 docs(forms): update API reference for reactive and template-driven forms modules ()
PR Close 
2018-08-31 13:37:40 -07:00
Alan
3ba5220839 refactor(forms): ngForm element selector has been deprecated in favor of ng-form ()
This has been deprecated to keep selector consistent with other core Angular selectors.  As element selectors are in kebab-case.

 Now deprecated:
 ```
 <ngForm #myForm="ngForm">
 ```

 After:
 ```
 <ng-form #myForm="ngForm">
 ```

You can also choose to supress this warnings by providing a config for `FormsModule` during import:

```ts
imports: [
 FormsModule.withConfig({warnOnDeprecatedNgFormSelector: 'never'});
]

Closes: 

PR Close 
2018-08-02 08:34:43 -07:00
denjamal
3f6fc00d73 docs(forms): fix incorrect variables naming in the comments ()
PR Close 
2018-07-31 11:42:15 -07:00
Alex Rickabaugh
60aeee7abf feat(ivy): selector side of ModuleWithProviders via type metadata ()
Within an @NgModule it's common to include in the imports a call to
a ModuleWithProviders function, for example RouterModule.forRoot().
The old ngc compiler was able to handle this pattern because it had
global knowledge of metadata of not only the input compilation unit
but also all dependencies.

The ngtsc compiler for Ivy doesn't have this knowledge, so the
pattern of ModuleWithProviders functions is more difficult. ngtsc
must be able to determine which module is imported via the function
in order to expand the selector scope and properly tree-shake
directives and pipes.

This commit implements a solution to this problem, by adding a type
parameter to ModuleWithProviders through which the actual module
type can be passed between compilation units.

The provider side isn't a problem because the imports are always
copied directly to the ngInjectorDef.

PR Close 
2018-07-20 11:48:35 -07:00
Brandon Roberts
80a74b450a docs(forms): update form builder API reference ()
PR Close 
2018-07-12 16:38:26 -04:00
Alex Rickabaugh
02b5087685 build(ivy): enable ngtsc AOT builds for a few packages ()
Turn on AOT builds using ngtsc for:

* animations
* common
* compiler
* compiler-cli
* forms
* platform-browser

PR Close 
2018-07-12 16:36:35 -04:00
Brandon Roberts
05e3e4d71e docs(forms): update API reference for form validators ()
PR Close 
2018-07-10 18:52:40 -07:00
Tyler Akins
81a9db2b0a docs(forms): added missing backtick ()
Fixed trivial markdown problem with a missing backtick.

PR Close 
2018-07-10 18:51:08 -07:00
George Kalpakas
787c54736c test: run unit tests in random order ()
PR Close 
2018-07-06 13:48:02 -07:00
George Kalpakas
00c110b055 build: upgrade jasmine (and related typings) to latest version ()
With these changes, the types are a little stricter now and also not
compatible with Protractor's jasmine-like syntax. So, we have to also
use `@types/jasminewd2` for e2e tests (but not for non-e2e tests).

I also had to "augment" `@types/jasminewd2`, because the latest
typings from [DefinitelyTyped][1] do not reflect the fact that the
`jasminewd2` version (v2.1.0) currently used by Protractor supports
passing a `done` callback to a spec.

[1]: 566e039485/types/jasminewd2/index.d.ts (L9-L15)

Fixes 
Closes 

PR Close 
2018-07-06 13:48:02 -07:00
Rado Kirov
c95437f15d build(bazel): Turning on strictPropertyInitialization for Angular. ()
All errors for existing fields have been detected and suppressed with a
`!` assertion.

Issue/24571 is tracking proper clean up of those instances.

One-line change required in ivy/compilation.ts, because it appears that
the new syntax causes tsickle emitted node to no longer track their
original sourceFiles.

PR Close 
2018-06-25 07:57:13 -07:00
Brandon Roberts
5b76f04b7f docs: More edits ()
PR Close 
2018-06-19 10:53:13 -07:00
Brandon Roberts
a57825acf3 docs: More form control API edits ()
PR Close 
2018-06-19 10:53:13 -07:00
Brandon Roberts
efc7639352 docs: Added multicast to observable descriptions ()
PR Close 
2018-06-19 10:53:13 -07:00
Brandon Roberts
3e26cabe02 docs: formatting ()
PR Close 
2018-06-19 10:53:13 -07:00
Brandon Roberts
9d114c052a docs: More form control API references fixes ()
PR Close 
2018-06-19 10:53:13 -07:00
Brandon Roberts
43e61c25e1 docs(docs-infra): Update with review changes ()
PR Close 
2018-06-19 10:53:13 -07:00
Brandon Roberts
4e1493a1d6 docs(forms): update API reference for FormControl ()
PR Close 
2018-06-19 10:53:13 -07:00
Alex Rickabaugh
7983f0a69b ci(ivy): configure CI environments for Ivy JIT and AOT ()
Two new CircleCI environments are created: test_ivy_jit and test_ivy_aot.
Both run a subset of the tests that have been marked with Bazel tags as
being appropriate for that environment.

Once all the tests pass, builds are published to the *-builds repo both
for the legacy View Engine compiled code as well as for ivy-jit and ivy-aot.

PR Close 
2018-06-08 13:34:27 -07:00
Trotyl
9367e91402 fix(forms): properly handle special properties in FormGroup.get ()
closes 

PR Close 
2018-06-05 18:28:13 -07:00
Johnson Lin
b86d4dee4d docs(forms): fix API doc ()
closes 

PR Close 
2018-05-30 17:06:12 -07:00
Alex Eagle
017d67cdf8 test: switch to ts_web_test_suite ()
Unit tests now run on Firefox too

PR Close 
2018-05-15 11:40:56 -07:00
swseverance
fe3679a356 style: remove empty comments ()
PR Close 
2018-05-10 15:48:13 -07:00
Igor Minar
6601d0f7ba build: update to rxjs@6.0.0 ()
PR Close 
2018-05-03 10:53:39 -07:00
Pete Bacon Darwin
4b96a58c5a docs: remove all deprecated @stable jsdoc tags ()
These are no longer needed as stable docs are computed as those that
do not have `@experimental` or `@deprecated` tags.

PR Close 
2018-04-10 21:49:32 -07:00
Pete Bacon Darwin
92821e338b docs(forms): remove unnecessary {@link Injector} jsdoc tags ()
Inline code blocks are automatically linked, if possible, to their API
page.

PR Close 
2018-04-05 09:27:29 -07:00
Pete Bacon Darwin
1aef4df127 docs(forms): migrate @whatItDoes tags to the description ()
We get the overview for the doc by splitting off the first
paragraph.

PR Close 
2018-04-05 09:27:29 -07:00
Pete Bacon Darwin
0a065bbdcf docs(forms): migrate deprecated @howToUse tags ()
In this case they have been converted to `@description` tags.

PR Close 
2018-04-05 09:27:29 -07:00
Dirk Luijk
23cc3ef2eb fix(forms): improve error message for invalid value accessors ()
Signed-off-by: Dirk Luijk <mail@dirkluijk.nl>

PR Close 
2018-04-04 08:20:55 -07:00
Igor Minar
92724b396b build: update to rxjs@6.0.0-rc.0 ()
PR Close 
2018-04-03 10:00:24 -07:00
Alex Eagle
15278784fc release(bazel): change publish-next script to publish bazel artifacts ()
PR Close 
2018-03-30 14:03:05 -07:00
Igor Minar
22cb2c9441 build: add missing dependencies on @rxjs//operators needed for rxjs@6.0.0-beta.4 ()
PR Close 
2018-03-30 13:07:03 -07:00
Igor Minar
6f7d14064c build: update to rxjs@6.0.0-beta.4 ()
PR Close 
2018-03-30 13:07:03 -07:00
Igor Minar
8768665587 fix: correct peerDependencies declaration on rxjs 2018-03-20 22:48:41 -07:00
Igor Minar
b43f8bc7d3 feat(core): upgrade rxjs to 6.0.0-alpha.4 ()
PR Close 
2018-03-19 21:51:51 -07:00
Igor Minar
ce63dc6f95 feat: update the package output of build.sh to APF v6 ()
PR Close 
2018-03-18 09:33:51 -07:00
Alex Eagle
f9247e4b2e build: enable importHelpers in tsconfig ()
This is the primary tsconfig file used for Bazel builds.
Previously, we enabled this option only for releases.

PR Close 
2018-03-15 21:16:03 -07:00
Igor Minar
44de10e2db feat: mark angular packages as side-effect free ()
This flag is picked up by webpack v4 and used for more agressive optimizations.

Our code is already side-effect free, because that's what we needed for build-optimizer to work.

PR Close 
2018-03-15 14:52:40 -07:00
Alex Eagle
1e6cc42a01 test: migrate remaining public-api tests to Bazel ()
We now create npm packages to cover all the public api assertions in tools/public_api_guard.
We no longer depend on ts-api-guardian from npm - it is now stale since the repository was archived.
There is no longer a gulp task to enforce or accept the public API, this is in CircleCI as part of running all bazel test targets.

PR Close 
2018-03-09 09:11:40 -08:00