honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
20,982 Commits 5 Branches 1 Tag
85e0fb0c17
Commit Graph

154 Commits

Author SHA1 Message Date
Jason Aden
ede9cb7c2f Revert: "feat(router): add navigationSource and restoredState to NavigationStart event ()" 
This reverts commit 3b7bab7d22064d545f1745dc3e062fcb1d91073b. Will be re-merged after fixing integration of minor breaking change.
 2018-01-26 16:24:56 -08:00
vsavkin
3b7bab7d22 feat(router): add navigationSource and restoredState to NavigationStart event () 
Currently, NavigationStart there is no way to know if an navigation was triggered imperatively or via the location change. These two use cases should be handled differently for a variety of use cases (e.g., scroll position restoration). This PR adds a navigation source field and restored navigation id (passed to navigations triggered by a URL change).

PR Close
2018-01-26 10:25:32 -08:00
Misko Hevery
3d50fd7cac build: add bazel test rules for remainder of packages () 
PR Close
2017-12-22 13:10:51 -08:00
Jason Aden
5ba1cf1063 fix(router): fix wildcard route with lazy loaded module (again) () 
Closes 

Description:
We doesn't handle children of wildcard route properly link. It's always an empty array.

Created from 

PR Close
2017-12-22 09:20:11 -08:00
Zaven Muradyan
5efea2f6a0 feat(router): add "paramsInheritanceStrategy" router configuration option 
Previously, the router would merge path and matrix params, as well as
data/resolve, with special rules (only merging down when the route has
an empty path, or is component-less). This change adds an extra option
"paramsInheritanceStrategy" which, when set to 'always', makes child
routes unconditionally inherit params from parent routes.

Closes .
 2017-12-20 10:06:24 -08:00
vsavkin
d8cc09b76c fix(router): NavigatonError and NavigationCancel should be emitted after resetting the URL () 
PR Close
2017-12-07 13:34:20 -08:00
Mark Kennedy
a622e19df6 fix(router): 'merge' queryParamHandling strategy should be able to remove query params () 
Closes , 

PR Close
2017-11-14 11:01:04 -08:00
vsavkin
d3211a2468 feat(router): add "onSameUrlNavigation" router configuration option () 
PR Close
2017-10-23 20:56:53 -04:00
vsavkin
adab4f3e49 fix(router): do not call location.go when skipping a navigation () 
Closes 

PR Close
2017-10-23 20:56:52 -04:00
vsavkin
82fed62af2 fix(router): navigating to the current location works () 
Closes 

PR Close
2017-10-23 20:56:52 -04:00
vsavkin
6f2939da62 fix(router): RouterLinkActive should update its state right after checking the children () 
Closes 

PR Close
2017-10-18 11:17:55 -07:00
Tobias Bosch
b0c7ea8181 Revert "fix(router): RouterLinkActive should update its state right after checking the children ()" 
This reverts commit c569b7524974200040c2abae6923cd4e6f59a13b.
As it was synched together with 5a9ed2de272912ac74ed56bfec4bdf4551f7b38e
which broke an internal test.
 2017-10-18 09:58:41 -07:00
vsavkin
c569b75249 fix(router): RouterLinkActive should update its state right after checking the children () 
Closes 

PR Close
2017-10-17 20:57:30 -07:00
Chuck Jazdzewski
d7eac7ee56 Revert "fix(router): navigating to the current location works ()" 
This reverts commit 43c5b638b96a0c63f041a0b31e4c646ead72341b.
 2017-10-09 16:38:12 -07:00
Chuck Jazdzewski
d53b96f2a2 Revert "fix(router): do not call location.go when skipping a navigation ()" 
This reverts commit 66515412308138ad083bdd91ab2e80cd2bdf7fac.
 2017-10-09 16:37:31 -07:00
vsavkin
6651541230 fix(router): do not call location.go when skipping a navigation () 
Closes 

PR Close
2017-10-09 11:45:13 -07:00
vsavkin
43c5b638b9 fix(router): navigating to the current location works () 
Closes 

PR Close
2017-10-09 11:45:13 -07:00
Chuck Jazdzewski
8e5b582b61 Revert "fix(router): navigating to the current location works ()" 
This reverts commit b67d574a9562d76ab0a838f4d1b42501e5c5f09b.
 2017-10-06 18:15:19 -07:00
Chuck Jazdzewski
0cc87c5ba1 Revert "fix(router): do not call location.go when skipping a navigation ()" 
This reverts commit fdfa31798befb57d90770956cc95511d9b3b7bd1.
 2017-10-06 18:15:16 -07:00
vsavkin
fdfa31798b fix(router): do not call location.go when skipping a navigation () 
Closes 

PR Close
2017-10-06 15:35:25 -07:00
vsavkin
b67d574a95 fix(router): navigating to the current location works () 
Closes 

PR Close
2017-10-06 15:35:24 -07:00
Victor Savkin
a9d32a3f89 fix(router): resolve and guards should be able to reject with null and undefined () 
Closes
2017-09-28 11:06:08 -07:00
Jason Aden
8f7915022c feat(router): add ActivationStart/End events 2017-09-08 13:24:26 -04:00
Jason Aden
66f0ab0371 fix(router): adjust ChildActivation events to only fire when the child is actually changing () 
* The problem was with the `fireChildActivationStart` function. It was taking a `path` param, which was an
array of `ActivatedRouteSnapshot`s. The function was being fired for each piece of the route that was being
activated. This resulted in far too many `ChildActivationStart` events being fired, and being fired on routes
that weren't actually getting activated. This change fires the event only for those routes that are actually
being activated.

fixes 

PR Close
2017-09-05 15:46:29 -05:00
Jason Aden
dce36751f5 refactor(router): remove RouteEvent base class () 
* Introduced with , `RouteEvents` don't actually have a common constructor. Reverting here to be able to add new functionality to ChildActivation events.

PR Close
2017-09-05 15:46:29 -05:00
Chuck Jazdzewski
3a227a1f6f refactor(router): compile router cleanly with TypeScript 2.4 () 2017-08-02 17:32:02 -07:00
Jason Aden
49cd8513e4 feat(router): add events tracking activation of individual routes 
* Adds `ChildActivationStart` and `ChildActivationEnd`
* Adds test to verify the PreActivation phase of routing
 2017-08-01 10:44:00 -07:00
Victor Berchet
9479a106bb build: enable TSLint on the packages folder 2017-07-31 15:47:57 -07:00
Miško Hevery
a7f2468184 Revert "fix(router): should throw when lazy loaded module doesn't define any routes ()" 
This reverts commit 82923a381d96a7078d8b422e4ce6949e6c14950c.
 2017-07-27 10:53:01 -07:00
Dzmitry Shylovich
086f4aa72c fix(router): child CanActivate guard should wait for parent to complete () 
Closes 

PR Close
2017-07-26 17:11:22 -05:00
Dzmitry Shylovich
82923a381d fix(router): should throw when lazy loaded module doesn't define any routes () 
Closes 

PR Close
2017-07-26 17:11:07 -05:00
Roy Ling
e20cfe1bbc fix(router): canDeactivate guards should run from bottom to top 
Closes .
 2017-07-18 10:04:39 -07:00
Dzmitry Shylovich
eb6fb5f87e fix(router): should navigate to the same url when config changes 
Closes
2017-07-18 10:04:11 -07:00
Dzmitry Shylovich
ad3029e786 fix(router): should run resolvers for the same route concurrently 
Fixes
2017-07-18 10:03:33 -07:00
Victor Berchet
c723d42d0a refactor: fix typos () 2017-07-07 16:55:17 -07:00
Jason Aden
8a1a989a1c feat(router): add router-level events for GuardsCheck and Resolve () 2017-07-01 10:30:17 -07:00
Victor Berchet
5d4f5434fd refactor(router): don't run the change detection every time an outlet is activated 
fix(router): inside on push // SQUASH after review
 2017-05-19 11:55:15 -07:00
Matias Niemelä
a0a6029915 revert: refactor(router): don't run the change detection every time an outlet is activated 
This reverts commit 198edb31093ffdecfd13aed17967fb02e650cffe.
 2017-05-18 11:57:22 -07:00
Victor Berchet
198edb3109 refactor(router): don't run the change detection every time an outlet is activated 2017-05-17 19:32:04 -07:00
Miško Hevery
5293794316 fix: turn on nullability in the code base. 2017-04-18 12:07:33 -07:00
Miško Hevery
bc431888f3 fix(router): Update types for TypeScript nullability support 
This reverts commit ea8ffc984136ef4d32b6858fe35e69cc9fced021.
 2017-04-18 12:07:33 -07:00
Victor Berchet
82417b3ca5 fix(router): prevent RouterLinkActive from causing an infinite CD loop 
fixes
2017-04-17 10:15:44 -07:00
Tobias Bosch
ea8ffc9841 Revert "fix(router): Update types for TypeScript nullability support" 
This reverts commit 56c46d70f7b3cb308d658224682d739d4f9b5a2a.

Broke in G3.
 2017-04-17 09:56:09 -07:00
Miško Hevery
56c46d70f7 fix(router): Update types for TypeScript nullability support 2017-04-14 14:31:17 -07:00
Victor Berchet
ea4afebeb9 refactor(router): drop the InternalRoute interface 2017-04-14 09:08:13 -07:00
Dzmitry Shylovich
f368381d12 fix(router): should run CanActivate after CanDeactivate guards 
Closes 
Closes
2017-03-28 15:51:33 -07:00
Dzmitry Shylovich
7c2f795ea6 refactor(router): fix tests structure 2017-03-28 15:51:17 -07:00
Dzmitry Shylovich
8785b2bf6d fix(router): shouldn't execute CanLoad when a route has been loaded 
Closes 
Closes
2017-03-24 14:38:38 -07:00
Dzmitry Shylovich
fb1be83a1b refactor(router): polishing 2017-03-24 14:38:23 -07:00
Dzmitry Shylovich
08f2f08d74 fix(router): should pass new data to Observable when query params change () 
Fixes
2017-03-23 10:43:14 -07:00