Matias Niemelä
86a36eaadd
fix(animations): avoid infinite loop with multiple blocked sub triggers ( #21119 )
...
This patch fixes animations so that if multiple sub @triggers are used
and are blocked by a parent animation then the engine will not lead
itself into an infinite loop.
PR Close #21119
2017-12-22 09:23:28 -08:00
Miško Hevery
5a7bf36723
build: fix circular dep between interface and l_node by merging ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Miško Hevery
66528a21f6
build: fix benchmarks for render3 ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Miško Hevery
a77757277b
build: yarn buildifier ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Pawel Kozlowski
4f05d022c1
feat(core): support 'read' option for ngIvy queries ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Kara Erickson
5df343169e
docs(core): add missing docs to component and fix formatting ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Marc Laval
764fea1344
test(core): animation renderer factory in render3 ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Pawel Kozlowski
bbdea96a66
refactor: remove import circular dependencies ( #20855 )
...
This PR fixes a circular dependency among those files in Renderer3:
`query` -> `di` -> `instructions` -> `query` -> ...
Looking at the above dependencies the `di` -> `instructions` import is
a problematic one. Previously `di` had an import from `instructions`
since we can known about "current node" only in `instructions`
(and we need "current node" to create node injector instances).
This commit refactors the code in the way that functions in the
`di` file don't depend on any info stored module-global variables
in `instructions`.
PR Close #20855
2017-12-21 21:40:58 -08:00
Marc Laval
d1de587ce0
feat(core): add renderer factory in render3 ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Pawel Kozlowski
147aec43bd
feat: support queries for elements with local names ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Miško Hevery
1f5049f30c
style: fix formatting errors ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Kara Erickson
19eeba2281
refactor(core): rename instructions for consistency ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Miško Hevery
83b27bac17
style: fix formatting errors ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Kara Erickson
b462f49ce7
refactor(core): renamed and split out interfaces ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Kara Erickson
8fdb1e09c1
refactor(core): store directive defs in static data ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Miško Hevery
93b00cceb6
refactor(core): store locals in main array in rederer3 ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Miško Hevery
0fa818b318
feat(core): Moving Renderer3 into @angular/core ( #20855 )
...
PR Close #20855
2017-12-21 21:40:58 -08:00
Olivier Combe
b7738e1fe5
feat(core): add source to `StaticInjectorError` message ( #20817 )
...
Closes #19302
PR Close #20817
2017-12-12 11:56:06 -08:00
Matias Niemelä
13e663c232
fix(animations): ensure multi-level route leave animations are queryable ( #20787 )
...
Closes #19807
PR Close #20787
2017-12-08 13:44:01 -08:00
Matias Niemelä
46aa0a1cf6
fix(animations): properly recover and cleanup DOM when CD failures occur ( #20719 )
...
Closes #19093
PR Close #20719
2017-12-07 17:16:27 -08:00
Matias Niemelä
590d93b30d
feat(animations): re-introduce support for transition matching functions ( #20723 )
...
Closes #18959
PR Close #20723
2017-12-07 17:16:09 -08:00
Alex Eagle
ef534c0cc1
build: upgrade bazel rules to latest ( #20768 )
...
Add enough BUILD files to make it possible to
`bazel build packages/core/test`
Also re-format BUILD.bazel files with Buildifier.
Add a CI lint check that they stay formatted.
PR Close #20768
2017-12-07 11:27:50 -08:00
Matias Niemelä
b78ada198a
fix(animations): ensure DOM is cleaned up after multiple @trigger leave animations finish ( #20740 )
...
Closes #20541
PR Close #20740
2017-12-06 07:02:42 -08:00
Matias Niemelä
c2b3792a3b
fix(animations): ensure multi-level leave animations work ( #19455 )
...
PR Close #19455
2017-11-28 18:24:41 -06:00
Matias Niemelä
b2a586cee1
fix(animations): ensure multi-level enter animations work ( #19455 )
...
PR Close #19455
2017-11-28 18:24:40 -06:00
Miško Hevery
add5953aa1
Revert "fix(animations): ensure multi-level enter animations work ( #19455 )"
...
This reverts commit dd6237ecd9
.
2017-11-28 15:08:44 -06:00
Miško Hevery
6b4c24020d
Revert "fix(animations): ensure multi-level leave animations work ( #19455 )"
...
This reverts commit 1366762d12
.
2017-11-28 15:08:31 -06:00
Matias Niemelä
1366762d12
fix(animations): ensure multi-level leave animations work ( #19455 )
...
PR Close #19455
2017-11-27 16:59:47 -06:00
Matias Niemelä
dd6237ecd9
fix(animations): ensure multi-level enter animations work ( #19455 )
...
PR Close #19455
2017-11-27 16:59:46 -06:00
Matias Niemelä
ffb6dbeefe
fix(animations): always fire start and done callbacks in order for noop animations ( #20570 )
...
PR Close #20570
2017-11-22 12:36:28 -06:00
Matias Niemelä
0e012c9669
fix(animations): always fire inner trigger callbacks even if blocked by parent animations ( #19753 )
...
Closes #19100
PR Close #19753
2017-11-22 10:38:02 -06:00
Chuck Jazdzewski
dcfffbf828
build: fix build failures ( #20470 )
2017-11-15 22:33:30 -08:00
Alex Eagle
5ec1717c58
fix: Update test code to type-check under TS 2.5 ( #20175 )
...
PR Close #20175
2017-11-15 18:12:16 -06:00
Miško Hevery
f8658cdc38
Revert "fix(animations): always fire inner trigger callbacks even if blocked by parent animations ( #19753 )"
...
This reverts commit d47b2a6f70
.
2017-11-15 17:04:22 -06:00
Matias Niemelä
d47b2a6f70
fix(animations): always fire inner trigger callbacks even if blocked by parent animations ( #19753 )
...
Closes #19100
PR Close #19753
2017-11-14 15:59:47 -08:00
Matias Niemelä
20aafff092
fix(animations): ensure final state() styles are applied within @.disabled animations ( #20267 )
...
Closes #20266
PR Close #20267
2017-11-14 11:01:11 -08:00
Chuck Jazdzewski
24cf8b3269
fix(core): ensure init lifecycle events are called ( #20258 )
...
Throwing an exception in a lifecycle event will delay but not
prevent an Init method, such as `ngOnInit`, `ngAfterContentInit`,
or `ngAfterViewInit`, from being called. Also, calling `detectChanges()`
in a way that causes duplicate change detection (such as a
child component causing a parent to call `detectChanges()` on its
own `ChangeDetectorRef`, will no longer prevent change `ngOnInit`,
`ngAfterContentInit` and `ngAfterViewInit` from being called.
With this change lifecycle methods are still not guarenteed to be
called but the Init methods will be called if at least one change
detection pass on its view is completed.
Fixes : #17035
PR Close #20258
2017-11-10 13:47:39 -08:00
Victor Berchet
6e8e3bd248
refactor(core): misc changes and integrate review feedback on #19996
...
closes #20224
2017-11-06 14:13:02 -08:00
Tobias Bosch
a460066972
feat(compiler): introduce `TestBed.overrideTemplateUsingTestingModule`
...
This allows to overwrite templates for JIT and AOT components alike.
In contrast to `TestBed.overrideTemplate`, the template is compiled
in the context of the testing module, allowing to use other testing
directives.
Closes #19815
2017-11-06 14:12:30 -08:00
Tobias Bosch
05d96dc507
feat(core): allow to pass in aot summaries also to `TestBed.configureTestingModule`
...
Also adds caching for summaries.
Closes #19817 .
2017-11-06 14:12:30 -08:00
Victor Berchet
f0764016f9
revert: feat(core): add source to `StaticInjectorError` message ( #19482 ) ( #20171 )
...
This reverts commit faa621218e
.
2017-11-03 14:51:06 -07:00
Olivier Combe
faa621218e
feat(core): add source to `StaticInjectorError` message ( #19482 )
2017-11-03 11:14:05 -07:00
Matias Niemelä
c0cc6eeca1
test(animations): ensure :enter callbacks fire on container insertion ( #19674 )
...
PR Close #19674
2017-10-18 11:18:08 -07:00
Tobias Bosch
30ecb6e88a
Revert "test(animations): ensure :enter callbacks fire on container insertion ( #19674 )"
...
This reverts commit 41f57affb6
.
As it was synched together with 5a9ed2de27
which broke an internal test.
2017-10-18 09:57:56 -07:00
Tobias Bosch
8d735da5d8
Revert "fix(animations): always fire inner trigger callbacks even if blocked by parent animations ( #19753 )"
...
This reverts commit 5a9ed2de27
.
As it broke an internal test.
2017-10-18 09:56:59 -07:00
Matias Niemelä
5a9ed2de27
fix(animations): always fire inner trigger callbacks even if blocked by parent animations ( #19753 )
...
Closes #19100
PR Close #19753
2017-10-17 20:57:57 -07:00
Matias Niemelä
41f57affb6
test(animations): ensure :enter callbacks fire on container insertion ( #19674 )
...
PR Close #19674
2017-10-17 20:57:48 -07:00
Matias Niemelä
d035175cdb
fix(animations): ensure inner :leave animations do not remove node when skipped ( #19532 ) ( #19693 )
...
PR Close #19693
2017-10-16 11:13:58 -07:00
Matias Niemelä
f42d317d2f
fix(animations): ensure animateChild() works with all inner leave animations ( #19006 ) ( #19532 ) ( #19693 )
...
PR Close #19693
2017-10-16 11:13:58 -07:00
Chuck Jazdzewski
46992b4bda
Revert "fix(animations): ensure animateChild() works with all inner leave animations ( #19006 ) ( #19532 )"
...
This reverts commit 9130505b57
.
2017-10-11 10:51:52 -07:00