JiaLi.Passion
f791e9f081
fix(core): fix #20582 , don't need to wrap zone in location change listener ( #20640 )
...
PR Close #20640
2018-02-05 13:06:22 -08:00
vsavkin
c40ae7f7cf
feat(router): add navigationSource and restoredState to NavigationStart event ( #21728 )
...
Currently, NavigationStart there is no way to know if an navigation was triggered imperatively or via the location change. These two use cases should be handled differently for a variety of use cases (e.g., scroll position restoration). This PR adds a navigation source field and restored navigation id (passed to navigations triggered by a URL change).
PR Close #21728
2018-01-29 10:22:59 -08:00
Jason Aden
ede9cb7c2f
Revert: "feat(router): add navigationSource and restoredState to NavigationStart event ( #21728 )"
...
This reverts commit 3b7bab7d22
. Will be re-merged after fixing integration of minor breaking change.
2018-01-26 16:24:56 -08:00
Patrick Shields
d964491f2a
fix(router): remove @internal tag on ParamInheritanceType ( #21773 )
...
This is a more defensive approach to ensure that references to
ParamInheritanceType from the published declarations do not cause
compilation errors when compiling Angular from the published packages.
Fixes #21456
PR Close #21773
2018-01-26 10:28:33 -08:00
vsavkin
3b7bab7d22
feat(router): add navigationSource and restoredState to NavigationStart event ( #21728 )
...
Currently, NavigationStart there is no way to know if an navigation was triggered imperatively or via the location change. These two use cases should be handled differently for a variety of use cases (e.g., scroll position restoration). This PR adds a navigation source field and restored navigation id (passed to navigations triggered by a URL change).
PR Close #21728
2018-01-26 10:25:32 -08:00
Patrick Shields
925e654a29
fix(router): don't use ParamsInheritanceStrategy in declarations ( #21574 )
...
ParamsInheritanceStrategy is internal, so any references to it from the
published .d.ts files will fail.
Fixes #21456 .
PR Close #21574
2018-01-23 21:34:37 -08:00
Jason Aden
b5934fc582
docs(router): fix missing export in docs for UrlMatcher ( #21095 )
...
Fixes #21042
PR Close #21095
2018-01-04 17:48:32 -05:00
Misko Hevery
40dfe39e64
build(router): enable bazel tests for router ( #21053 )
...
Bazel runs on newer version of RxJs than is installed in Yarn. The never version subclasses `EmptyError` in a different way which fails the `instanceof` check. This change makes the `instanceof` check more robust with respect to `EmptyError`.
PR Close #21053
2017-12-22 13:10:51 -08:00
Jason Aden
5ba1cf1063
fix(router): fix wildcard route with lazy loaded module (again) ( #18139 )
...
Closes #13848
Description:
We doesn't handle children of wildcard route properly link. It's always an empty array.
Created from #13851
PR Close #18139
2017-12-22 09:20:11 -08:00
Zaven Muradyan
5efea2f6a0
feat(router): add "paramsInheritanceStrategy" router configuration option
...
Previously, the router would merge path and matrix params, as well as
data/resolve, with special rules (only merging down when the route has
an empty path, or is component-less). This change adds an extra option
"paramsInheritanceStrategy" which, when set to 'always', makes child
routes unconditionally inherit params from parent routes.
Closes #20572 .
2017-12-20 10:06:24 -08:00
Yuan Gao
e544742156
refactor(core): Removed readonly getters and changed to readonly ( #19842 )
...
variables
PR Close #19842
2017-12-08 10:24:19 -08:00
vsavkin
d8cc09b76c
fix(router): NavigatonError and NavigationCancel should be emitted after resetting the URL ( #20803 )
...
PR Close #20803
2017-12-07 13:34:20 -08:00
Alex Eagle
5ec1717c58
fix: Update test code to type-check under TS 2.5 ( #20175 )
...
PR Close #20175
2017-11-15 18:12:16 -06:00
Mark Kennedy
a622e19df6
fix(router): 'merge' queryParamHandling strategy should be able to remove query params ( #19733 )
...
Closes #18463 , #17202
PR Close #19733
2017-11-14 11:01:04 -08:00
George Kalpakas
901436e46f
docs: fix link texts
...
Fixes #19701
PR Close #19709
2017-11-01 15:44:59 -04:00
vsavkin
d3211a2468
feat(router): add "onSameUrlNavigation" router configuration option ( #19463 )
...
PR Close #19463
2017-10-23 20:56:53 -04:00
vsavkin
adab4f3e49
fix(router): do not call `location.go` when skipping a navigation ( #19463 )
...
Closes #18036
PR Close #19463
2017-10-23 20:56:52 -04:00
vsavkin
82fed62af2
fix(router): navigating to the current location works ( #19463 )
...
Closes #13340
PR Close #19463
2017-10-23 20:56:52 -04:00
vsavkin
6f2939da62
fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )
...
Closes #18983
PR Close #19449
2017-10-18 11:17:55 -07:00
Tobias Bosch
b0c7ea8181
Revert "fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )"
...
This reverts commit c569b75249
.
As it was synched together with 5a9ed2de27
which broke an internal test.
2017-10-18 09:58:41 -07:00
vsavkin
c569b75249
fix(router): RouterLinkActive should update its state right after checking the children ( #19449 )
...
Closes #18983
PR Close #19449
2017-10-17 20:57:30 -07:00
Chuck Jazdzewski
d7eac7ee56
Revert "fix(router): navigating to the current location works ( #19463 )"
...
This reverts commit 43c5b638b9
.
2017-10-09 16:38:12 -07:00
Chuck Jazdzewski
d53b96f2a2
Revert "fix(router): do not call `location.go` when skipping a navigation ( #19463 )"
...
This reverts commit 6651541230
.
2017-10-09 16:37:31 -07:00
vsavkin
6651541230
fix(router): do not call `location.go` when skipping a navigation ( #19463 )
...
Closes #18036
PR Close #19463
2017-10-09 11:45:13 -07:00
vsavkin
43c5b638b9
fix(router): navigating to the current location works ( #19463 )
...
Closes #13340
PR Close #19463
2017-10-09 11:45:13 -07:00
Chuck Jazdzewski
8e5b582b61
Revert "fix(router): navigating to the current location works ( #19463 )"
...
This reverts commit b67d574a95
.
2017-10-06 18:15:19 -07:00
Chuck Jazdzewski
0cc87c5ba1
Revert "fix(router): do not call `location.go` when skipping a navigation ( #19463 )"
...
This reverts commit fdfa31798b
.
2017-10-06 18:15:16 -07:00
vsavkin
fdfa31798b
fix(router): do not call `location.go` when skipping a navigation ( #19463 )
...
Closes #18036
PR Close #19463
2017-10-06 15:35:25 -07:00
vsavkin
b67d574a95
fix(router): navigating to the current location works ( #19463 )
...
Closes #13340
PR Close #19463
2017-10-06 15:35:24 -07:00
Victor Berchet
6a9ce67714
Revert "refactor(core): Removed readonly getters and changed to readonly ( #19225 )"
...
This reverts commit 2b84b86fc0
.
2017-09-28 13:36:44 -07:00
Victor Savkin
a9d32a3f89
fix(router): resolve and guards should be able to reject with null and undefined ( #19418 )
...
Closes #17148
2017-09-28 11:06:08 -07:00
tinayuangao
2b84b86fc0
refactor(core): Removed readonly getters and changed to readonly ( #19225 )
...
variables
2017-09-28 09:36:29 -07:00
Olivier Combe
0f5c70d563
build: update npm dependencies ( #19328 )
...
PR Close #19328
2017-09-22 13:20:52 -07:00
cexbrayat
2c4107c531
fix(router): fix activation events toString and docs ( #19147 )
...
PR Close #19147
2017-09-20 13:52:21 -07:00
Yuan Gao
549f2254b4
refactor(core): remove getters for packages/animations, language-service, platform-browser, router ( #19151 )
...
PR Close #19151
2017-09-20 12:38:37 -07:00
Olivier Combe
a9ef858359
refactor(router): remove deprecated `RouterOutlet` properties
...
BREAKING CHANGE: `RouterOutlet` properties `locationInjector` and `locationFactoryResolver` have been removed as they were deprecated since v4.
2017-09-08 16:19:32 -04:00
Jason Aden
8f7915022c
feat(router): add ActivationStart/End events
2017-09-08 13:24:26 -04:00
Jason Aden
66f0ab0371
fix(router): adjust ChildActivation events to only fire when the child is actually changing ( #19043 )
...
* The problem was with the `fireChildActivationStart` function. It was taking a `path` param, which was an
array of `ActivatedRouteSnapshot`s. The function was being fired for each piece of the route that was being
activated. This resulted in far too many `ChildActivationStart` events being fired, and being fired on routes
that weren't actually getting activated. This change fires the event only for those routes that are actually
being activated.
fixes #18942
PR Close #19043
2017-09-05 15:46:29 -05:00
Jason Aden
dce36751f5
refactor(router): remove RouteEvent base class ( #19043 )
...
* Introduced with #18407 , `RouteEvents` don't actually have a common constructor. Reverting here to be able to add new functionality to ChildActivation events.
PR Close #19043
2017-09-05 15:46:29 -05:00
Miško Hevery
a80ecf6a77
Revert "refactor(router): remove deprecated `initialNavigation` options ( #18781 )"
...
This reverts commit d76761bf01
.
2017-08-22 18:39:06 -05:00
Miško Hevery
7236095f6f
Revert "refactor(router): remove deprecated `RouterOutlet` properties ( #18781 )"
...
This reverts commit d1c4a94bbf
.
2017-08-22 18:38:53 -05:00
Olivier Combe
d1c4a94bbf
refactor(router): remove deprecated `RouterOutlet` properties ( #18781 )
...
BREAKING CHANGE: `RouterOutlet` properties `locationInjector` and `locationFactoryResolver` have been removed as they were deprecated since v4.
PR Close #18781
2017-08-22 16:53:00 -05:00
Olivier Combe
d76761bf01
refactor(router): remove deprecated `initialNavigation` options ( #18781 )
...
BREAKING CHANGE: the values `true`, `false`, `legacy_enabled` and `legacy_disabled` for the router parameter `initialNavigation` have been removed as they were deprecated. Use `enabled` or `disabled` instead.
PR Close #18781
2017-08-22 16:53:00 -05:00
Chuck Jazdzewski
3a227a1f6f
refactor(router): compile router cleanly with TypeScript 2.4 ( #18465 )
2017-08-02 17:32:02 -07:00
Jan Peer Stöcklmair
81cb5bc3a7
docs(router): fix typo ( #18479 )
2017-08-02 17:31:09 -07:00
Jason Aden
49cd8513e4
feat(router): add events tracking activation of individual routes
...
* Adds `ChildActivationStart` and `ChildActivationEnd`
* Adds test to verify the PreActivation phase of routing
2017-08-01 10:44:00 -07:00
Victor Berchet
9479a106bb
build: enable TSLint on the packages folder
2017-07-31 15:47:57 -07:00
Miško Hevery
a7f2468184
Revert "fix(router): should throw when lazy loaded module doesn't define any routes ( #15001 )"
...
This reverts commit 82923a381d
.
2017-07-27 10:53:01 -07:00
Dzmitry Shylovich
086f4aa72c
fix(router): child CanActivate guard should wait for parent to complete ( #18110 )
...
Closes #15670
PR Close #18110
2017-07-26 17:11:22 -05:00
Dzmitry Shylovich
82923a381d
fix(router): should throw when lazy loaded module doesn't define any routes ( #15001 )
...
Closes #14596
PR Close #15001
2017-07-26 17:11:07 -05:00