angular-cn

Author SHA1 Message Date

Author	SHA1	Message	Date
Paul Gschwendtner	fa6cbb3ffe	fix(ivy): ng-container with ViewContainerRef creates two comments (#30611 ) With Ivy, injecting a `ViewContainerRef` for a `<ng-container>` element results in two comments generated in the DOM. One comment as host element for the `ElementContainer` and one for the generated `LContainer` which is needed for the created `ViewContainerRef`. This is problematic as developers expect the same anchor element for the `LContainer` and the `ElementContainer` in order to be able to move the host element of `<ng-container>` without leaving the actual `LContainer` anchor element at the original location. This worked differently in View Engine and various applications might depend on the behavior where the `ViewContainerRef` shares the anchor comment node with the host comment node of the `<ng-container>`. For example `CdkTable` from `@angular/cdk` moves around the host element of a `<ng-container>` and also expects embedded views to be inserted next to the moved `<ng-container>` host element. See: `f8be5329f8/src/cdk/table/table.ts (L999-L1016)` Resolves FW-1341 PR Close #30611	2019-05-22 16:25:22 -07:00
Andrew Kushnir	02523debe5	fix(ivy): handle pipes in i18n attributes properly (#30573 ) Prior to this change we processed binding expression (including bindings with pipes) in i18n attributes before we generate update instruction. As a result, slot offsets for pipeBind instructions were calculated incorrectly. Now we perform binding expression processing when we generate "update block" instructions, so offsets are calculated correctly. PR Close #30573	2019-05-22 16:23:18 -07:00
Olivier Combe	0cf09fc981	test(ivy): use `TestBed` for render3 i18n tests (#30352 ) PR Close #30352	2019-05-13 10:51:31 -07:00

Paul Gschwendtner

fa6cbb3ffe

fix(ivy): ng-container with ViewContainerRef creates two comments (#30611 )

With Ivy, injecting a `ViewContainerRef` for a `<ng-container>` element
results in two comments generated in the DOM. One comment as host
element for the `ElementContainer` and one for the generated `LContainer`
which is needed for the created `ViewContainerRef`.

This is problematic as developers expect the same anchor element for
the `LContainer` and the `ElementContainer` in order to be able to move
the host element of `<ng-container>` without leaving the actual
`LContainer` anchor element at the original location.

This worked differently in View Engine and various applications might
depend on the behavior where the `ViewContainerRef` shares the anchor
comment node with the host comment node of the `<ng-container>`. For
example `CdkTable` from `@angular/cdk` moves around the host element of
a `<ng-container>` and also expects embedded views to be inserted next
to the moved `<ng-container>` host element.

See: f8be5329f8/src/cdk/table/table.ts (L999-L1016)

Resolves FW-1341

PR Close #30611

2019-05-22 16:25:22 -07:00

Andrew Kushnir

02523debe5

fix(ivy): handle pipes in i18n attributes properly (#30573 )

Prior to this change we processed binding expression (including bindings with pipes) in i18n attributes before we generate update instruction. As a result, slot offsets for pipeBind instructions were calculated incorrectly. Now we perform binding expression processing when we generate "update block" instructions, so offsets are calculated correctly.

PR Close #30573

2019-05-22 16:23:18 -07:00

Olivier Combe

0cf09fc981

test(ivy): use `TestBed` for render3 i18n tests (#30352 )

PR Close #30352

2019-05-13 10:51:31 -07:00

3 Commits