Igor Minar
f7ba4b2ff9
fix(ivy): remove obsolete ng_module code for global and jit mode ( #27278 )
...
These paths are no longer needed / used.
I had to disable one jit mode spec because it fails now that we actually run it.
I root caused the jit test failure as missing forwardRef support. See FW-645.
PR Close #27278
2018-11-27 10:30:58 -08:00
Igor Minar
d1227ec800
ci(ivy): packages/core/test/render3 now passes with ivy aot ( #27278 )
...
PR Close #27278
2018-11-27 10:30:58 -08:00
Kristiyan Kostadinov
4622d0b23a
fix(ivy): detach ViewRef from ApplicationRef on destroy ( #27276 )
...
Currently we store the `_appRef` when a `ViewRef` is attached, however we don't use it for anything. These changes use it to detach the view from the `ApplicationRef` when it is destroyed. These changes also fix that the `ComponentRef` doesn't remove its `ViewRef` on destroy.
PR Close #27276
2018-11-27 10:24:53 -08:00
Pawel Kozlowski
0487fbe236
fix(ivy): throw a descriptive error when trying to insert / move destroyed view ( #27289 )
...
PR Close #27289
2018-11-27 10:23:14 -08:00
Kara Erickson
d0e8020506
fix(ivy): blueprints should be synced whenever they are off ( #27281 )
...
PR Close #27281
2018-11-27 10:22:03 -08:00
Kara Erickson
a7ba05ad82
fix(ivy): fix directive instantiation at slots above 2^12 ( #27280 )
...
PR Close #27280
2018-11-27 10:20:02 -08:00
Olivier Combe
2fce701ced
feat(ivy): enable ng-reflect debug attributes ( #27268 )
...
PR Close #27268
2018-11-27 10:18:51 -08:00
Olivier Combe
32157115da
fix(ivy): register ModuleWithProviders when deduplicating imported modules ( #27268 )
...
PR Close #27268
2018-11-27 10:18:51 -08:00
Marc Laval
c2f30542e7
fix(ivy): should support components without selector ( #27169 )
...
PR Close #27169
2018-11-27 10:17:35 -08:00
JoostK
d767e0b2c0
fix(ivy): consider providers for view/content queries ( #27156 )
...
In ViewEngine it is possible to query for a token that is provided by
a directive that is in scope. See StackBlitz for example:
https://stackblitz.com/edit/ng-viewengine-viewchild-providers
Material uses this pattern with its `MatFormFieldControl` setup, see
https://bit.ly/2zgCUxD for documentation.
PR Close #27156
2018-11-27 10:16:57 -08:00
Pawel Kozlowski
9e5223eaba
test(core): add more root causes for TestBed tests failures ( #27236 )
...
PR Close #27236
2018-11-26 09:24:32 -08:00
Pawel Kozlowski
3c9ad1d231
fix(ivy): inject null for missing attributes ( #27237 )
...
PR Close #27237
2018-11-26 09:23:56 -08:00
Andrew Kushnir
dc300c5c41
feat(ivy): render flags support in host bindings function (FW-649) ( #27204 )
...
PR Close #27204
2018-11-21 15:33:47 -08:00
JoostK
c8c8648abf
fix(ivy): prevent ngcc from referencing missing ɵsetClassMetadata ( #27055 )
...
When ngtsc compiles @angular/core, it rewrites core imports to the
r3_symbols.ts file that exposes all internal symbols under their
external name. When creating the FESM bundle, the r3_symbols.ts file
causes the external symbol names to be rewritten to their internal name.
Under ngcc compilations of FESM bundles, the indirection of
r3_symbols.ts is no longer in place such that the external names are
retained in the bundle. Previously, the external name `ɵdefineNgModule`
was explicitly declared internally to resolve this issue, but the
recently added `setClassMetadata` was not declared as such, causing
runtime errors.
Instead of relying on the r3_symbols.ts file to perform the rewrite of
the external modules to their internal variants, the translation is
moved into the `ImportManager` during the compilation itself. This
avoids the need for providing the external name manually.
PR Close #27055
2018-11-21 09:20:11 -08:00
Pawel Kozlowski
d666370e16
test(core): add JIRA references for root-casuse ivy TestBed failures ( #27196 )
...
PR Close #27196
2018-11-21 09:18:54 -08:00
Misko Hevery
e56c8bf8d1
fix(ivy): align discovery methods for consistency ( #27117 )
...
PR Close #27117
2018-11-20 11:44:14 -08:00
Miško Hevery
ca40565f9a
fix(ivy): hack implementation of host styles ( #27180 )
...
PR Close #27180
2018-11-20 11:43:29 -08:00
Olivier Combe
bf3beb5959
fix(ivy): set ng-version attribute on root component ( #27175 )
...
PR Close #27175
2018-11-20 10:43:51 -08:00
Olivier Combe
20729b3378
fix(ivy): deduplicate imported modules in r3_injector ( #27102 )
...
PR Close #27102
2018-11-19 09:20:39 -08:00
Matias Niemelä
20ea5b5634
refactor(ivy): ensure directive host bindings use the styling algorithm ( #27145 )
...
PR Close #27145
2018-11-17 10:12:47 -08:00
Misko Hevery
4222b63639
Revert "refactor(ivy): ensure directive host bindings use the styling algorithm ( #27134 )"
...
This reverts commit b5dbf5154e19088aa3fde143cf72892d43170f71.
2018-11-16 17:55:41 -08:00
Matias Niemelä
b5dbf5154e
refactor(ivy): ensure directive host bindings use the styling algorithm ( #27134 )
...
PR Close #27134
2018-11-16 16:10:45 -08:00
Andrew Kushnir
92e80af875
feat(ivy): ICU support for Ivy ( #26794 )
...
PR Close #26794
2018-11-16 16:09:30 -08:00
JoostK
60800da6c1
fix(ivy): export elementContainerStart/End instructions ( #27053 )
...
PR Close #27053
2018-11-16 12:19:18 -08:00
Marc Laval
848f4148c0
fix(ivy): DI should work when no element injector on starting node ( #27133 )
...
PR Close #27133
2018-11-16 09:26:29 -08:00
crisbeto
6574e61062
test(ivy): skip useJit tests with Ivy ( #27067 )
...
Currently the `useJit` option from `TestBed.configureCompiler` isn't supported. These changes rework the existing test suites not to pass in `useJit` when running with Ivy.
PR Close #27067
2018-11-15 21:19:21 -08:00
Kara Erickson
ee12e725c0
fix(ivy): component ref injector should support change detector ref ( #27107 )
...
PR Close #27107
2018-11-15 21:18:24 -08:00
Olivier Combe
e22a302cad
feat(ivy): support for i18n & ICU expressions ( #27101 )
...
PR Close #27101
2018-11-14 16:22:01 -08:00
Pawel Kozlowski
ce5242462b
fix(ivy): implement rootNodes getter on ViewRef ( #27095 )
...
PR Close #27095
2018-11-14 12:28:03 -08:00
Marc Laval
1c9e526a83
fix(ivy): use the root view injector when resolving dependencies ( #27090 )
...
PR Close #27090
2018-11-14 12:26:36 -08:00
Miško Hevery
f8f1168fa6
Revert "feat(ivy): support for i18n & ICU expressions ( #26275 )"
...
This reverts commit a63fd2d0f5f867ee17bf991a72ccbe6d6fa76566.
2018-11-14 10:23:21 -08:00
Kara Erickson
f0c4f31771
fix(ivy): should export lifecycle hooks feature ( #27082 )
...
PR Close #27082
2018-11-13 16:17:30 -08:00
Olivier Combe
a63fd2d0f5
feat(ivy): support for i18n & ICU expressions ( #26275 )
...
PR Close #26275
2018-11-13 14:50:30 -08:00
Kara Erickson
bc652a2943
fix(ivy): jit compilation should support content queries with type predicates ( #27068 )
...
PR Close #27068
2018-11-13 12:18:13 -08:00
Kara Erickson
e6e590479e
fix(ivy): support forward refs in @Inject annotations ( #27069 )
...
PR Close #27069
2018-11-13 12:17:18 -08:00
Kara Erickson
123da1a8c2
test(ivy): split out provider tests ( #27069 )
...
PR Close #27069
2018-11-13 12:17:18 -08:00
Judy Bogart
9741f5b8cf
docs: new doc for core directives ( #26923 )
...
PR Close #26923
2018-11-13 10:57:56 -08:00
Kristiyan Kostadinov
5247594e86
fix(ivy): add support for providers in TestBed.configureCompiler ( #27066 )
...
Adds support for the `providers` that are passed in through `TestBed.configureCompiler` and scopes the error only if the consumer has passed in `useJit`.
PR Close #27066
2018-11-12 15:33:56 -08:00
Kara Erickson
8b9249a670
fix(ivy): host bindings should support content children and content hooks ( #27065 )
...
PR Close #27065
2018-11-12 14:26:06 -08:00
Kara Erickson
1810cdf2c3
fix(ivy): compiler should generate restoreView() for local refs in listeners ( #27034 )
...
PR Close #27034
2018-11-12 12:50:58 -08:00
Kristiyan Kostadinov
e5c9f7a507
fix(ivy): provide NgZone to ComponentRef ( #26898 )
...
Fixes the r3 `TestBed` not providing an `NgZone` to the `ComponentFixture`.
PR Close #26898
2018-11-12 12:47:07 -08:00
Kara Erickson
78b6f88cb3
fix(ivy): TestBed should use an NgZone ( #27015 )
...
PR Close #27015
2018-11-09 09:56:36 -08:00
Kara Erickson
552836ebf0
fix(ivy): merged host bindings functions should take superclass hostVars into account ( #27013 )
...
PR Close #27013
2018-11-09 09:55:47 -08:00
Kara Erickson
2f36a9591d
fix(ivy): providers should not be inherited ( #27013 )
...
PR Close #27013
2018-11-09 09:55:47 -08:00
Igor Minar
499e303ea3
test(ivy): add global utils to the public_api_guard test ( #27008 )
...
This API is part of our public api surface and needs to be monitored by the public_api_guard.
I also had to go back and mark all of the exported functions with @publicApi jsdoc tag.
PR Close #27008
2018-11-08 15:37:11 -08:00
Matias Niemelä
e618032d53
feat(ivy): introduce getPlayers() to global utils ( #27008 )
...
PR Close #27008
2018-11-08 15:37:11 -08:00
Andrew Kushnir
3567e81175
fix(ivy): restore missing match operation in View and Content Queries ( #26847 )
...
PR Close #26847
2018-11-07 16:29:19 -08:00
Kara Erickson
9e26216c40
fix(ivy): compiler should generate bindings to host attrs properly ( #26973 )
...
PR Close #26973
2018-11-07 11:09:31 -08:00
Miško Hevery
53e4e0c1a3
fix(ivy): Enable AoT tests to run on CI; disable failing tests ( #26975 )
...
PR Close #26975
2018-11-07 10:35:20 -08:00
Miško Hevery
5e769d9a25
fix(ivy): add nocollapse to ngInjectableDef for closure compatibility ( #26975 )
...
PR Close #26975
2018-11-07 10:35:20 -08:00
