57 Commits

Author SHA1 Message Date
Kristiyan Kostadinov
2ab194c999 test(ivy): remove tree tests from blocklist ()
Removes all of the tests fixed by https://github.com/angular/material2/pull/15504 from the blocklist.

PR Close 
2019-03-18 15:08:18 -04:00
Matias Niemelä
1877e6c3f8 fix(ivy): ensure template styles/classes are applied before directives are instantiated ()
Angular Ivy interprets inline static style/class attribute values as instructions that
are processed whilst an element gets created. Because these inline style values are
referenced by style/class bindings, their inline style values are applied at a later
stage. Despite them being eventually applied, their values should be applied earlier
before any directives are instantiated so that directive code can rely on any inline
style/class changes.

This patch ensures that all static style/class attribute values are applied (rendered)
on the element before directives are instantiated.

Jira Issue: FW-1133

PR Close 
2019-03-14 18:22:50 -04:00
Kristiyan Kostadinov
fe448e8222 test(ivy): update root causes for stepper ()
Removes the stepper-related tests from the blocklist which were fixed by https://github.com/angular/material2/pull/15486.

PR Close 
2019-03-14 16:48:20 -04:00
Marc Laval
a3e105487d test(ivy): update blocklist to turn on passing tests ()
PR Close 
2019-03-14 11:36:26 -04:00
Pawel Kozlowski
1f0eadfab6 test(ivy): enable passing Material tests ()
PR Close 
2019-03-14 03:07:01 -04:00
Kara Erickson
955e4e704e test(ivy): update blocklist to turn on table tests ()
PR Close 
2019-03-12 18:30:47 -07:00
Pawel Kozlowski
9d4b7d7d41 test(ivy): enable passing Material tests ()
PR Close 
2019-03-12 14:09:19 -07:00
Marc Laval
3f32c0e674 test(ivy): diagnose root causes of failures in CdkTable and MatTable ()
PR Close 
2019-03-12 14:07:50 -07:00
Marc Laval
af52536419 test(ivy): update root cause of failures in MatSnackBar ()
PR Close 
2019-03-12 12:01:12 -07:00
Andrew Seguin
4b39bdf7e5 test(ivy): add table root cause ()
PR Close 
2019-03-11 15:32:26 -07:00
Kristiyan Kostadinov
99aa9674b2 test(ivy): remove chip list tests from blocklist ()
Updates the blocklist to enable the tests that were fixed by https://github.com/angular/material2/pull/15427.

This PR resolves FW-1145.

PR Close 
2019-03-11 11:14:51 -07:00
Marc Laval
4b9eb6185f test(ivy): diagnose root causes of failures in CdkTree and MatTree ()
PR Close 
2019-03-11 09:20:15 -07:00
Kristiyan Kostadinov
a746b5b1ea fix(ivy): inherited host listeners called twice ()
Fixes host listeners being inherited twice when going through `setClassMetadata`.

This PR resolves FW-1142.

PR Close 
2019-03-08 11:57:58 -08:00
Andrew Seguin
63d18064fe test(ivy): add table root causes ()
PR Close 
2019-03-07 16:25:33 -08:00
Kara Erickson
3ef2002bd8 test(ivy): turn on passing Material tests for cdk-tree ()
PR Close 
2019-03-07 10:26:44 -08:00
Andrew Seguin
479ae51d1f test(ivy): update native table root causes ()
PR Close 
2019-03-07 09:39:01 -08:00
Marc Laval
eccbc785b3 fix(ivy): ViewRef.detachFromAppRef should clean the DOM ()
PR Close 
2019-03-07 08:56:26 -08:00
Pawel Kozlowski
15e84950ec test(ivy): diagnose root causes for MatInput ()
PR Close 
2019-03-07 07:29:28 -08:00
Kara Erickson
f856a6597b test(ivy): turn on passing Material tests for mat-select ()
PR Close 
2019-03-06 15:42:42 -08:00
Marc Laval
0bd4261f23 test(ivy): diagnose root causes of failures in MatSnackBar ()
PR Close 
2019-03-06 11:03:18 -08:00
Pawel Kozlowski
f96efd1c98 test(ivy): enable passing MatChipList tests ()
PR Close 
2019-03-06 11:02:47 -08:00
Kara Erickson
5fded9fcc8 test(ivy): restore root causes that were accidentally deleted ()
PR Close 
2019-03-04 17:39:18 -08:00
Matias Niemelä
78adcfe0ee fix(ivy): ensure static styling is properly inherited into child components ()
Angular supports having a component extend off of a parent component.
When this happens, all annotation-level data is inherited including styles
and classes. Up until now, Ivy only paid attention to static styling
values on the parent component and not the child component. This patch
ensures that both the parent's component and child component's styling
data is merged and rendered accordingly.

Jira Issue: FW-1081

PR Close 
2019-03-04 13:36:19 -08:00
Kristiyan Kostadinov
842d615928 test(ivy): update root causes for chip list ()
Updates the remaining unknown root causes for `MatChipList`.

This PR resolves FW-1125.

PR Close 
2019-03-04 10:08:28 -08:00
Kristiyan Kostadinov
a352b73962 test(ivy): update root causes for drag drop ()
Updates the root causes for the failures in `CdkDrag`.

This PR resolves FW-1115.

PR Close 
2019-03-04 10:07:55 -08:00
Kristiyan Kostadinov
fa82d2d6f1 test(ivy): update root causes for tooltip ()
Updates the root causes for the MatTooltip failures.

These changes resolve FW-1129.

PR Close 
2019-03-04 10:07:18 -08:00
Kristiyan Kostadinov
83ba587c18 test(ivy): update sidenav root causes ()
Updates a couple of the root causes for `MatSidenav` which ended up being a different issue.

PR Close 
2019-03-04 10:06:43 -08:00
Kristiyan Kostadinov
c0757d1d44 fix(ivy): attached flag not being reset when view is destroyed ()
Currently we only reset the `Attached` flag of a view if it is detached through its parent, however this means that if a root view is destroyed, its flag will never be reset. This manifested itself in one of the Material tests where we were destroying the root view.

This PR resolves FW-1130.

PR Close 
2019-03-01 16:56:03 -08:00
Kara Erickson
7ac58bec8a fix(ivy): move views that are already attached in insert() ()
Currently if a user accidentally calls ViewContainerRef.insert() with
a view that has already been attached, we do not clean up the references
properly, so we create a view tree with a cycle. This causes an infinite
loop when the view is destroyed.

This PR ensures that we fall back to ViewContainerRef.move() behavior
if we try to insert a view that is already attached. This fixes the
cycle and honors the user intention.

PR Close 
2019-03-01 15:17:24 -08:00
Kristiyan Kostadinov
daf8251998 test(ivy): update root causes for expansion panel and accordion ()
Removes some tests, that were failing due to static queries, from the blocklist. Related Material PR https://github.com/angular/material2/pull/15330.

PR Close 
2019-02-27 14:00:55 -08:00
Kara Erickson
b8d87490f5 test(ivy): record root cause of CdkVirtualScrollViewport failures ()
PR Close 
2019-02-27 10:24:04 -08:00
Kristiyan Kostadinov
41de05e1ae test(ivy): update select root causes ()
Updates the root causes for the `MatSelect` failures. A few of them were fixed by https://github.com/angular/material2/pull/15320.

PR Close 
2019-02-26 16:58:54 -08:00
Marc Laval
dc9f0af080 fix(ivy): static host classes and styles should work on root component ()
PR Close 
2019-02-26 13:29:36 -08:00
Marc Laval
8f8f9a6e61 fix(ivy): ngtsc should correctly bind to context in nested template with many bindings ()
PR Close 
2019-02-26 11:54:13 -08:00
Kristiyan Kostadinov
25a2fef303 fix(ivy): ViewRef.rootNodes not including projected nodes ()
Currently if an embedded view contains projected nodes, its `rootNodes` array will include `null` instead of the root nodes inside the projection slot. This manifested itself in one of the Material unit tests where we stamp out a template and then move its `rootNodes` into the overlay container.

This PR is related to FW-1087.

PR Close 
2019-02-26 10:49:01 -08:00
Kristiyan Kostadinov
dbd9ecfd4c test(ivy): update sidenav and drawer root causes ()
Updates the root causes for the `MatDrawer` and `MatSidenav` tests. All of the `MatDrawer` failures were fixed by https://github.com/angular/material2/pull/15300.

PR Close 
2019-02-26 10:48:32 -08:00
Kristiyan Kostadinov
9f7a9c607e test(ivy): update root causes for material menu ()
Updates the root causes for the remaining `MatMenu` tests. Note that two tests are omitted from this PR, because one will be fixed by https://github.com/angular/angular/pull/28951 and the other one depends on static queries and will be refactored by https://github.com/angular/material2/pull/15289.

PR Close 
2019-02-25 08:16:52 -08:00
Marc Laval
9dac04ff50 fix(ivy): ngOnChanges hooks should be inherited from grand-superclasses ()
PR Close 
2019-02-22 12:00:15 -08:00
Marc Laval
33f71e8ce3 test(ivy): diagnose root causes of failures in Dialog and MatDialog ()
PR Close 
2019-02-22 08:58:50 -08:00
Kristiyan Kostadinov
32ae84da28 fixup! fix(ivy): incorrectly remapping certain properties that refer to inputs ()
PR Close 
2019-02-21 17:59:50 -08:00
Kara Erickson
d8704a3069 test(ivy): turn on passing Material tests for paginator ()
PR Close 
2019-02-21 12:34:55 -08:00
Kristiyan Kostadinov
e1aaa7ec48 fix(ivy): component destroy hook called twice when configured as provider ()
Fixes the `ngOnDestroy` hook on a component or directive being called twice, if the type is also registered as a provider.

This PR resolves FW-1010.

PR Close 
2019-02-21 09:34:26 -08:00
Kara Erickson
0ea216b993 test(ivy): update material blocklist with root causes, remove passing tests ()
PR Close 
2019-02-21 07:46:57 -08:00
Kara Erickson
d0b6622b9a test(ivy): turn on more passing Material tests ()
This commit removes more test from the Material blocklist so that
they will run on CI. After static query support was added, they
are no longer failing.

PR Close 
2019-02-20 16:49:00 -08:00
Kara Erickson
68da4658ff test(ivy): update material blocklist to turn on passing tests ()
We added the static flag to some dialog queries and new tests are passing.

PR Close 
2019-02-20 11:25:16 -08:00
Kara Erickson
669b4410f2 test(ivy): update material golden file to turn on passing tests ()
We marked some queries in MatTab as static, which made some
more Material tests pass in CI.

PR Close 
2019-02-19 22:27:29 -08:00
Kristiyan Kostadinov
63e5d2787b fix(ivy): rethrow event handler errors in tests ()
Currently errors thrown inside event handler in Ivy are caught and forwarded to the `ErrorHandler`, however this means that if they happen during a unit test, the test won't fail. These changes add a test-specific `ErrorHandler` that throws the error rather than logging it out.

PR Close 
2019-02-14 19:26:56 +00:00
Pawel Kozlowski
6fa4235543 test(ivy): enable passing Material tests ()
PR Close 
2019-02-13 12:12:45 -08:00
Andrew Kushnir
553f80ff46 fix(ivy): set proper implementation for module injector ()
Prior to this change we used current injector implementation for module injector, which was causing problems and produces circular dependencies in case the same token is referenced (with @SkipSelf flag) in the `deps` array. The origin of the problem was that once `directiveInject` implementation becomes active, it was used for module injector as well, thus searching deps in Component/Directive DI scope. This fix sets `injectInjectorOnly` implementation for module injector to resolve the problem.

PR Close 
2019-02-13 12:05:13 -08:00
crisbeto
1b82e11e69 test(ivy): update root causes for autocomplete tests ()
Updates the root cause notes for the Material autocomplete tests.

This PR resolves FW-1017.

PR Close 
2019-02-12 09:47:20 -08:00