11670 Commits

Author SHA1 Message Date
Pawel Kozlowski
dbdbbdbe86 fix(ivy): support ng-container inside another ng-container ()
PR Close 
2018-08-07 11:48:42 -07:00
Alex Rickabaugh
fefc860f35 fix(ivy): fix bug with banana-in-a-box expressions in nested templates ()
Inside of a nested template, an attempt to generate code for a banana-
in-a-box expression would cause a crash in the _AstToIrVisitor, as it
was not handling the case where a write would be generated to a local
variable.

This change supports such a mode of operation.

PR Close 
2018-08-07 11:45:32 -07:00
Greg Magolan
02e201ab1a fix: add mappings for ngfactory & ngsummary files to their module names in aot summary resolver ()
PR Close 
2018-08-07 11:13:28 -07:00
Guillermo Facundo Colunga
7bf5a43385 docs: refining code of tutorial 7 routing ()
Removed the dead code from hero-detail.component.ts

Fixes 

PR Close 
2018-08-07 11:08:53 -07:00
Kristoffer Nording
2fe05abbc4 docs: update resources to include UI-jar ()
PR Close 
2018-08-07 11:07:38 -07:00
George Kalpakas
2505c077d7 test(upgrade): reduce flaky-ness by increasing timeout ()
PR Close 
2018-08-06 14:52:50 -07:00
George Kalpakas
066fc6a0ca refactor(upgrade): improve internal AngularJS typings ()
PR Close 
2018-08-06 14:52:50 -07:00
George Kalpakas
07ab98bbb0 build(upgrade): use correct sources in BUILD.bazel ()
PR Close 
2018-08-06 14:52:50 -07:00
Michael Giambalvo
16c03c0f38 fix(core): In Testability.whenStable update callback, pass more complete ()
data about tasks.

When building a list of pending tasks for callers of whenStable(),
Testability will copy data about the task into a new object, in order to
avoid leaking references to tasks.

This change copies more properties from Tasks into the list of pending
tasks, as well as a reference to Task.data to give callers more
information about the tasks that are pending.

Specifically, this also copies runCount and task ID, which are needed in
order for callers to know when a given task is repeating.

PR Close 
2018-08-06 13:49:19 -07:00
Pawel Kozlowski
3355502f2f fix(ivy): support ng-container at the root of a view with delayed insertion ()
PR Close 
2018-08-06 13:47:44 -07:00
Christoffer Noring
02c15a2448 docs: update to 2nd edition of Learning Angular ()
PR Close 
2018-08-06 13:44:42 -07:00
René Ras
6861bc5b06 docs: clarify heroes example ()
PR Close 
2018-08-06 13:44:17 -07:00
Ro Savage
b8887ddf16 docs: fix table in comparing observables guide ()
PR Close 
2018-08-06 13:41:15 -07:00
vincecampanale
4933e103d3 docs(core): clarify supported ViewChild selectors ()
PR Close 
2018-08-06 13:40:47 -07:00
Vani
7d006c5005 docs(core): fix tree-shakable spelling ()
PR Close 
2018-08-06 13:40:15 -07:00
Vani
67ad59c245 docs: standardize spelling of tree-shakable ()
PR Close 
2018-08-06 13:40:15 -07:00
Dario Braun
397530ab24 docs: remove code in universal hero detail component ()
This reverts commit e9cc3dad8f39bc8dfabfb708a825f90fcd2ab697.

PR Close 
2018-08-06 13:39:23 -07:00
Daniel Ruf
a9881bb18e docs: replace npm with yarn in lockfile readme ()
PR Close 
2018-08-06 13:38:13 -07:00
Jessy Cormier
c1587029db docs: add missing word in outputs description. ()
PR Close 
2018-08-06 13:36:49 -07:00
Lukáš Matta
2b906f652f docs: fix typo ()
PR Close 
2018-08-06 13:36:09 -07:00
Trotyl
c67f1bb38e docs: several fixes for NPM package guide ()
PR Close 
2018-08-06 11:32:30 -07:00
Bartosz Wyporkiewicz
637ae135c5 docs(http): fixed example unit test for error catching ()
The example unit test should test the service when the backend
application is not available, by providing a mock error response.
Although, the test will
fail as the mock response from the server is valid (it does not simulate
a
error response, but valid response with an error status 404).
This merge request fix this issue by replacing MockResponse with
MockError

This PR resolves 19499 issue

PR Close 
2018-08-06 11:31:57 -07:00
Alex Eagle
4eb8ac6de9 build: update Bazel to 0.16 ()
PR Close 
2018-08-06 11:30:24 -07:00
Anthony Humes
ba1e25f53f fix(router): take base uri into account in setUpLocationSync() ()
Normalize the full URL (including the base uri) before passing it to
`router.navigateByUrl()`.

Fixes 

PR Close 
2018-08-06 11:11:07 -07:00
Lalith Polepeddi
97b5cb2e3b docs(aio): add Made with Angular ()
PR Close 
2018-08-06 09:50:14 -07:00
Victor Berchet
795e1e8a38 test(ivy): improve error message for the compiler compliance test ()
before:

```
Expected to find features 'import * as i0 from "@angular/core";
import { Directive, Input } from '@angular/core';

```

after:

```
Failed to find "template" after "...Component_Factory() { return new
MyComponent(); }," in:
'import * as i0 from "@angular/core";
import { Directive, Input } from '@angular/core';```

```

PR Close 
2018-08-05 15:31:19 -07:00
Victor Berchet
aea8832243 refactor(ivy): misc cleanup ()
PR Close 
2018-08-05 15:31:19 -07:00
Victor Berchet
1e7ca22078 refactor(ivy): make all directives public by default ()
To match the View Engine behavior.

We should make this configurable so that the node injector is tree shaken when
directives do not need to be published.

PR Close 
2018-08-05 15:31:19 -07:00
Alex Eagle
26a15cc534 build: skip ivy builds when not publishing ()
PR Close 
2018-08-04 14:17:00 -07:00
Fabian Wiles
b0d86c1c2f refactor(bazel): dont rely on language target to downlevel for loop ()
PR Close 
2018-08-03 15:55:18 -07:00
George Kalpakas
dc0715142f test(docs-infra): log docs examples e2e spec paths to aid debugging ()
It seems that occasionally the sharding of docs examples e2e tests gets
messed up resulting in some tests not being run. This can cause CI to be
green on a PR, when they shouldn't (because the failing tests didn't run
at all).

It is unclear under what circumstances this happens, so printing the
paths of found e2e specs will help debug the issue when it comes up
again.

PR Close 
2018-08-03 15:30:31 -07:00
JoostK
4e264781ee refactor(ivy): do not mention LViewData in public documentation ()
PR Close 
2018-08-03 14:48:11 -07:00
Kara Erickson
79a9c71422 test(ivy): remove unnecessary common import ()
PR Close 
2018-08-03 14:34:02 -07:00
Pete Bacon Darwin
15cc85c54a style(common): fix short param names ()
PR Close 
2018-08-03 14:09:27 -07:00
Pete Bacon Darwin
725bae1921 docs(common): fix content errors ()
PR Close 
2018-08-03 14:09:27 -07:00
Alex Rickabaugh
eb999300d9 test(ivy): run compiler compliance tests without rebuilding core,common ()
Previously the compiler compliance tests ran and built test code with
real dependencies on @angular/core and @angular/common. This meant that
any changes to the compiler would result in long rebuild processes
for tests to rerun.

This change removes those dependencies and causes test code to be built
against the fake_core stub of @angular/core that the ngtsc tests use.
This change also removes the dependency on @angular/common entirely, as
locality means it's possible to reference *ngIf without needing to link
to an implementation.

PR Close 
2018-08-03 13:08:51 -07:00
Victor Berchet
afa6b9e794 fix(ivy): execute the optional begin and end methods of the rendererFactory ()
This is required to i.e. flush animations when using a Renderer2.
`rf.begin()` and `rf.end()` around the change detection.

PR Close 
2018-08-03 10:17:13 -07:00
Alex Rickabaugh
0822dc70f2 feat(ivy): generate .ngfactory stubs if requested ()
Existing bootstrap code in the wild depends on the existence of
.ngfactory files, which Ivy does not need. This commit adds the
capability in ngtsc to generate .ngfactory files which bridge
existing bootstrap code with Ivy.

This is an initial step. Remaining work includes complying with
the compiler option to specify a generated file directory, as well
as presumably testing in g3.

PR Close 
2018-08-03 09:42:06 -07:00
Victor Berchet
728d98d3a9 fix(ivy): add bound proerties name to template ()
Before this change bound properties would not be used when matching directives
at runtime.

That is `<ng-template [ngIf]=cond>...</ng-template>` would not trigger the
`ngIf` directive.

PR Close 
2018-08-02 22:59:04 -07:00
Victor Berchet
2f4abbf5a1 fix(ivy): fix inline template bindings parsing ()
PR Close 
2018-08-02 22:59:04 -07:00
Victor Berchet
1000fb8406 test(ivy): add tests for attributes and bound attributes to the tpl transform ()
PR Close 
2018-08-02 22:59:04 -07:00
Victor Berchet
b38931b484 fix(ivy): use devModeEqual in no change mode ()
To avoid the unfamous error `Expression has changed after it was checked.`

PR Close 
2018-08-02 22:57:28 -07:00
Kara Erickson
1fb7111da1 fix(ivy): content query results should be available in content hooks ()
PR Close 
2018-08-02 19:32:09 -07:00
Pawel Kozlowski
c2c12e52fe feat(ivy): support ng-container as a child of an already inserted view ()
PR Close 
2018-08-02 18:50:03 -07:00
Pawel Kozlowski
28c7a4efbc feat(ivy): add basic support for ng-container ()
This commit adds basic support for <ng-container> - most of the
functionality should work as long as <ng-container> is a child of
a regular element.

PR Close 
2018-08-02 18:50:03 -07:00
Igor Minar
4f741e74e1 docs: release notes for the v6.1.1 release 2018-08-02 14:23:36 -07:00
Igor Minar
6bacd32fbd release: cut the v7.0.0-beta.0 release 2018-08-02 11:42:10 -07:00
Aldo Roman Nureña
183757daa2 fix(core): fix tests for uninitialized @Output error ()
PR Close 
2018-08-02 09:37:21 -07:00
Aldo Roman
adf510f986 fix(core): throw error message when @Output not initialized ()
Closes 

PR Close 
2018-08-02 09:37:21 -07:00
Brandon Roberts
74bce18190 Revert "docs: refactor http module import for style guide app.module ()" ()
This reverts commit 88da8f3d52045aa12f6b6a499da070310ae157c6.

PR Close 
2018-08-02 09:20:12 -07:00