* template-syntax - removed word redundancies, consistent bolding rather than italics
* Some (not all) changes from PR.
* remaining changes from pull request
* since RC5 the webpack prod build is defect
Issue #10618 recommends 'mangle: { keep_fnames: true, screw_ie8: true } for the webpack UglifyJs plugin
* remove screw_ie8 option
removed the screw_ie8: true option because it is not necessary
* docs(toh-6/dart): refactoring of 'add, edit, delete heroes'
Refactoring of "add, edit, delete heroes" section of toh-6 from one big
bottom-up step into small independent feature slices, where the user
achieves a "milesone" (i.e., can run the full app) after each feature
section. The section rewrite is shorter and offers a better UX.
Other simplifications:
- Error handling is consistent: in the hero service we log to the
console, everwhere else we just let errors bubble up.
- Hero service methods renamed based on function (create, update)
rather then lower-level implementation (post, put).
- @Output properties have been eliminated (since they weren't
explained).
E2E tests now pass on both the TS and Dart sides.
* docs(toh-6/ts): refactoring of 'add, edit, delete heroes'
Refactoring of "add, edit, delete heroes" section of toh-6 from one big
bottom-up step into small independent feature slices, where the user
achieves a "milesone" (i.e., can run the full app) after each feature
section. The section rewrite is shorter and offers a better UX.
Other simplifications:
- Error handling is consistent: in the hero service we log to the
console, everwhere else we just let errors bubble up.
- Hero service methods renamed based on function (create, update)
rather then lower-level implementation (post, put).
- @Output properties have been eliminated (since they weren't
explained).
E2E tests now pass on both the TS and Dart sides.
Post-Dart-review updates included.
* docs(toh-6): ward tweaks
* example(dart/toh-4,5): getHeroesSlowly() to return getHeroes()
Have `getHeroesSlowly()` delay and then return the value of
`getHeroes()`. This makes it easier for user’s performing the tutorial
to keep this slower method as they evolve toh-5 into toh-6.
* example(ts/toh-4,5): getHeroesSlowly() to return getHeroes()
Have `getHeroesSlowly()` delay and then return the value of
`getHeroes()`. This makes it easier for user’s performing the tutorial
to keep this slower method as they evolve toh-5 into toh-6.
* docs(server-communication): Fix typo in example
Clearly we're transforming the response, not the request.
* docs(server-communication): Fix typo in example
Clearly we're transforming the response, not the request.
* lifecycle-hooks: copy latest to cache
* docs(lifecycle-hooks): post-RC5 Dart resync
- TS prose: removed mention of `routerOnActivate` which no longer
exists in the new router.
- TS improvements to the sample code have also been propagated to the
Dart sample.
Contributes to #2077.
E2E tests pass now.
* post-review updates
* glossary: replace cached by latest before edits
* docs(glossary): general cleanup and fix links
This commit addresses issues with the glossary for all languages (JS, TS, Dart).
Fixes#1123, #1838, #2036.
This was originally started as post-RC5 Dart resync, but since mixing Harp partials with Jade mixins can be problematic, this commit does a general cleanup of the 3 x 2 = 6 glossary files (found in `{ts,js,dart}/latest/{.,guide}`).
This commit builds upon #2098 (which created the first `ts/_cache` copy of the glossary), but doesn't really depend on it.
* post-review updates
* post-review updates
closes#2110
The lifecycle-hooks provided by router-deprecated has already been removed in the router, the router now uses guards rather than lifecycle-hooks to achieve the same work.
* docs(toh-5): review and update/resync Dart
**NOTE: run `gulp add-example-boilerplate` after pulling in the
commit.**
This is preparatory work for #2035.
As part of the the chapter review, the Dart .jade was enhanced to use
Jade extends (#2018).
By the same token it contributed to a post-RC5 resync (#2077). Other
key changes:
Dart and TS code:
- Eliminated `styles.1.css` in favor of docregions in `styles.css`.
- `docregion` tags renamed in a few places.
- **No other code changes**.
TS prose
- Fixed: misnamed variable `routing` -> `appRoutes`.
- All other changes are **minor copy edits**, or changes to support
Dart via Jade extends.
Diff of generated HTML for TS chapter was inspected to ensure only
minor copy edits prevailed (i.e., that the support for Jade extends had
no impact on the generated HTML).
* docs(toh-5): edits after doing tutorial
- Some adjustments following actually doing the tutorial. In some cases code shown (e.g. this is what file foo should look like now) didn't match what the user would have. E.g., lingering @Input on the hero property.
- Fixed some lingering deprecated-router prose elements on TS side (e.g., still referring to a route by the old string names like `HeroDetail`).
- Added extra step to `app.component.ts` creation rather than having a critical-call-out later on.
- Reorder some prose for better harmony between TS and Dart prose (also improves the flow).
- Moved the `styleUrls` call-out to the point of first use.
* post-review changes
* more post-review changes
* toh-6 cache update
* chore(toh-5): improve e2e test coverage
Improved test coverage. Also updated tests to make use of async/await
(so tests are more readable).
* lint feedback
* toh-6: trim spaces from cache file to simplify diff
* toh-6: copy latest over cache before editing latest
* docs(toh-6): post-RC5 Dart resync and TS fixes
Contributes to #2077.
TS-side changes include:
- Merged three versions of `app/app.module{,1,2}.ts` into a single file
and used docregions instead.
- Misnamed files:
- `rxjs-operators.ts` -> `rxjs-extensions.ts`
- `hero-search.service.html` -> `hero-search.component.html`
- Fixed BAD FILENAME error.
Lint reports no errors and toh-6 e2e tests pass.
* docs(router): fix markdown and example mixin cleanup
- Fixed: markdown text not under `:marked` region (and so that text was
not showing up in the generated html).
- Fixed: code excerpt title `constructor` -> `isSelected`.
- Cleanup of all makeExample mixin uses.
This cleanup will help make it easier to record differences with the
deprecated router chapter (which must have app-relative makeExample
paths).
* post-review updates
Found another instance of markdown (a heading) outside of a `:marked` region.
* docs(template-syntax/dart): enhancements to example code
Enhancements to `NgStyle` section in support of its API docs.
- Add feature supporting interactive update of a paragraph’s style.
- Add full type declarations.
- Replace bogus implementation of `getStyles()`.
* dartfmt updates
Patrice Chalin
Kathy Walrath
Peter Fryer-Davis
Aristeidis Bampakos
Jesús Rodríguez
Ward Bell
Wesley Cho
Patrice Delorme
John Papa
Martin-Wegner
Naomi Black
Filipe Silva
Rob Wormald
Deborah Kurata
Kapunahele Wong
Suguru Inatomi
Drew Hintz
Trotyl Yu
Gian Marco Gherardi
Brandon Roberts
Ferdinand Malcher
Cassio Landim
Daniel Kuczewski
Martin
Sarun Intaralawan
Patrice Chalin
Drew Hintz
Karl Herrick