angular-cn

Commit Graph

Author	SHA1	Message	Date
George Kalpakas	c9b36f9150	fix(dev-infra): fix error message in `invokeSetNpmDistCommand()` function (#39229 ) In #39135, the commit message string was accidentally changed from a template literal to a regular string literal. This prevented the `npmDistTag` variable from being correctly displayed in the error message. This commit fixes it by switching it back to a template literal. NOTE: This was pointed out in https://github.com/angular/angular/pull/39135#discussion_r503361412, but the PR was accidentally merged before the review feedback had been addressed. PR Close #39229	2020-10-12 12:02:48 -07:00
George Kalpakas	6947ceaf44	refactor(dev-infra): several code style and typo fixes (#39135 ) This commit addresses comments from [my review][1] on PR #38656 (which was merged without comments addressed). The changes are mostly related to code style and typos. [1]: https://github.com/angular/angular/pull/38656#pullrequestreview-482129333 PR Close #39135	2020-10-12 10:47:13 -07:00
Paul Gschwendtner	f96dcc5ce0	feat(dev-infra): tool for staging and publishing releases (#38656 ) Creates a tool for staging and publishing releases as per the new branching and versioning that has been outlined in the following document. The tool is intended to be used across the organization to ensure consistent branching/versioning and labeling: https://docs.google.com/document/d/197kVillDwx-RZtSVOBtPb4BBIAw0E9RT3q3v6DZkykU/edit#heading=h.s3qlps8f4zq7dd The tool implements the actions as outlined in the following initial plan: https://hackmd.io/2Le8leq0S6G_R5VEVTNK9A. The implementation slightly diverged in so far that it performs staging and publishing together so that releasing is a single convenient command. In case of errors for which re-running the full command is not sufficient, we want to consider adding recover functionality. e.g. when the staging completed, but the actual NPM publishing aborted unexpectedly due to build errors. PR Close #38656	2020-09-28 16:11:42 -04:00

Author

SHA1

Message

Date

George Kalpakas

c9b36f9150

fix(dev-infra): fix error message in `invokeSetNpmDistCommand()` function (#39229 )

In #39135, the commit message string was accidentally changed from a
template literal to a regular string literal. This prevented the
`npmDistTag` variable from being correctly displayed in the error
message.

This commit fixes it by switching it back to a template literal.

NOTE:
This was pointed out in
https://github.com/angular/angular/pull/39135#discussion_r503361412, but
the PR was accidentally merged before the review feedback had been
addressed.

PR Close #39229

2020-10-12 12:02:48 -07:00

George Kalpakas

6947ceaf44

refactor(dev-infra): several code style and typo fixes (#39135 )

This commit addresses comments from [my review][1] on PR #38656 (which
was merged without comments addressed). The changes are mostly related
to code style and typos.

[1]: https://github.com/angular/angular/pull/38656#pullrequestreview-482129333

PR Close #39135

2020-10-12 10:47:13 -07:00

Paul Gschwendtner

f96dcc5ce0

feat(dev-infra): tool for staging and publishing releases (#38656 )

Creates a tool for staging and publishing releases as per the
new branching and versioning that has been outlined in the following
document. The tool is intended to be used across the organization to
ensure consistent branching/versioning and labeling:

https://docs.google.com/document/d/197kVillDwx-RZtSVOBtPb4BBIAw0E9RT3q3v6DZkykU/edit#heading=h.s3qlps8f4zq7dd

The tool implements the actions as outlined in the following
initial plan: https://hackmd.io/2Le8leq0S6G_R5VEVTNK9A.

The implementation slightly diverged in so far that it performs
staging and publishing together so that releasing is a single
convenient command. In case of errors for which re-running the
full command is not sufficient, we want to consider adding
recover functionality. e.g. when the staging completed, but the
actual NPM publishing aborted unexpectedly due to build errors.

PR Close #38656

2020-09-28 16:11:42 -04:00

3 Commits