angular-cn

Commit Graph

Author	SHA1	Message	Date
JoostK	51156f3f07	fix(core): allow proper type inference when `ngFor` is used with a `trackBy` function (#42692 ) In #41995 the type of `TrackByFunction` was changed such that the declaration of a `trackBy` function did not cause the item type to be widened to the `trackBy`'s item type, which may be a supertype of the iterated type. This has introduced situations where the template type checker is now reporting errors for cases where a `trackBy` function is no longer assignable to `TrackByFunction`. This commit fixes the error by also including the item type `T` in addition to the constrained type parameter `U`, allowing TypeScript to infer an appropriate `T`. Fixes #42609 PR Close #42692	2021-07-13 14:08:05 -07:00
Paul Gschwendtner	e99af184ab	build: update API goldens after api-extractor update (#42737 ) Given we have updated API extractor to the most recent version, we need to update the API goldens because the latest version uses alias exports to avoid collisions with default library globals (like `Event`). PR Close #42737	2021-07-02 10:08:03 -07:00
Paul Gschwendtner	59fe159b78	build: update API goldens to reflect new tool (#42688 ) Updates the TS API guardian goldens with their equivalents based on the new shared dev-infra tool. PR Close #42688	2021-06-30 11:43:48 -07:00

Author

SHA1

Message

Date

JoostK

51156f3f07

fix(core): allow proper type inference when `ngFor` is used with a `trackBy` function (#42692 )

In #41995 the type of `TrackByFunction` was changed such that the
declaration of a `trackBy` function did not cause the item type to be
widened to the `trackBy`'s item type, which may be a supertype of the
iterated type. This has introduced situations where the template type
checker is now reporting errors for cases where a `trackBy` function is
no longer assignable to `TrackByFunction`.

This commit fixes the error by also including the item type `T` in
addition to the constrained type parameter `U`, allowing TypeScript to
infer an appropriate `T`.

Fixes #42609

PR Close #42692

2021-07-13 14:08:05 -07:00

Paul Gschwendtner

e99af184ab

build: update API goldens after api-extractor update (#42737 )

Given we have updated API extractor to the most recent
version, we need to update the API goldens because the
latest version uses alias exports to avoid collisions with
default library globals (like `Event`).

PR Close #42737

2021-07-02 10:08:03 -07:00

Paul Gschwendtner

59fe159b78

build: update API goldens to reflect new tool (#42688 )

Updates the TS API guardian goldens with their equivalents
based on the new shared dev-infra tool.

PR Close #42688

2021-06-30 11:43:48 -07:00

3 Commits